Complete the current test suite (#250)

- Add to the specs the registered classes and functions recorded via the keys `'registered-classes'` and `'registered-functions'`. This should not change the current behaviour but makes it easier to test this part of the whitelisting feature.
- Add a check to ensure the keys used in `'meta'` or a spec definition are all valid
- Add the missing `'registered-functions'` where appropriate
- Moved the specs testing from `PhpScoperTest` to `PhpScoperSpecTest` to make it more readable
- Do not record the functions return types (which can be identifiers or names as well)

Author: theofidry

specs/binary/simple.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Some statements made directly in the global namespace' => <<<'PHP'

specs/class-FQ.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Different kind of whitelisted class constant calls in the global scope' => [

specs/class-const/global-scope-single-level-with-single-level-use-statement-and-alias.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a aliased class which is imported via an aliased use statement and which belongs to the global namespace' => [

specs/class-const/global-scope-single-level-with-single-level-use-statement.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a class which is imported via a use statement and which belongs to the global namespace' => [

specs/class-const/global-scope-single-level.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a class belonging to the global namespace' => [

specs/class-const/global-scope-two-level-with-single-level-use-and-alias.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a namespaced class partially imported with an aliased use statement' => [

specs/class-const/global-scope-two-level-with-single-level-use.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a namespaced class partially imported with a use statement' => [

specs/class-const/global-scope-two-level.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a namespaced class' => [

specs/class-const/namespace-scope-single-level-with-single-level-use-statement-and-alias.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a aliased class which is imported via an aliased use statement and which belongs to the global namespace' => [

specs/class-const/namespace-scope-single-level.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a class belonging to the global namespace or the current namespace' => [