Update phpstan (#427)

Author: Simon Mönch

.github/workflows/build.yml

@@ -12,6 +12,7 @@ jobs:
         runs-on: ubuntu-latest
         name: Build and test
         strategy:
+            fail-fast: false
             matrix:
                 php: [ "7.2", "7.4" ]
                 composer-version: [ "1" ]

Makefile

@@ -6,7 +6,7 @@ MAKEFLAGS += --no-builtin-rules
 
 PHPBIN=php
 PHPNOGC=php -d zend.enable_gc=0
-PHPSTAN_URL=https://github.com/phpstan/phpstan/releases/download/0.12.2/phpstan.phar
+PHPSTAN_URL=https://github.com/phpstan/phpstan/releases/download/0.12.53/phpstan.phar
 
 SRC_FILES=$(shell find bin/ src/ -type f)
 

src/Configuration.php

@@ -68,8 +68,6 @@ final class Configuration
     /**
      * @param string|null $path  Absolute path to the configuration file.
      * @param string[]    $paths List of paths to append besides the one configured
-     *
-     * @return self
      */
     public static function load(string $path = null, array $paths = []): self
     {
@@ -96,7 +94,7 @@ public static function load(string $path = null, array $paths = []): self
                 );
             }
 
-            if (false === is_file($path) && false === (is_link($path) && is_file(readlink($path)))) {
+            if (false === is_file($path) && false === (is_link($path) && false !== readlink($path) && is_file(readlink($path)))) {
                 throw new InvalidArgumentException(
                     sprintf(
                         'Expected the path of the configuration file to be a file but "%s" appears to be a '
@@ -464,8 +462,6 @@ private static function retrieveFinders(array $config): array
 
     /**
      * @param string[] $paths
-     *
-     * @return iterable
      */
     private static function retrieveFilesFromPaths(array $paths): iterable
     {
@@ -512,8 +508,6 @@ private static function retrieveFilesFromPaths(array $paths): iterable
     }
 
     /**
-     * @param Iterator $files
-     *
      * @return string[][] Array of tuple with the first argument being the file path and the second its contents
      */
     private static function retrieveFilesWithContents(Iterator $files): array

src/PhpParser/NodeVisitor/ConstStmtReplacer.php

@@ -63,7 +63,7 @@ public function __construct(Whitelist $whitelist, FullyQualifiedNameResolver $na
      */
     public function enterNode(Node $node): Node
     {
-        if (false === ($node instanceof Const_)) {
+        if (!$node instanceof Const_) {
             return $node;
         }