build: Add rector to the auto-review process (#908)

Author: theofidry

.github/workflows/lint.yaml

@@ -78,6 +78,38 @@ jobs:
                 run: make phpstan_install
 
             -   run: make phpstan
+    rector:
+        runs-on: ubuntu-latest
+        name: Rector
+        steps:
+            -   name: Checkout
+                uses: actions/checkout@v4
+
+            -   name: Setup PHP
+                uses: shivammathur/setup-php@v2
+                with:
+                    php-version: '8.1'
+                    tools: composer
+                    coverage: none
+
+            # https://docs.github.com/en/actions/learn-github-actions/workflow-commands-for-github-actions#setting-an-environment-variable
+            -   name: Configure composer root version
+                run: |
+                    source .composer-root-version
+                    echo "COMPOSER_ROOT_VERSION=${COMPOSER_ROOT_VERSION}" >> $GITHUB_ENV
+
+            -   name: Install Composer dependencies
+                uses: ramsey/composer-install@v2
+
+            -   name: Install PHPStan
+                uses: ramsey/composer-install@v2
+                with:
+                    working-directory: 'vendor-bin/rector'
+
+            -   name: Ensure PHPStan Makefile target is up to date
+                run: make rector_install
+
+            -   run: make rector_lint
 
     # This is a "trick", a meta task which does not change, and we can use in
     # the protected branch rules as opposed to the E2E tests one above which
@@ -90,6 +122,7 @@ jobs:
         needs:
             - cs
             - phpstan
+            - rector
         if: always()
         steps:
             - name: Successful run

Makefile

@@ -99,7 +99,7 @@ phpstan: $(PHPSTAN_BIN)
 
 .PHONY: autoreview
 autoreview: ## Runs the AutoReview checks
-autoreview: cs_lint phpstan covers_validator
+autoreview: cs_lint phpstan rector_lint covers_validator
 
 .PHONY: test
 test: ## Runs all the tests
@@ -274,6 +274,9 @@ vendor-bin/phpstan/composer.lock: vendor-bin/phpstan/composer.json
 	@echo "$(@) is not up to date. You may want to run the following command:"
 	@echo "$$ composer bin phpstan update --lock && touch -c $(@)"
 
+.PHONY: rector_install
+rector_install: $(RECTOR_BIN)
+
 $(RECTOR_BIN): vendor-bin/rector/vendor
 	touch -c $@
 vendor-bin/rector/vendor: vendor-bin/rector/composer.lock $(COMPOSER_BIN_PLUGIN_VENDOR)