Switch to the whitelist class for the autoload generator (#216)

Author: theofidry

README.md

@@ -288,6 +288,9 @@ The class aliasing mechanism is done like follows:
   which will ensure the `class_alias()` statement is executed
 
 It is done this way to ensure prefixed and whitelisted classes can co-exist together without breaking the autoloading.
+The `class_exists()` statements are dumped in `vendor/scoper-autoload.php`, do not forget to include this file in favour
+of `vendor/autoload.php`. This part is however sorted out by [Box][box] if you are using it with the
+[`PhpScoper` compactor][php-scoper-integration]. 
 
 The constant aliasing mechanism is done by transforming the constant declaration into a `define()` statement when this
 is not already the case. Note that there is a difference here since `define()` defines a constant at runtime whereas

src/Autoload/ScoperAutoloadGenerator.php

@@ -14,16 +14,14 @@
 
 namespace Humbug\PhpScoper\Autoload;
 
+use Humbug\PhpScoper\Whitelist;
 use function array_map;
 
 final class ScoperAutoloadGenerator
 {
     private $whitelist;
 
-    /**
-     * @param string[] $whitelist
-     */
-    public function __construct(array $whitelist)
+    public function __construct(Whitelist $whitelist)
     {
         $this->whitelist = $whitelist;
     }
@@ -61,7 +59,7 @@ function (string $whitelistedElement) use ($prefix): string {
                     $whitelistedElement
                 );
             },
-            $this->whitelist
+            $this->whitelist->getClassWhitelistArray()
         );
     }
 }

src/Whitelist.php

@@ -79,6 +79,14 @@ public function isClassWhitelisted(string $name): bool
         return in_array($name, $this->classes, true);
     }
 
+    /**
+     * @return string[]
+     */
+    public function getClassWhitelistArray(): array
+    {
+        return $this->classes;
+    }
+
     public function isNamespaceWhitelisted(string $name): bool
     {
         foreach ($this->namespaces as $namespace) {

tests/Autoload/ScoperAutoloadGeneratorTest.php

@@ -14,16 +14,14 @@
 
 namespace Humbug\PhpScoper\Autoload;
 
+use Humbug\PhpScoper\Whitelist;
 use PHPUnit\Framework\TestCase;
 
 class ScoperAutoloadGeneratorTest extends TestCase
 {
     public function test_generate_the_autoload()
     {
-        $whitelist = [
-            'A\Foo',
-            'B\Bar',
-        ];
+        $whitelist = Whitelist::create('A\Foo', 'B\Bar');
 
         $prefix = 'Humbug';
 

tests/WhitelistTest.php

@@ -34,9 +34,7 @@ public function test_it_can_be_created_from_a_list_of_strings(
 
         $whitelistReflection = new ReflectionClass(Whitelist::class);
 
-        $whitelistClassReflection = $whitelistReflection->getProperty('classes');
-        $whitelistClassReflection->setAccessible(true);
-        $actualClasses = $whitelistClassReflection->getValue($whitelistObject);
+        $actualClasses = $whitelistObject->getClassWhitelistArray();
 
         $whitelistNamespaceReflection = $whitelistReflection->getProperty('namespaces');
         $whitelistNamespaceReflection->setAccessible(true);