Fix prefixing classes used in try/catch blocks (#167)

Author: theofidry

specs/catch.php

@@ -0,0 +1,156 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the humbug/php-scoper package.
+ *
+ * Copyright (c) 2017 Théo FIDRY <[email protected]>,
+ *                    Pádraic Brady <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+return [
+    'meta' => [
+        'title' => 'Miscellaneous',
+        // Default values. If not specified will be the one used
+        'prefix' => 'Humbug',
+        'whitelist' => [],
+    ],
+
+    'Catch an internal class' => <<<'PHP'
+<?php
+
+try {
+    echo "foo";
+} catch (Throwable $t) {
+}
+----
+<?php
+
+namespace Humbug;
+
+try {
+    echo "foo";
+} catch (\Throwable $t) {
+}
+
+PHP
+    ,
+
+    'Catch an internal class in a namespace' => <<<'PHP'
+<?php
+
+namespace Acme;
+
+try {
+    echo "foo";
+} catch (\Throwable $t) {
+}
+----
+<?php
+
+namespace Humbug\Acme;
+
+try {
+    echo "foo";
+} catch (\Throwable $t) {
+}
+
+PHP
+    ,
+
+    'Catch an custom exception class' => <<<'PHP'
+<?php
+
+try {
+    echo "foo";
+} catch (FooException $t) {
+}
+----
+<?php
+
+namespace Humbug;
+
+try {
+    echo "foo";
+} catch (\Humbug\FooException $t) {
+}
+
+PHP
+    ,
+
+    'Catch an custom exception class in a namespace' => <<<'PHP'
+<?php
+
+namespace Acme;
+
+try {
+    echo "foo";
+} catch (FooException $t) {
+}
+----
+<?php
+
+namespace Humbug\Acme;
+
+try {
+    echo "foo";
+} catch (\Humbug\Acme\FooException $t) {
+}
+
+PHP
+    ,
+
+    'Catch an custom exception class in a namespace imported with a use statement' => <<<'PHP'
+<?php
+
+namespace Acme;
+
+use X\FooException;
+
+try {
+    echo "foo";
+} catch (FooException $t) {
+}
+----
+<?php
+
+namespace Humbug\Acme;
+
+use Humbug\X\FooException;
+try {
+    echo "foo";
+} catch (\Humbug\X\FooException $t) {
+}
+
+PHP
+    ,
+
+    'Multiple catch statement' => <<<'PHP'
+<?php
+
+namespace Acme;
+
+use X\FooException;
+
+try {
+    echo "foo";
+} catch (FooException | \Throwable $t) {
+}
+----
+<?php
+
+namespace Humbug\Acme;
+
+use Humbug\X\FooException;
+try {
+    echo "foo";
+} catch (\Humbug\X\FooException|\Throwable $t) {
+}
+
+PHP
+    ,
+];

src/NodeVisitor/NameStmtPrefixer.php

@@ -26,6 +26,7 @@
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\NullableType;
 use PhpParser\Node\Param;
+use PhpParser\Node\Stmt\Catch_;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Function_;
@@ -106,6 +107,7 @@ private function prefixName(Name $name): Node
                 || $parentNode instanceof New_
                 || $parentNode instanceof Class_
                 || $parentNode instanceof Interface_
+                || $parentNode instanceof Catch_
             )
         ) {
             return $name;