Fix the version used in the PHAR (#259)

theofidry · web-flow · commit 6dc68c350ae7 · 2018-08-10T13:11:31.000+02:00
Closes #257
diff --git a/.gitignore b/.gitignore
@@ -8,6 +8,7 @@
 /fixtures/set004/scoper.inc.php
 /fixtures/*/.box_dump/
 /fixtures/*/vendor/
+.phpunit*
 /vendor/
 /vendor-bin/*/vendor/
 /vendor-bin/*/bin/
diff --git a/box.json.dist b/box.json.dist
@@ -7,6 +7,7 @@
     "files": [
         "src/scoper.inc.php.tpl"
     ],
+    "git": "git_version_placeholder",
 
     "compression": "GZ",
 
diff --git a/src/functions.php b/src/functions.php
@@ -66,9 +66,13 @@ function create_application(): SymfonyApplication
  */
 function get_version(): string
 {
+    if ('phar:' === substr(__FILE__, 0, 5)) {
+        return '@git_version_placeholder@';
+    }
+
     $rawVersion = Versions::getVersion('humbug/php-scoper');
 
-    list($prettyVersion, $commitHash) = explode('@', $rawVersion);
+    [$prettyVersion, $commitHash] = explode('@', $rawVersion);
 
     return (1 === preg_match('/9{7}/', $prettyVersion)) ? $commitHash : $prettyVersion;
 }

Original file line number	Diff line number	Diff line change
`@@ -66,9 +66,13 @@ function create_application(): SymfonyApplication`
`66`	`66`	`*/`
`67`	`67`	`function get_version(): string`
`68`	`68`	`{`
	`69`	`+ if ('phar:' === substr(__FILE__, 0, 5)) {`
	`70`	`+ return '@git_version_placeholder@';`
	`71`	`+ }`
	`72`	`+`
`69`	`73`	`$rawVersion = Versions::getVersion('humbug/php-scoper');`
`70`	`74`
`71`		`- list($prettyVersion, $commitHash) = explode('@', $rawVersion);`
	`75`	`+ [$prettyVersion, $commitHash] = explode('@', $rawVersion);`
`72`	`76`
`73`	`77`	`return (1 === preg_match('/9{7}/', $prettyVersion)) ? $commitHash : $prettyVersion;`
`74`	`78`	`}`