Sign PHARs (#124)

Author: theofidry

.gitignore

@@ -1,12 +1,12 @@
-/bin/php-scoper.phar
-/bin/php-scoper.phar.pubkey
-/bin/php-scoper-old.phar
-/bin/php-scoper-old.phar.pubkey
-/bin/php-scoper.phar.temp.pubkey
+/bin/php-scoper*.phar
+/bin/php-scoper*.phar.pubkey
+/bin/php-scoper.phar*.pubkey
 /box.json
-/dist/
 /build/
+/dist/
 /fixtures/set004/scoper.inc.php
 /fixtures/*/vendor
 /vendor/
 /vendor-bin/box/vendor/
+/.travis/
+!/.travis/.gitkeep

.travis.yml

@@ -35,5 +35,19 @@ script:
         make tu
     fi
 
+deploy:
+  provider: releases
+  api_key:
+    secure: zFEfQrogmKsNB+6Y3B8df4cDtfOhaH7DpdOY6AzV9l/YnCVsO8zkFXdNUOynC4FxN82KSjEK9jP8dX9FgS4O8gdLMfWxp4eutvrxBYDazdiFJxRQMiE9O77jAnpcmxpsvNxzY+tNqUduAkaj3dj0uRuD5yttBhaVArosUEyRuhdIoGorfzooY3Q0zqzEy/dpm2EqJ2orXOvVmxreKyVgybalkHktEGNaPDaMgEMsfoIRNeHPP8yRmUw7uIYzbXOvIRXzeulNrBpe2GFhs9fwf3QjDJGDBJG1/Xw39+PV2elJDIQDLMUNQcQu/Uw+gpoUwXzr5VSL+HVgPizzSpvkcBU2YxoY6d3EAcjb0gH9RPC3qP/Kvy9qdON1kEBUarI3WiIpYTMPbatjB2KAIpo6x9njHqbkwKtzrfTBr2QaC72/vUJ0+HmOnJEtrqffqbUDCdltbuQr1P/mJ3RoIkMHZLJtlBzMmgBMA6q1XoGJ7z9ZJINvKc8FBsBoDMTH8Hyr2fNMLWogvEcNW44CmiQXqOuoyg/OCRA0zGaZ6nr7zGWn7PdhfkauWWIwZYZmDnb4Gbibj4Q97E9p8ZFE3jCWXgqCdiVfDyQX4CdrJsRgSFlQl5dm75uh5VJg24dqQLt4qeLWlBpwpI9CWJZNseQpblYxoH8RwhdDr4LLgMUrrK0=
+  file:
+    - bin/php-scoper.phar
+    - bin/php-scoper.phar.pubkey
+  skip_cleanup: true
+  on:
+    tags: true
+    repo: humbug/php-scoper
+    php:  '7.1'
+    condition: "$COVERAGE"
+
 notifications:
-    email: false
+    email: false

.travis/.gitkeep

@@ -22,6 +22,8 @@
             "in": "."
         }
     ],
+    "algorithm": "OPENSSL",
+    "key": ".travis/php-scoper-private.pem",
     "compression": "GZ",
     "compactors": [
         "Herrera\\Box\\Compactor\\Json",

box.json.dist

@@ -68,7 +68,7 @@ private function resolveNodeName(Name $name, ?Name $namespace, ?Name $use): Name
 
         if (
             ($parentNode instanceof ConstFetch || $parentNode instanceof FuncCall)
-            && count($name->parts) === 1
+            && 1 === count($name->parts)
         ) {
             // Ambiguous name, cannot determine the FQ name
             return $name;

src/NodeVisitor/Resolver/FullyQualifiedNameResolver.php

@@ -70,13 +70,13 @@ private function shouldPrefixUseStmt(UseUse $use): bool
 
         if (1 === count($use->name->parts)) {
             return
-                $useType !== Use_::TYPE_NORMAL
+                Use_::TYPE_NORMAL !== $useType
                 || ($this->globalWhitelister)($use->name->getFirst())
             ;
         }
 
         return false === (
-            $useType === Use_::TYPE_NORMAL
+            Use_::TYPE_NORMAL === $useType
             && in_array((string) $use->name, $this->whitelist)
         );
     }

src/NodeVisitor/UseStmt/UseStmtPrefixer.php

@@ -74,18 +74,6 @@ function create_application(): SymfonyApplication
  */
 function get_version(): string
 {
-    if ('phar:' === substr(__FILE__, 0, 5)) {
-        $gitVersion = '@git-version@';
-        $semanticVersion = preg_replace(
-            ["/\.\d\-/", "/\-/"],
-            ['-', '-dev+'],
-            $gitVersion,
-            1
-        );
-
-        return $semanticVersion;
-    }
-
     $rawVersion = Versions::getVersion('humbug/php-scoper');
 
     list($prettyVersion, $commitHash) = explode('@', $rawVersion);