Add lint workflow for phpstan and phpcs (#431)

Closes #430

Author: Simon Mönch

.github/workflows/build.yml

@@ -82,10 +82,6 @@ jobs:
                 if: matrix.publish-phar == false
                 run: make tu
 
-            -   name: Run phpstan
-                if: matrix.publish-phar == false
-                run: make phpstan
-
             -   uses: actions/upload-artifact@v1
                 name: Publish the PHAR
                 if: matrix.publish-phar == true

.github/workflows/lint.yml

@@ -0,0 +1,46 @@
+name: Lint
+
+on:
+    push:
+        branches: [ master ]
+    pull_request:
+
+jobs:
+    tests:
+        runs-on: ubuntu-latest
+        name: Lint ${{ matrix.check }}
+        strategy:
+            fail-fast: false
+            matrix:
+                php: [ "7.4" ]
+                check: [ "cs", "phpstan"]
+
+        steps:
+            -   uses: actions/checkout@v2
+
+            -   name: Setup PHP
+                uses: shivammathur/setup-php@v2
+                with:
+                    php-version: "${{ matrix.php }}"
+
+            -   name: Get composer cache directory
+                id: composercache
+                run: echo "::set-output name=dir::$(composer config cache-files-dir)"
+
+            -   name: Cache composer dependencies
+                uses: actions/cache@v2
+                with:
+                    path: ${{ steps.composercache.outputs.dir }}
+                    key: ${{ runner.os }}-composer-cache-${{ hashFiles('**/composer.lock') }}
+                    restore-keys: ${{ runner.os }}-composer-cache-
+
+            -   name: Set composer root version
+                run: |
+                    source .composer-root-version
+                    echo "COMPOSER_ROOT_VERSION=${COMPOSER_ROOT_VERSION}" >> $GITHUB_ENV
+
+            -   name: Install dependencies
+                run: composer install --no-interaction --no-progress --no-suggest --prefer-dist
+
+            -   name: Run ${{ matrix.check }}
+                run: make ${{ matrix.check }}

Makefile

@@ -6,7 +6,6 @@ MAKEFLAGS += --no-builtin-rules
 
 PHPBIN=php
 PHPNOGC=php -d zend.enable_gc=0
-PHPSTAN_URL=https://github.com/phpstan/phpstan/releases/download/0.12.53/phpstan.phar
 
 SRC_FILES=$(shell find bin/ src/ -type f)
 
@@ -39,6 +38,11 @@ cs: $(CODE_SNIFFER) $(CODE_SNIFFER_FIX)
 	$(PHPNOGC) $(CODE_SNIFFER_FIX) || true
 	$(PHPNOGC) $(CODE_SNIFFER)
 
+.PHONY: cs-check
+cs-check: ## Checks CS
+cs-check: $(CODE_SNIFFER)
+	$(PHPNOGC) $(CODE_SNIFFER)
+
 .PHONY: phpstan
 PHPSTAN=bin/phpstan
 phpstan: ## Runs PHPStan
@@ -573,10 +577,8 @@ $(CODE_SNIFFER_FIX): vendor-bin/code-sniffer/vendor
 	composer bin code-sniffer install
 	touch $@
 
-$(PHPSTAN):
-	rm $@ || true
-	wget $(PHPSTAN_URL) -O $@
-	chmod +x $@
+$(PHPSTAN): vendor/bamarni
+	composer bin phpstan install
 	touch $@
 
 .composer-root-version:

phpcs.xml.dist

@@ -23,5 +23,5 @@
     <rule ref="SlevomatCodingStandard.Namespaces.UseDoesNotStartWithBackslash"/>
     <rule ref="SlevomatCodingStandard.PHP.OptimizedFunctionsWithoutUnpacking"/>
     <rule ref="SlevomatCodingStandard.PHP.TypeCast"/>
-    <rule ref="SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingReturnTypeHint"/>
+    <rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint.MissingAnyTypeHint"/>
 </ruleset>

vendor-bin/code-sniffer/composer.json

@@ -1,7 +1,7 @@
 {
     "require-dev": {
-        "dealerdirect/phpcodesniffer-composer-installer": "^0.5.0",
-        "slevomat/coding-standard": "^5.0",
+        "dealerdirect/phpcodesniffer-composer-installer": "^0.7",
+        "slevomat/coding-standard": "^6.0",
         "squizlabs/php_codesniffer": "^3.4"
     }
 }

vendor-bin/code-sniffer/composer.lock

@@ -0,0 +1,5 @@
+{
+    "require": {
+        "phpstan/phpstan": "^0.12.53"
+    }
+}