Fix issues reported by PHPStan (#684)

Author: theofidry

phpstan.neon.dist

@@ -27,8 +27,6 @@ parameters:
           path: 'tests/Scoper/PhpScoperTest.php'
         - message: '#Dead catch#'
           path: 'tests/Scoper/PhpScoperSpecTest.php'
-        - message: '#Cannot assign offset#'
-          path: 'tests/Scoper/PhpScoperSpecTest.php'
         - message: '#DummyScoperFactory extends @final#'
           path: 'tests/Console/Command/DummyScoperFactory.php'
         - message: '#Anonymous function should return string but returns array#'
@@ -37,3 +35,5 @@ parameters:
           path: 'tests/Console/Command/AddPrefixCommandIntegrationTest.php'
         - message: '#ConfigurationKeysTest\:\:retrieveConfigurationKeys\(\) should return array#'
           path: 'tests/Configuration/ConfigurationKeysTest.php'
+        - message: '#Property .* does not accept#'
+          path: 'src/PhpParser/NodeVisitor/UseStmt/UseStmtCollection.php'

src/Autoload/ScoperAutoloadGenerator.php

@@ -41,6 +41,7 @@ final class ScoperAutoloadGenerator
     // https://github.com/humbug/php-scoper/blob/master/docs/configuration.md#exposing-classes
     EOF;
 
+    /** @var non-empty-string */
     private static string $eol;
 
     private SymbolsRegistry $registry;
@@ -179,10 +180,6 @@ private static function wrapStatementsInNamespaceBlock(array $statements): array
             static function (string $statement) use ($indentLine): string {
                 $parts = explode(self::$eol, $statement);
 
-                if (false === $parts) {
-                    return $statement;
-                }
-
                 return implode(
                     self::$eol,
                     array_map($indentLine, $parts),

src/Configuration/RegexChecker.php

@@ -40,6 +40,7 @@ public function isRegexLike(string $value): bool
             return false;
         }
 
+        /** @var non-empty-string $firstCharacter */
         $firstCharacter = $value[0];
 
         if (!self::isValidDelimiter($firstCharacter)) {
@@ -48,7 +49,7 @@ public function isRegexLike(string $value): bool
 
         $parts = explode($firstCharacter, $value);
 
-        if (false === $parts || count($parts) !== 3) {
+        if (count($parts) !== 3) {
             return false;
         }