Merge pull request #741 from humio/mike/default_replace_all

Replace all if ReplaceAllOnUpdate strategy is set

Author: Mike Rostermund

api/v1alpha1/humiocluster_types.go

@@ -36,7 +36,7 @@ const (
 	HumioClusterUpdateStrategyOnDelete = "OnDelete"
 	// HumioClusterUpdateStrategyRollingUpdate is the update strategy that will always cause pods to be replaced one at a time
 	HumioClusterUpdateStrategyRollingUpdate = "RollingUpdate"
-	// HumioClusterUpdateStrategyReplaceAllOnUpdate is the update strategy that will replace all pods at the same time during an update.
+	// HumioClusterUpdateStrategyReplaceAllOnUpdate is the update strategy that will replace all pods at the same time during an update of either image or configuration.
 	HumioClusterUpdateStrategyReplaceAllOnUpdate = "ReplaceAllOnUpdate"
 	// HumioClusterUpdateStrategyRollingUpdateBestEffort is the update strategy where the operator will evaluate the Humio version change and determine if the
 	// Humio pods can be updated in a rolling fashion or if they must be replaced at the same time

controllers/humiocluster_pod_lifecycle.go

@@ -32,6 +32,9 @@ func NewPodLifecycleState(hnp HumioNodePool, pod corev1.Pod) *podLifecycleState
 }
 
 func (p *podLifecycleState) ShouldRollingRestart() bool {
+	if p.nodePool.GetUpdateStrategy().Type == humiov1alpha1.HumioClusterUpdateStrategyReplaceAllOnUpdate {
+		return false
+	}
 	if p.nodePool.GetUpdateStrategy().Type == humiov1alpha1.HumioClusterUpdateStrategyRollingUpdate {
 		return true
 	}