Skip to content

Command - first input value delayed when shouldFilter=false #1889

@kolaworld

Description

@kolaworld

Describe the bug

I implemented an example code to add an emoji-picker using the popover and command components.

I noticed 2 latency issues when running dev that are improved when running preview but still subtly noticeable:

  1. Lag on clicking popover trigger and popover command contents showing. This is expected because of the large size of emojis to render but flagging in case there is a quick win / optimization.

  2. With shouldFilter=false, typing the first value in the input has a noticeable lag before the input text is visible.
    It seems some internal filtering logic is still running when starting a search.
    I would expect that setting shouldFilter=false would completely delegate handling of filtering to the caller.
    Even when I comment out my custom filtering and just render the full set of emojis, searching (which should no-op) is still slow on first input.

Again this is mainly noticeable when running dev, when building and running preview it's better. So flagging in case it's still pointing to a bug.

Reproduction

Repo reproduction

Severity

annoyance

Metadata

Metadata

Assignees

No one assigned

    Labels

    triageA maintainer needs to review this issue and label it appropriately

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions