Load running processes in a thread

Author: huntfx

mousetracks2/gui/applist.py

@@ -3,13 +3,51 @@
 import sys
 
 import psutil
-from PySide6 import QtCore, QtWidgets
+from PySide6 import QtCore, QtGui, QtWidgets
 
 from .ui import applist
 from ..applications import LOCAL_PATH, AppList
 from ..constants import TRACKING_IGNORE, TRACKING_DISABLE
 
 
+PROCESS_LOAD_TEXT = 'Loading processes list...'
+
+
+class ProcessWorker(QtCore.QThread):
+    """Load a list of running processes in a thread."""
+
+    process_found = QtCore.Signal(str)
+    loading_finished = QtCore.Signal()
+
+    def __init__(self, parent: QtWidgets.QWidget | None = None) -> None:
+        super().__init__(parent)
+        self._running = True
+
+    def run(self) -> None:
+        seen: set[str] = set()
+        for proc in sorted(psutil.process_iter(attrs=['exe', 'create_time']),
+                            key=lambda proc: proc.info['create_time'] or 0.0, reverse=True):
+            if not self._running:
+                return
+
+            path = proc.info['exe']
+            if path is None:
+                continue
+
+            exe = os.path.basename(path)
+            if exe in seen:
+                continue
+            seen.add(exe)
+
+            self.process_found.emit(exe)
+
+        self.loading_finished.emit()
+
+    def cancel(self) -> None:
+        """Called by the main thread to tell this thread to stop."""
+        self._running = False
+
+
 class AppListWindow(QtWidgets.QDialog):
     """Interface to the AppList.txt file."""
 
@@ -22,9 +60,12 @@ def __init__(self, parent: QtWidgets.QWidget) -> None:
         self.ui.setupUi(self)
         self.ui.advanced.setChecked(False)
 
+        self.worker = ProcessWorker(self)
+
         self.ui.save.clicked.connect(self.save)
         self.ui.executable.currentTextChanged.connect(self.update_profile_suggestion)
         self.ui.executable.currentTextChanged.connect(self.update_matching_apps)
+        self.ui.executable.currentTextChanged.connect(self.update_button_state)
         self.ui.executable.currentIndexChanged.connect(self.executable_changed)
         self.ui.window_title.textChanged.connect(self.update_profile_suggestion)
         self.ui.window_title_enabled.toggled.connect(self.update_profile_suggestion)
@@ -36,21 +77,30 @@ def __init__(self, parent: QtWidgets.QWidget) -> None:
 
         self._populate_process_list()
 
+    def closeEvent(self, event: QtGui.QCloseEvent) -> None:
+        """Safely shut down background threads before closing."""
+        if self.worker.isRunning():
+            self.worker.cancel()
+            self.worker.wait()
+
+        super().closeEvent(event)
+
     def _populate_process_list(self) -> None:
         """Load in the list of all processes."""
         self.ui.executable.clear()
+        self.ui.executable.addItem(PROCESS_LOAD_TEXT)
 
-        seen = set()
-        for proc in sorted(psutil.process_iter(attrs=['exe', 'create_time']),
-                           key=lambda proc: proc.info['create_time'], reverse=True):
-            path = proc.info['exe']
-            if path is None:
-                continue
-            exe = os.path.basename(path)
-            if exe in seen:
-                continue
-            seen.add(exe)
-            self.ui.executable.addItem(exe)
+        self.worker.process_found.connect(self.process_found)
+        self.worker.loading_finished.connect(self.processes_loaded)
+        self.worker.start()
+
+    @QtCore.Slot(str)
+    def process_found(self, exe: str) -> None:
+        self.ui.executable.addItem(exe)
+
+    @QtCore.Slot()
+    def processes_loaded(self) -> None:
+        self.ui.executable.removeItem(0)
 
     @QtCore.Slot(int)
     def executable_changed(self, index: int) -> None:
@@ -65,6 +115,8 @@ def update_profile_suggestion(self) -> None:
         """Update the default profile name."""
         if self.ui.window_title_enabled.isChecked() and self.ui.window_title.text():
             self.ui.profile_name.setPlaceholderText(self.ui.window_title.text())
+        elif self.ui.executable.currentText() == PROCESS_LOAD_TEXT:
+            self.ui.profile_name.setPlaceholderText('')
         else:
             self.ui.profile_name.setPlaceholderText(os.path.splitext(self.ui.executable.currentText())[0])
 
@@ -95,6 +147,13 @@ def update_matching_apps(self, force: bool = False) -> None:
                 self.ui.rules.addItem(item)
         self.ui.rules.sortItems()
 
+    @QtCore.Slot()
+    def update_button_state(self):
+        """Update the state of the create and remove buttons while loading."""
+        loading = self.ui.executable.currentText() == PROCESS_LOAD_TEXT
+        self.ui.create.setEnabled(not loading)
+        self.ui.remove.setEnabled(not loading)
+
     @QtCore.Slot()
     def create_new_rule(self) -> None:
         """Create or update a rule with the current data."""