[eslint-plugin-cdk/rules/ban-lambda-runtimes] doesn't work if I rename the import

[kenberkeley]

Cause

cdkdx/packages/eslint-plugin-cdk/src/utils/cdk.ts

Line 20 in 28df1ba

node.superClass.object.name === 'cdk' &&

This line of code ⬆️ enforces we use the name cdk to import "all" from aws-cdk-lib.

e.g.

import * as cdk from "aws-cdk-lib" // ✅ works!
import * as Cdk from "aws-cdk-lib" // ❌ doesn't work!

Reason

You might be curious why I would wanna use other import names like Cdk.
Well, let's take a look at React:

// 😌
import * as React from "react"
<React.Fragment />
React.useState()

// 🥴
import * as react from "react"
<react.Fragment />
react.useState()

From the above example, we can see that capitalizing the name of import "all" makes more sense.

Workaround

• import { Stack } from "aws-cdk-lib", or
• Patch eslint-plugin-cdk@1.8.0 with ⬇️

- node.superClass.object.name === 'cdk' &&
+ node.superClass.object.name.toLowerCase() === 'cdk' &&

[kenberkeley]

Same for ⬇️

cdkdx/packages/eslint-plugin-cdk/src/rules/ban-lambda-runtimes.ts

Lines 74 to 87 in 28df1ba

	if (node.object.type === AST_NODE_TYPES.MemberExpression) {
	if (
	hasName(node.object.object, 'lambda') &&
	hasName(node.object.property, 'Runtime')
	) {
	checkRuntime(node.property);
	}
	return;
	}
	if (hasName(node.object, 'Runtime')) {
	checkRuntime(node.property);
	return;
	}

We can not assume all the developers would write import { Runtime } from "aws-cdk-lib/aws-lambda". What if somebody writes import { Runtime as LambdaRuntime } from "aws-cdk-lib/aws-lambda" to void this rule check?