-
Notifications
You must be signed in to change notification settings - Fork 19
Open
Description
We're facing an issue where if the hook un-mounts before the onload handler being called, the value of load remains true indefinitely. This makes sense if you read through the code as well.
If the component un-mounts before the handler given here gets called:
https://github.com/hupe1980/react-script-hook/blob/master/src/use-script.tsx#L111
then the load value will always remain true even on subsequent mounts because the script has been loaded and we removed the event listener for load before it could be fired. This is causing our E2E tests to break intermittently.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels