fix unused result of function bug in experimental 2^k-ary pow

hurchalla · hurchalla · commit 716e0fd918ec · 2025-10-25T17:30:20.000-07:00
diff --git a/montgomery_arithmetic/include/hurchalla/montgomery_arithmetic/detail/experimental/montgomery_pow_2kary/experimental_montgomery_pow_2kary.h b/montgomery_arithmetic/include/hurchalla/montgomery_arithmetic/detail/experimental/montgomery_pow_2kary/experimental_montgomery_pow_2kary.h
@@ -494,7 +494,7 @@ if HURCHALLA_CPP17_CONSTEXPR (CODE_SECTION == 0) {
                 SV sv = MFE::getSquaringValue(mf, result);
                 if HURCHALLA_CPP17_CONSTEXPR (USE_SLIDING_WINDOW_OPTIMIZATION) {
                     while (shift > NUMBITS_MASKBIG && (static_cast<size_t>(branchless_shift_right(n, shift-1)) & 1u) == 0) {
-                        MFE::squareSV(mf, sv);
+                        sv = MFE::squareSV(mf, sv);
                         --shift;
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -494,7 +494,7 @@ if HURCHALLA_CPP17_CONSTEXPR (CODE_SECTION == 0) {`
`494`	`494`	`SV sv = MFE::getSquaringValue(mf, result);`
`495`	`495`	`if HURCHALLA_CPP17_CONSTEXPR (USE_SLIDING_WINDOW_OPTIMIZATION) {`
`496`	`496`	`while (shift > NUMBITS_MASKBIG && (static_cast<size_t>(branchless_shift_right(n, shift-1)) & 1u) == 0) {`
`497`		`- MFE::squareSV(mf, sv);`
	`497`	`+ sv = MFE::squareSV(mf, sv);`
`498`	`498`	`--shift;`
`499`	`499`	`}`
`500`	`500`	`}`