Skip to content

Commit 0801fde

Browse files
committed
Adding ability ti hide zoom controls without disabling pinch zooming gestures
Hoping this will fix "IllegalArgumentException Receiver not registered: android.widget.ZoomButtonsController" exception seen in Firebase.
1 parent 50d62a2 commit 0801fde

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

src/android/InAppBrowser.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ public class InAppBrowser extends CordovaPlugin {
8989
private static final String EXIT_EVENT = "exit";
9090
private static final String LOCATION = "location";
9191
private static final String ZOOM = "zoom";
92+
private static final String SHOWZOOM = "showZoom";
9293
private static final String HIDDEN = "hidden";
9394
private static final String LOAD_START_EVENT = "loadstart";
9495
private static final String LOAD_STOP_EVENT = "loadstop";
@@ -117,6 +118,7 @@ public class InAppBrowser extends CordovaPlugin {
117118
private CallbackContext callbackContext;
118119
private boolean showLocationBar = true;
119120
private boolean showZoomControls = true;
121+
private boolean enableZoomControls = true;
120122
private boolean openWindowHidden = false;
121123
private boolean clearAllCache = false;
122124
private boolean clearSessionCache = false;
@@ -557,6 +559,7 @@ private InAppBrowser getInAppBrowser(){
557559
public String showWebPage(final String url, HashMap<String, String> features) {
558560
// Determine if we should hide the location bar.
559561
showLocationBar = true;
562+
enableZoomControls = true;
560563
showZoomControls = true;
561564
openWindowHidden = false;
562565
mediaPlaybackRequiresUserGesture = false;
@@ -574,7 +577,11 @@ public String showWebPage(final String url, HashMap<String, String> features) {
574577
}
575578
String zoom = features.get(ZOOM);
576579
if (zoom != null) {
577-
showZoomControls = zoom.equals("yes") ? true : false;
580+
enableZoomControls = zoom.equals("yes") ? true : false;
581+
}
582+
String showZoom = features.get(SHOWZOOM);
583+
if (showZoom != null) {
584+
showZoomControls = showZoom.equals("yes") ? true : false;
578585
}
579586
String hidden = features.get(HIDDEN);
580587
if (hidden != null) {
@@ -935,7 +942,8 @@ public void openFileChooser(ValueCallback<Uri> uploadMsg, String acceptType)
935942
WebSettings settings = inAppWebView.getSettings();
936943
settings.setJavaScriptEnabled(true);
937944
settings.setJavaScriptCanOpenWindowsAutomatically(true);
938-
settings.setBuiltInZoomControls(showZoomControls);
945+
settings.setBuiltInZoomControls(enableZoomControls);
946+
settings.setDisplayZoomControls(showZoomControls);
939947
settings.setPluginState(android.webkit.WebSettings.PluginState.ON);
940948

941949
if(android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.JELLY_BEAN_MR1) {

0 commit comments

Comments
 (0)