Support for non-english quotes

[lele394]

I've been looking around for databases/ressources with Japanese quotes including english translation. Unfortunately it's an absolute pain as the few potential sites I've found are basically in japanese (which I unfortunately don't speak).

I was wondering if support for other languages would be considered. I believe the tool would gather a greater audience if it was the case.

There are several sites such as thegoldenquotes.net, which can provide public domain quotes and be easily parsed. Please do let me know if you're interested.

I would also suggest adding a check for translation whereas if the translation is an empty string, it isn't displayed.

[hxpe-dev]

Hey @lele394

Thanks a lot for the ideas and for checking out possible sources!

I’ve been keeping kotofetch focused on Japanese quotes for now, but yeah, adding support for other languages could be really cool and make it more useful for more people. I’ll need to look into how to restructure the parts that are pretty Japan specific right now so it can handle different languages more easily.

Also, good catch on the empty translation thing, that totally makes sense. I’ll add a check so it doesn’t show up when it’s blank in the next commits!

[lele394]

I share your opinion on keeping the "front-end" geared towards japanese, that's why I use it for!

Everything is already set to be honest, you might need to refactor some of the variables and options names, other than that, it's basically done.

Japanese has the specificity that you can also have romaji + translation. I'm not sure if there are other languages like that, tho I suppose Korean, Hindi,... and other languages not using the latin alphabet could beneficiate from this. I'd say we need to iterate on it and eventually separate romaji/latin-pronounciation and translation to independent toogles with independent controls in the config for on/off and color.
Add a check into the mix to see which fields are available (ie the empty translation thing from above), and we should have a pretty customizable and dynamic tool.
People can then add and remove their quotes.toml files in any languages they wish, and we can provide default japanese quotes and optional files with other languages.

[hxpe-dev]

Yeah that makes total sense.

Most of it’s already there, just needs some refactoring and a few checks to make it more flexible. I really like the idea of having Japanese as the default and letting people drop in their own quotes.toml files for other languages.

I'll start working on it on my way back from the weekend!