Merge pull request #23 from hydephp/improve-internal-build-command

emmadesilva · web-flow · commit 981320ea8f0d · 2023-12-10T15:05:34.000+01:00
Improve internal build command
diff --git a/app/Commands/Internal/BuildApplicationBinaryCommand.php b/app/Commands/Internal/BuildApplicationBinaryCommand.php
@@ -61,17 +61,21 @@ protected function resetBuildEnvironment(): void
     {
         unlink(__DIR__.'/../../../config/app.php');
         rename(__DIR__.'/../../../box.json.bak', __DIR__.'/../../../box.json');
+
+        $this->clearCachedConfiguration(true);
     }
 
-    protected function clearCachedConfiguration(): void
+    protected function clearCachedConfiguration(bool $silent = false): void
     {
         $configPath = $this->laravel->getCachedConfigPath();
 
         if (File::exists($configPath)) {
             File::delete($configPath);
         }
 
-        $this->components->info('Configuration cache cleared successfully.');
+        if (! $silent) {  
+            $this->components->info('Configuration cache cleared successfully.');
+        }
     }
 
     protected function cacheConfiguration(): void

Original file line number	Diff line number	Diff line change
`@@ -61,17 +61,21 @@ protected function resetBuildEnvironment(): void`
`61`	`61`	`{`
`62`	`62`	`unlink(__DIR__.'/../../../config/app.php');`
`63`	`63`	`rename(__DIR__.'/../../../box.json.bak', __DIR__.'/../../../box.json');`
	`64`	`+`
	`65`	`+ $this->clearCachedConfiguration(true);`
`64`	`66`	`}`
`65`	`67`
`66`		`- protected function clearCachedConfiguration(): void`
	`68`	`+ protected function clearCachedConfiguration(bool $silent = false): void`
`67`	`69`	`{`
`68`	`70`	`$configPath = $this->laravel->getCachedConfigPath();`
`69`	`71`
`70`	`72`	`if (File::exists($configPath)) {`
`71`	`73`	`File::delete($configPath);`
`72`	`74`	`}`
`73`	`75`
`74`		`- $this->components->info('Configuration cache cleared successfully.');`
	`76`	`+ if (! $silent) {`
	`77`	`+ $this->components->info('Configuration cache cleared successfully.');`
	`78`	`+ }`
`75`	`79`	`}`
`76`	`80`
`77`	`81`	`protected function cacheConfiguration(): void`