Commit 62094c0
committed
refactor(hydro_lang)!: migrate Hydro IR to have Flo semantics at all levels
Previously, the Hydro -> Hydro IR layer did a bunch of work to translate between Flo semantics and DFIR semantics, so that Hydro IR -> DFIR was generally 1:1. In preparation for the simulator and DFIR's migration to Flo semantics, we now use Flo semantics in the Hydro IR (top level operators do not reset their state on batch boundaries), and shift the Flo -> DFIR semantics translation to the IR -> DFIR layer.
This also comes with a breaking API change to clean up naming and avoid function overloading. In particular, `batch` / `snapshot` are renamed to `batch_atomic` and `snapshot_atomic` for the case where the batched result is supposed to be in-sync with the atomic execution context.
There were a couple of bugs during the transition to the new IR semantics that were not caught by existing unit tests, so I added additional tests that cover each of them.
Also makes some minor improvements / bug fixes the way:
- Restricts `KeyedSingleton::snapshot` to unbounded-value only, since bounded value keyed singletons do not replay their elements
- Groups together definitions for `resolve_futures` and `resolve_futures_ordered`
- Removes various unnecessary `NoAtomic` trait bounds1 parent fc67ee7 commit 62094c0
File tree
37 files changed
+7317
-5474
lines changed- hydro_lang/src
- compile
- ir
- rewrites
- snapshots
- graph
- live_collections
- keyed_stream
- stream
- tests
- location
- hydro_std/src
- hydro_test/src
- cluster
- snapshots
- distributed/snapshots
- external_client
- local/snapshots
37 files changed
+7317
-5474
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
70 | | - | |
| 69 | + | |
| 70 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
207 | 207 | | |
208 | 208 | | |
209 | 209 | | |
210 | | - | |
211 | | - | |
| 210 | + | |
212 | 211 | | |
213 | 212 | | |
214 | 213 | | |
| |||
0 commit comments