Skip to content

Commit 80a659d

Browse files
committed
ci: warn if releasing new crate which is missing changelog
1 parent bdfd6e0 commit 80a659d

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

.github/workflows/release.yml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,15 @@ jobs:
8484
# Make sure to set this so the `gh` CLI works using our token.
8585
GH_TOKEN: ${{ steps.generate_token.outputs.token }}
8686

87-
- name: Check release.log for changelog review
87+
- name: Check release.log for issues
8888
run: |
89+
exit_code=0
8990
if grep "WOULD ask for review" release.log; then
90-
echo "Changelog review required. Please see the line above and check RELEASING.md for more details."
91-
exit 1
91+
echo "Changelog review required. Please see RELEASING.md for more details."
92+
exit_code=1
9293
fi
94+
if grep "WOULD create a new changelog" release.log; then
95+
echo "A new crate is missing its CHANGELOG.md. Please see RELEASING.md for more details."
96+
exit_code=1
97+
fi
98+
exit $exit_code

0 commit comments

Comments
 (0)