chore: update pinned rust version, clippy lints, remove some dead code (#1444)

Author: MingweiSamuel

.cargo/config.toml

@@ -1,8 +1,6 @@
 [build]
 rustflags = [
     "-Zproc-macro-backtrace",
-    "-Wunused_qualifications",
-    "-Wclippy::upper_case_acronyms",
     # Flag to make build.rs scripts generate docs. Should only be used in this repository
     # internally, not by dependants.
     '--cfg=HYDROFLOW_GENERATE_DOCS',

Cargo.toml

@@ -53,3 +53,13 @@ debug-assertions = false
 
 [profile.release.package.website_playground]
 opt-level = "s"
+
+[workspace.lints.rust]
+unused_qualifications = "warn"
+
+[workspace.lints.clippy]
+allow_attributes = "warn"
+allow_attributes_without_reason = "warn"
+explicit_into_iter_loop = "warn"
+let_and_return = "allow"
+upper_case_acronyms = "warn"

benches/Cargo.toml

@@ -5,6 +5,9 @@ version = "0.0.0"
 edition = "2021"
 license = "Apache-2.0"
 
+[lints]
+workspace = true
+
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]

benches/benches/fork_join.rs

@@ -34,7 +34,7 @@ fn benchmark_hydroflow(c: &mut Criterion) {
                 send1,
                 send2,
                 |_ctx, recv, send1, send2| {
-                    for v in recv.take_inner().into_iter() {
+                    for v in recv.take_inner() {
                         if v % 2 == 0 {
                             send1.give(Some(v));
                         } else {

benches/benches/micro_ops.rs

@@ -185,7 +185,6 @@ fn ops(c: &mut Criterion) {
                 let dist = Uniform::new(0, 100);
                 let input0: Vec<usize> = (0..NUM_INTS).map(|_| dist.sample(&mut rng)).collect();
 
-                #[allow(clippy::unnecessary_fold)]
                 {
                     hydroflow_syntax! {
                         source_iter(black_box(input0)) -> fold::<'tick>(|| 0, |accum: &mut _, elem| { *accum += elem }) -> for_each(|x| { black_box(x); });

benches/benches/reachability.rs

@@ -289,7 +289,6 @@ fn benchmark_hydroflow(c: &mut Criterion) {
     });
 }
 
-#[allow(clippy::map_clone)]
 fn benchmark_hydroflow_surface_cheating(c: &mut Criterion) {
     c.bench_function("reachability/hydroflow/surface_cheating", |b| {
         b.iter_batched(

hydro_deploy/core/Cargo.toml

@@ -7,6 +7,9 @@ license = "Apache-2.0"
 documentation = "https://docs.rs/hydro_deploy/"
 description = "Hydro Deploy"
 
+[lints]
+workspace = true
+
 [dependencies]
 anyhow = { version = "1.0.82", features = [ "backtrace" ] }
 async-process = "2.0.0"
@@ -34,3 +37,4 @@ tempfile = "3.0.0"
 tokio = { version = "1.29.0", features = [ "full" ] }
 tokio-stream = { version = "0.1.3", default-features = false }
 tokio-util = { version = "0.7.5", features = [ "compat", "io-util" ] }
+

hydro_deploy/core/src/deployment.rs

@@ -45,12 +45,12 @@ impl Deployment {
         ret
     }
 
-    #[allow(non_snake_case)]
+    #[expect(non_snake_case, reason = "constructor-esque")]
     pub fn Localhost(&self) -> Arc<LocalhostHost> {
         self.localhost_host.clone().unwrap()
     }
 
-    #[allow(non_snake_case)]
+    #[expect(non_snake_case, reason = "constructor-esque")]
     pub fn CustomService(
         &mut self,
         on: Arc<dyn Host>,
@@ -201,7 +201,6 @@ impl Deployment {
 /// Buildstructor methods.
 #[buildstructor::buildstructor]
 impl Deployment {
-    #[allow(clippy::too_many_arguments)]
     #[builder(entry = "GcpComputeEngineHost", exit = "add")]
     pub fn add_gcp_compute_engine_host(
         &mut self,
@@ -227,7 +226,6 @@ impl Deployment {
         })
     }
 
-    #[allow(clippy::too_many_arguments)]
     #[builder(entry = "AzureHost", exit = "add")]
     pub fn add_azure_host(
         &mut self,

hydro_deploy/core/src/gcp.rs

@@ -184,7 +184,10 @@ pub struct GcpComputeEngineHost {
 }
 
 impl GcpComputeEngineHost {
-    #[allow(clippy::too_many_arguments)] // TODO(mingwei)
+    #[expect(
+        clippy::too_many_arguments,
+        reason = "internal code called by builder elsewhere"
+    )]
     pub fn new(
         id: usize,
         project: impl Into<String>,

hydro_deploy/core/src/hydroflow_crate/build.rs

@@ -35,7 +35,7 @@ pub struct BuildParams {
 }
 impl BuildParams {
     /// Creates a new `BuildParams` and canonicalizes the `src` path.
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments, reason = "internal code")]
     pub fn new(
         src: impl AsRef<Path>,
         bin: Option<String>,