cleanup

Author: hydropix

src/api/blueprints/config_routes.py

@@ -139,14 +139,8 @@ def mask_api_key(key):
             "gemini_api_key_configured": bool(GEMINI_API_KEY),
             "openai_api_key_configured": bool(OPENAI_API_KEY),
             "openrouter_api_key_configured": bool(OPENROUTER_API_KEY)
-            # Languages are no longer sent from server - handled by browser detection
         }
 
-        if DEBUG_MODE:
-            logger.debug(f"📤 /api/config response:")
-            logger.debug(f"   api_endpoint: {DEFAULT_OLLAMA_API_ENDPOINT}")
-            logger.debug(f"   default_model: {DEFAULT_MODEL}")
-
         return jsonify(config_response)
 
     @bp.route('/api/config/max-tokens', methods=['GET'])
@@ -257,9 +251,6 @@ def _get_openai_models(provided_api_key=None, api_endpoint=None):
             if api_key:
                 headers['Authorization'] = f'Bearer {api_key}'
 
-            if DEBUG_MODE:
-                logger.debug(f"📥 Fetching models from OpenAI-compatible endpoint: {models_url}")
-
             response = requests.get(models_url, headers=headers, timeout=10)
 
             if response.status_code == 200:
@@ -295,19 +286,11 @@ def _get_openai_models(provided_api_key=None, api_endpoint=None):
                             "count": len(models)
                         })
 
-            # If we get here, either request failed or no models returned
-            # Fall back to static list
-            if DEBUG_MODE:
-                logger.debug(f"⚠️ No models returned from {base_url}, using fallback list")
-
         except requests.exceptions.ConnectionError as e:
-            error_msg = f"Connection error to {base_url}"
-            if DEBUG_MODE:
-                logger.debug(f"❌ OpenAI-compatible endpoint connection error: {error_msg}")
+            pass
 
         except Exception as e:
-            if DEBUG_MODE:
-                logger.debug(f"❌ OpenAI-compatible endpoint error: {e}")
+            pass
 
         # Fallback: return static OpenAI models
         model_ids = [m['id'] for m in openai_static_models]
@@ -375,59 +358,33 @@ def _get_ollama_models():
         """Get available models from Ollama API"""
         ollama_base_from_ui = request.args.get('api_endpoint', DEFAULT_OLLAMA_API_ENDPOINT)
 
-        if DEBUG_MODE:
-            logger.debug(f"📥 /api/models request for Ollama")
-            logger.debug(f"   api_endpoint from UI: {ollama_base_from_ui}")
-            logger.debug(f"   default endpoint: {DEFAULT_OLLAMA_API_ENDPOINT}")
-
         try:
             base_url = ollama_base_from_ui.split('/api/')[0]
             tags_url = f"{base_url}/api/tags"
 
-            if DEBUG_MODE:
-                logger.debug(f"   Connecting to: {tags_url}")
-
-            response = requests.get(tags_url, timeout=10)  # Increased timeout from 5 to 10
-
-            if DEBUG_MODE:
-                logger.debug(f"   Response status: {response.status_code}")
+            response = requests.get(tags_url, timeout=10)
 
             if response.status_code == 200:
                 data = response.json()
                 models_data = data.get('models', [])
                 model_names = [m.get('name') for m in models_data if m.get('name')]
 
-                if DEBUG_MODE:
-                    logger.debug(f"   Models found: {model_names}")
-
                 return jsonify({
                     "models": model_names,
                     "default": DEFAULT_MODEL if DEFAULT_MODEL in model_names else (model_names[0] if model_names else DEFAULT_MODEL),
                     "status": "ollama_connected",
                     "count": len(model_names)
                 })
-            else:
-                if DEBUG_MODE:
-                    logger.debug(f"   ❌ Non-200 response: {response.status_code}")
-                    logger.debug(f"   Response body: {response.text[:500]}")
 
         except requests.exceptions.ConnectionError as e:
             error_msg = f"Connection refused to {tags_url}. Is Ollama running?"
-            if DEBUG_MODE:
-                logger.debug(f"   ❌ ConnectionError: {e}")
             print(f"❌ {error_msg}")
         except requests.exceptions.Timeout as e:
             error_msg = f"Timeout connecting to {tags_url} (10s)"
-            if DEBUG_MODE:
-                logger.debug(f"   ❌ Timeout: {e}")
             print(f"❌ {error_msg}")
         except requests.exceptions.RequestException as e:
-            if DEBUG_MODE:
-                logger.debug(f"   ❌ RequestException: {type(e).__name__}: {e}")
             print(f"❌ Could not connect to Ollama at {ollama_base_from_ui}: {e}")
         except Exception as e:
-            if DEBUG_MODE:
-                logger.debug(f"   ❌ Unexpected error: {type(e).__name__}: {e}")
             print(f"❌ Error retrieving models from {ollama_base_from_ui}: {e}")
 
         return jsonify({
@@ -477,8 +434,6 @@ def get_model_warning():
             })
 
         except Exception as e:
-            if DEBUG_MODE:
-                logger.debug(f"Error getting model warning: {e}")
             return jsonify({"warning": None, "behavior": None, "error": str(e)})
 
     def _get_env_file_path():
@@ -568,8 +523,6 @@ def save_settings():
             'DEFAULT_MODEL',
             'LLM_PROVIDER',
             'API_ENDPOINT'
-            # DEFAULT_SOURCE_LANGUAGE and DEFAULT_TARGET_LANGUAGE removed
-            # Languages are now auto-detected (source) and browser-detected (target)
         }
 
         try:
@@ -617,7 +570,6 @@ def get_settings():
             "default_model": DEFAULT_MODEL or "",
             "llm_provider": os.getenv('LLM_PROVIDER', 'ollama'),
             "api_endpoint": DEFAULT_OLLAMA_API_ENDPOINT or ""
-            # Languages are no longer stored in .env - auto-detected per session
         })
 
     return bp

src/web/static/js/index.js

@@ -246,14 +246,10 @@ function initializeState() {
 
 /**
  * Calculate and apply preview height based on MAX_TOKENS_PER_CHUNK
- * Formula: Fixed 300px height regardless of token count
- * @param {number} maxTokens - MAX_TOKENS_PER_CHUNK value (not used, kept for API compatibility)
+ * @param {number} maxTokens - MAX_TOKENS_PER_CHUNK value
  */
 function updatePreviewHeight(maxTokens = 450) {
-    // Fixed height of 300px
     const fixedHeight = 300;
-
-    // Apply to CSS variable
     document.documentElement.style.setProperty('--preview-height', `${fixedHeight}px`);
 }
 
@@ -535,7 +531,6 @@ async function showTTSModal(filename, filepath) {
         providersInfo = providersInfo.providers || {};
         voicePrompts = voicePrompts.voice_prompts || [];
     } catch {
-        // TTS info load failed
     }
 
     const isChatterboxAvailable = providersInfo.chatterbox?.available || false;

src/web/static/js/translation/batch-controller.js

@@ -40,8 +40,6 @@ function getTranslationConfig(file) {
 
     const provider = DomHelpers.getValue('llmProvider');
 
-    // Build prompt options object
-    // Technical content protection is always enabled
     const promptOptions = {
         preserve_technical_content: true,
         text_cleanup: DomHelpers.getElement('textCleanup')?.checked || false,
@@ -62,27 +60,21 @@ function getTranslationConfig(file) {
         gemini_api_key: provider === 'gemini' ? ApiKeyUtils.getValue('geminiApiKey') : '',
         openai_api_key: provider === 'openai' ? ApiKeyUtils.getValue('openaiApiKey') : '',
         openrouter_api_key: provider === 'openrouter' ? ApiKeyUtils.getValue('openrouterApiKey') : '',
-        // Advanced settings (chunk_size, timeout, context_window, max_attempts, retry_delay)
-        // are now controlled via .env only - server will use defaults from config.py
-        input_filename: file.name,  // Store original filename for UI restoration after browser refresh
+        input_filename: file.name,
         output_filename: file.outputFilename,
         file_type: file.fileType,
         prompt_options: promptOptions,
-        // Bilingual output (original + translation interleaved)
         bilingual_output: DomHelpers.getElement('bilingualMode')?.checked || false,
-        // TTS configuration
         tts_enabled: ttsEnabled,
         tts_voice: ttsEnabled ? (DomHelpers.getValue('ttsVoice') || '') : '',
         tts_rate: ttsEnabled ? (DomHelpers.getValue('ttsRate') || '+0%') : '+0%',
         tts_format: ttsEnabled ? (DomHelpers.getValue('ttsFormat') || 'opus') : 'opus',
         tts_bitrate: ttsEnabled ? (DomHelpers.getValue('ttsBitrate') || '64k') : '64k'
     };
 
-    // Handle file input based on type
     if (file.fileType === 'epub' || file.fileType === 'srt') {
         config.file_path = file.filePath;
     } else {
-        // Text file
         if (file.content) {
             config.text = file.content;
         } else {
@@ -123,10 +115,7 @@ export const BatchController = {
      * Start batch translation
      */
     async startBatchTranslation() {
-        // Wait for TranslationTracker to be fully initialized
         if (!TranslationTracker.isInitialized || !TranslationTracker.isInitialized()) {
-            console.warn('TranslationTracker not yet initialized, waiting...');
-            // Wait a bit and try again
             await new Promise(resolve => setTimeout(resolve, 100));
             if (!TranslationTracker.isInitialized || !TranslationTracker.isInitialized()) {
                 MessageLogger.showMessage('⚠️ System still initializing, please wait...', 'warning');
@@ -169,7 +158,6 @@ export const BatchController = {
             }
         }
 
-        // Update any queued files that have empty languages with current form values
         let filesUpdated = false;
         for (const file of filesToProcess) {
             if (file.status !== 'Queued') continue;
@@ -184,15 +172,12 @@ export const BatchController = {
             }
         }
 
-        // Save updated file queue if any changes
         if (filesUpdated) {
             StateManager.setState('files.toProcess', filesToProcess);
         }
 
-        // Mark batch as active
         StateManager.setState('translation.isBatchActive', true);
 
-        // Count queued files
         const queuedFilesCount = filesToProcess.filter(f => f.status === 'Queued').length;
 
         // Update UI
@@ -220,13 +205,12 @@ export const BatchController = {
      */
     async processNextFileInQueue() {
         const currentJob = StateManager.getState('translation.currentJob');
-        if (currentJob) return; // Already processing
+        if (currentJob) return;
 
         const filesToProcess = StateManager.getState('files.toProcess') || [];
         const fileToTranslate = filesToProcess.find(f => f.status === 'Queued');
 
         if (!fileToTranslate) {
-            // Batch completed
             StateManager.setState('translation.isBatchActive', false);
             StateManager.setState('translation.currentJob', null);
 
@@ -244,29 +228,24 @@ export const BatchController = {
             return;
         }
 
-        // Reset progress for new file
         ProgressManager.reset();
 
-        // Reset translation preview
         const lastTranslationPreview = DomHelpers.getElement('lastTranslationPreview');
         if (lastTranslationPreview) {
             lastTranslationPreview.innerHTML = '<div style="color: #6b7280; font-style: italic; padding: 10px;">No translation yet...</div>';
         }
 
-        // Show/hide stats based on file type
         if (fileToTranslate.fileType === 'epub') {
             DomHelpers.hide('statsGrid');
         } else {
             DomHelpers.show('statsGrid');
         }
 
-        // Update UI
         this.updateTranslationTitle(fileToTranslate);
         ProgressManager.show();
         MessageLogger.addLog(`▶️ Starting translation for: ${fileToTranslate.name} (${fileToTranslate.fileType.toUpperCase()})`);
         updateFileStatusInList(fileToTranslate.name, 'Preparing...');
 
-        // Validate API keys for cloud providers using shared utility
         const provider = DomHelpers.getValue('llmProvider');
         const endpoint = provider === 'openai' ? DomHelpers.getValue('openaiEndpoint') : '';
         const apiKeyValidation = ApiKeyUtils.validateForProvider(provider, endpoint);
@@ -290,14 +269,11 @@ export const BatchController = {
             return;
         }
 
-        // Get translation config
         const config = getTranslationConfig(fileToTranslate);
 
         try {
-            // Start translation
             const data = await ApiClient.startTranslation(config);
 
-            // Update state
             StateManager.setState('translation.currentJob', {
                 fileRef: fileToTranslate,
                 translationId: data.translation_id
@@ -306,29 +282,20 @@ export const BatchController = {
             fileToTranslate.translationId = data.translation_id;
             updateFileStatusInList(fileToTranslate.name, 'Submitted', data.translation_id);
 
-            // Show progress section immediately (don't wait for WebSocket)
-            // Use requestAnimationFrame to ensure immediate DOM update
             DomHelpers.show('progressSection');
             DomHelpers.show('interruptBtn');
 
-            // Force immediate DOM render
             requestAnimationFrame(() => {
                 const progressSection = DomHelpers.getElement('progressSection');
                 if (progressSection) {
                     progressSection.style.display = 'block';
                 }
             });
 
-            // Update title immediately
             this.updateTranslationTitle(fileToTranslate);
-
-            // Show initial message
             MessageLogger.addLog(`⏳ Translation submitted for ${fileToTranslate.name}...`);
-
-            // Remove file from processing list immediately when translation starts
             this.removeFileFromProcessingList(fileToTranslate.name);
 
-            // Emit event
             const event = new CustomEvent('translationStarted', { detail: { file: fileToTranslate, translationId: data.translation_id } });
             window.dispatchEvent(event);