From a088f4755e214db61eaafe3bc5cdbc4b9e26c28e Mon Sep 17 00:00:00 2001 From: HAYAMA Kaoru <3752189+hymkor@users.noreply.github.com> Date: Thu, 6 Nov 2025 22:56:22 +0900 Subject: [PATCH 01/15] Removed unused field: `dialect.Entry.DisplayDateTimeLayout` --- dialect/main.go | 21 ++++++++++----------- dialect/mysql/main.go | 11 +++++------ dialect/oracle/main.go | 11 +++++------ dialect/postgresql/main.go | 11 +++++------ dialect/sqlite/main.go | 13 ++++++------- dialect/sqlserver/main.go | 11 +++++------ 6 files changed, 36 insertions(+), 42 deletions(-) diff --git a/dialect/main.go b/dialect/main.go index 7a59dc4..61c07d7 100644 --- a/dialect/main.go +++ b/dialect/main.go @@ -23,17 +23,16 @@ type PlaceHolder interface { } type Entry struct { - Usage string - SqlForDesc string - SqlForTab string - TableField string - ColumnField string - DisplayDateTimeLayout string - PlaceHolder PlaceHolder - TypeNameToConv func(string) func(string) (any, error) - DSNFilter func(string) (string, error) - CanUseInTransaction func(string) bool - IsQuerySQL func(string) bool + Usage string + SqlForDesc string + SqlForTab string + TableField string + ColumnField string + PlaceHolder PlaceHolder + TypeNameToConv func(string) func(string) (any, error) + DSNFilter func(string) (string, error) + CanUseInTransaction func(string) bool + IsQuerySQL func(string) bool } func (D *Entry) TypeToConv(typeName string) func(string) (any, error) { diff --git a/dialect/mysql/main.go b/dialect/mysql/main.go index 2a187e2..883941d 100644 --- a/dialect/mysql/main.go +++ b/dialect/mysql/main.go @@ -87,12 +87,11 @@ var mySqlSpec = &dialect.Entry{ where table_type = 'BASE TABLE' and table_schema not in ('mysql', 'information_schema', 'performance_schema', 'sys')`, - DisplayDateTimeLayout: dialect.DateTimeTzLayout, - TypeNameToConv: mySQLTypeNameToConv, - PlaceHolder: &dialect.PlaceHolderQuestion{}, - DSNFilter: mySQLDSNFilter, - TableField: "TABLE_NAME", - ColumnField: "NAME", + TypeNameToConv: mySQLTypeNameToConv, + PlaceHolder: &dialect.PlaceHolderQuestion{}, + DSNFilter: mySQLDSNFilter, + TableField: "TABLE_NAME", + ColumnField: "NAME", } func init() { diff --git a/dialect/oracle/main.go b/dialect/oracle/main.go index 1798e6c..24bcf91 100644 --- a/dialect/oracle/main.go +++ b/dialect/oracle/main.go @@ -35,12 +35,11 @@ var oracleSpec = &dialect.Entry{ from all_tab_columns where table_name = UPPER(:1) order by column_id`, - SqlForTab: `select * from tab where tname not like 'BIN$%'`, - DisplayDateTimeLayout: dialect.DateTimeTzLayout, - TypeNameToConv: oracleTypeNameToConv, - TableField: "tname", - ColumnField: "name", - PlaceHolder: &dialect.PlaceHolderName{Prefix: ":", Format: "v"}, + SqlForTab: `select * from tab where tname not like 'BIN$%'`, + TypeNameToConv: oracleTypeNameToConv, + TableField: "tname", + ColumnField: "name", + PlaceHolder: &dialect.PlaceHolderName{Prefix: ":", Format: "v"}, } func init() { diff --git a/dialect/postgresql/main.go b/dialect/postgresql/main.go index 9a279e3..88ecf7f 100644 --- a/dialect/postgresql/main.go +++ b/dialect/postgresql/main.go @@ -68,12 +68,11 @@ var postgresSpec = &dialect.Entry{ from information_schema.tables where table_type = 'BASE TABLE' and table_schema not in ('pg_catalog', 'information_schema')`, - DisplayDateTimeLayout: dialect.DateTimeTzLayout, - TypeNameToConv: postgresTypeNameToConv, - PlaceHolder: &placeHolder{}, - TableField: "table_name", - ColumnField: "name", - CanUseInTransaction: canUseInTransaction, + TypeNameToConv: postgresTypeNameToConv, + PlaceHolder: &placeHolder{}, + TableField: "table_name", + ColumnField: "name", + CanUseInTransaction: canUseInTransaction, } func canUseInTransaction(sql string) bool { diff --git a/dialect/sqlite/main.go b/dialect/sqlite/main.go index 6295d23..0ce18c7 100644 --- a/dialect/sqlite/main.go +++ b/dialect/sqlite/main.go @@ -21,13 +21,12 @@ var Entry = &dialect.Entry{ union all select 'temp_schema' AS schema,name,rootpage,sql FROM sqlite_temp_schema where type = 'temp_schema'`, - DisplayDateTimeLayout: dateTimeTzLayout, - TypeNameToConv: typeNameToConv, - PlaceHolder: &placeHolder{}, - SqlForDesc: `PRAGMA table_info({table_name})`, - TableField: "name", - ColumnField: "name", - CanUseInTransaction: canUseInTransaction, + TypeNameToConv: typeNameToConv, + PlaceHolder: &placeHolder{}, + SqlForDesc: `PRAGMA table_info({table_name})`, + TableField: "name", + ColumnField: "name", + CanUseInTransaction: canUseInTransaction, IsQuerySQL: func(s string) bool { s, _ = misc.CutField(s) return strings.EqualFold(s, "PRAGMA") diff --git a/dialect/sqlserver/main.go b/dialect/sqlserver/main.go index bc51ba7..0a5d4da 100644 --- a/dialect/sqlserver/main.go +++ b/dialect/sqlserver/main.go @@ -42,12 +42,11 @@ var sqlServerSpec = &dialect.Entry{ and o.name = @p1 and c.user_type_id = t.user_type_id order by c.column_id`, - SqlForTab: `select * from sys.tables`, - DisplayDateTimeLayout: dialect.DateTimeTzLayout, - TypeNameToConv: sqlServerTypeNameToConv, - PlaceHolder: &dialect.PlaceHolderName{Prefix: "@", Format: "v"}, - TableField: "name", - ColumnField: "name", + SqlForTab: `select * from sys.tables`, + TypeNameToConv: sqlServerTypeNameToConv, + PlaceHolder: &dialect.PlaceHolderName{Prefix: "@", Format: "v"}, + TableField: "name", + ColumnField: "name", } func init() { From 8326f94d6f25ac3746df2bd54c66975f9ee4e177 Mon Sep 17 00:00:00 2001 From: HAYAMA Kaoru <3752189+hymkor@users.noreply.github.com> Date: Thu, 6 Nov 2025 23:00:05 +0900 Subject: [PATCH 02/15] Replace the function `dialect.Register` to the method `dialect.(*Entry) Register` --- dialect/main.go | 4 ++-- dialect/mysql/main.go | 2 +- dialect/oracle/main.go | 2 +- dialect/postgresql/main.go | 2 +- dialect/sqlite/main.go | 2 +- dialect/sqlserver/main.go | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/dialect/main.go b/dialect/main.go index 61c07d7..abf0464 100644 --- a/dialect/main.go +++ b/dialect/main.go @@ -85,8 +85,8 @@ func ParseAnyDateTime(s string) (time.Time, error) { var registry = map[string]*Entry{} -func Register(name string, setting *Entry) { - registry[strings.ToUpper(name)] = setting +func (e *Entry) Register(name string) { + registry[strings.ToUpper(name)] = e } func Find(name string) (*Entry, bool) { diff --git a/dialect/mysql/main.go b/dialect/mysql/main.go index 883941d..2b10b1d 100644 --- a/dialect/mysql/main.go +++ b/dialect/mysql/main.go @@ -95,5 +95,5 @@ var mySqlSpec = &dialect.Entry{ } func init() { - dialect.Register("MYSQL", mySqlSpec) + mySqlSpec.Register("MYSQL") } diff --git a/dialect/oracle/main.go b/dialect/oracle/main.go index 24bcf91..ee0272f 100644 --- a/dialect/oracle/main.go +++ b/dialect/oracle/main.go @@ -43,5 +43,5 @@ var oracleSpec = &dialect.Entry{ } func init() { - dialect.Register("ORACLE", oracleSpec) + oracleSpec.Register("ORACLE") } diff --git a/dialect/postgresql/main.go b/dialect/postgresql/main.go index 88ecf7f..64f3e9d 100644 --- a/dialect/postgresql/main.go +++ b/dialect/postgresql/main.go @@ -90,5 +90,5 @@ func canUseInTransaction(sql string) bool { } func init() { - dialect.Register("POSTGRES", postgresSpec) + postgresSpec.Register("POSTGRES") } diff --git a/dialect/sqlite/main.go b/dialect/sqlite/main.go index 0ce18c7..30d3a64 100644 --- a/dialect/sqlite/main.go +++ b/dialect/sqlite/main.go @@ -93,5 +93,5 @@ func (ph *placeHolder) Values() (result []any) { } func init() { - dialect.Register("SQLITE3", Entry) + Entry.Register("SQLITE3") } diff --git a/dialect/sqlserver/main.go b/dialect/sqlserver/main.go index 0a5d4da..9eb13f9 100644 --- a/dialect/sqlserver/main.go +++ b/dialect/sqlserver/main.go @@ -50,5 +50,5 @@ var sqlServerSpec = &dialect.Entry{ } func init() { - dialect.Register("SQLSERVER", sqlServerSpec) + sqlServerSpec.Register("SQLSERVER") } From bb5f0201bde8c18907e158b1b9b6e6be868cd5c6 Mon Sep 17 00:00:00 2001 From: HAYAMA Kaoru <3752189+hymkor@users.noreply.github.com> Date: Thu, 6 Nov 2025 23:55:06 +0900 Subject: [PATCH 03/15] Rename `dialect.Entry.TypeNameToConv` to `TypeConverterFor` --- dialect/main.go | 6 +++--- dialect/mysql/main.go | 10 +++++----- dialect/oracle/main.go | 10 +++++----- dialect/postgresql/main.go | 2 +- dialect/sqlite/main.go | 2 +- dialect/sqlserver/main.go | 10 +++++----- 6 files changed, 20 insertions(+), 20 deletions(-) diff --git a/dialect/main.go b/dialect/main.go index abf0464..4355475 100644 --- a/dialect/main.go +++ b/dialect/main.go @@ -29,17 +29,17 @@ type Entry struct { TableField string ColumnField string PlaceHolder PlaceHolder - TypeNameToConv func(string) func(string) (any, error) + TypeConverterFor func(typeName string) func(literal string) (any, error) DSNFilter func(string) (string, error) CanUseInTransaction func(string) bool IsQuerySQL func(string) bool } func (D *Entry) TypeToConv(typeName string) func(string) (any, error) { - if D.TypeNameToConv == nil { + if D.TypeConverterFor == nil { return nil } - return D.TypeNameToConv(typeName) + return D.TypeConverterFor(typeName) } const ( diff --git a/dialect/mysql/main.go b/dialect/mysql/main.go index 2b10b1d..61a11a4 100644 --- a/dialect/mysql/main.go +++ b/dialect/mysql/main.go @@ -87,11 +87,11 @@ var mySqlSpec = &dialect.Entry{ where table_type = 'BASE TABLE' and table_schema not in ('mysql', 'information_schema', 'performance_schema', 'sys')`, - TypeNameToConv: mySQLTypeNameToConv, - PlaceHolder: &dialect.PlaceHolderQuestion{}, - DSNFilter: mySQLDSNFilter, - TableField: "TABLE_NAME", - ColumnField: "NAME", + TypeConverterFor: mySQLTypeNameToConv, + PlaceHolder: &dialect.PlaceHolderQuestion{}, + DSNFilter: mySQLDSNFilter, + TableField: "TABLE_NAME", + ColumnField: "NAME", } func init() { diff --git a/dialect/oracle/main.go b/dialect/oracle/main.go index ee0272f..d97e110 100644 --- a/dialect/oracle/main.go +++ b/dialect/oracle/main.go @@ -35,11 +35,11 @@ var oracleSpec = &dialect.Entry{ from all_tab_columns where table_name = UPPER(:1) order by column_id`, - SqlForTab: `select * from tab where tname not like 'BIN$%'`, - TypeNameToConv: oracleTypeNameToConv, - TableField: "tname", - ColumnField: "name", - PlaceHolder: &dialect.PlaceHolderName{Prefix: ":", Format: "v"}, + SqlForTab: `select * from tab where tname not like 'BIN$%'`, + TypeConverterFor: oracleTypeNameToConv, + TableField: "tname", + ColumnField: "name", + PlaceHolder: &dialect.PlaceHolderName{Prefix: ":", Format: "v"}, } func init() { diff --git a/dialect/postgresql/main.go b/dialect/postgresql/main.go index 64f3e9d..771dd6d 100644 --- a/dialect/postgresql/main.go +++ b/dialect/postgresql/main.go @@ -68,7 +68,7 @@ var postgresSpec = &dialect.Entry{ from information_schema.tables where table_type = 'BASE TABLE' and table_schema not in ('pg_catalog', 'information_schema')`, - TypeNameToConv: postgresTypeNameToConv, + TypeConverterFor: postgresTypeNameToConv, PlaceHolder: &placeHolder{}, TableField: "table_name", ColumnField: "name", diff --git a/dialect/sqlite/main.go b/dialect/sqlite/main.go index 30d3a64..822958b 100644 --- a/dialect/sqlite/main.go +++ b/dialect/sqlite/main.go @@ -21,7 +21,7 @@ var Entry = &dialect.Entry{ union all select 'temp_schema' AS schema,name,rootpage,sql FROM sqlite_temp_schema where type = 'temp_schema'`, - TypeNameToConv: typeNameToConv, + TypeConverterFor: typeNameToConv, PlaceHolder: &placeHolder{}, SqlForDesc: `PRAGMA table_info({table_name})`, TableField: "name", diff --git a/dialect/sqlserver/main.go b/dialect/sqlserver/main.go index 9eb13f9..d9b4c42 100644 --- a/dialect/sqlserver/main.go +++ b/dialect/sqlserver/main.go @@ -42,11 +42,11 @@ var sqlServerSpec = &dialect.Entry{ and o.name = @p1 and c.user_type_id = t.user_type_id order by c.column_id`, - SqlForTab: `select * from sys.tables`, - TypeNameToConv: sqlServerTypeNameToConv, - PlaceHolder: &dialect.PlaceHolderName{Prefix: "@", Format: "v"}, - TableField: "name", - ColumnField: "name", + SqlForTab: `select * from sys.tables`, + TypeConverterFor: sqlServerTypeNameToConv, + PlaceHolder: &dialect.PlaceHolderName{Prefix: "@", Format: "v"}, + TableField: "name", + ColumnField: "name", } func init() { From a788bdfa1156c342bd6399d6e6288ae9979a9405 Mon Sep 17 00:00:00 2001 From: HAYAMA Kaoru <3752189+hymkor@users.noreply.github.com> Date: Fri, 7 Nov 2025 00:00:34 +0900 Subject: [PATCH 04/15] Rename `dialect.Entry.TypeToConv` to `LookupConverter` --- dialect/main.go | 2 +- spread/edit.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dialect/main.go b/dialect/main.go index 4355475..9e0f090 100644 --- a/dialect/main.go +++ b/dialect/main.go @@ -35,7 +35,7 @@ type Entry struct { IsQuerySQL func(string) bool } -func (D *Entry) TypeToConv(typeName string) func(string) (any, error) { +func (D *Entry) LookupConverter(typeName string) func(string) (any, error) { if D.TypeConverterFor == nil { return nil } diff --git a/spread/edit.go b/spread/edit.go index 1e6b1d6..d60e244 100644 --- a/spread/edit.go +++ b/spread/edit.go @@ -126,7 +126,7 @@ func (editor *Editor) Edit(ctx context.Context, tableAndWhere string, termOut io name := strings.ToUpper(ct.DatabaseTypeName()) var v func(string) (string, error) _ct := ct - if conv := editor.TypeToConv(name); conv != nil { + if conv := editor.LookupConverter(name); conv != nil { quoteFunc = append(quoteFunc, conv) v = func(s string) (string, error) { if s == editor.Null || s == "" { From 2c9a11a4f30da214451ffb04e9d04eaaeb21c9d7 Mon Sep 17 00:00:00 2001 From: HAYAMA Kaoru <3752189+hymkor@users.noreply.github.com> Date: Fri, 7 Nov 2025 00:11:45 +0900 Subject: [PATCH 05/15] Rename `dialect.Entry.SqlForDesc` to SQLForColumns` --- commands.go | 2 +- dialect/main.go | 2 +- dialect/mysql/main.go | 2 +- dialect/oracle/main.go | 2 +- dialect/postgresql/main.go | 2 +- dialect/query.go | 2 +- dialect/sqlite/main.go | 2 +- dialect/sqlserver/main.go | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/commands.go b/commands.go index ce57a58..b6b46ad 100644 --- a/commands.go +++ b/commands.go @@ -155,7 +155,7 @@ func doDescTables(ctx context.Context, ss *session, commandIn commandIn) error { } func doDescColumns(ctx context.Context, ss *session, table string) error { - if ss.Dialect.SqlForDesc == "" { + if ss.Dialect.SQLForColumns == "" { return fmt.Errorf("desc table: %w", ErrNotSupported) } query := ss.Dialect.SqlToQueryColumns(table) diff --git a/dialect/main.go b/dialect/main.go index 9e0f090..a045533 100644 --- a/dialect/main.go +++ b/dialect/main.go @@ -24,7 +24,7 @@ type PlaceHolder interface { type Entry struct { Usage string - SqlForDesc string + SQLForColumns string SqlForTab string TableField string ColumnField string diff --git a/dialect/mysql/main.go b/dialect/mysql/main.go index 61a11a4..29fdd59 100644 --- a/dialect/mysql/main.go +++ b/dialect/mysql/main.go @@ -65,7 +65,7 @@ func mySQLDSNFilter(dsn string) (string, error) { var mySqlSpec = &dialect.Entry{ Usage: `sqlbless mysql :@/`, - SqlForDesc: ` + SQLForColumns: ` select ordinal_position as "ID", column_name as "NAME", case diff --git a/dialect/oracle/main.go b/dialect/oracle/main.go index d97e110..c976e9c 100644 --- a/dialect/oracle/main.go +++ b/dialect/oracle/main.go @@ -19,7 +19,7 @@ func oracleTypeNameToConv(typeName string) func(string) (any, error) { var oracleSpec = &dialect.Entry{ Usage: "sqlbless oracle://:@:/", - SqlForDesc: ` + SQLForColumns: ` select column_id as "ID", column_name as "NAME", case diff --git a/dialect/postgresql/main.go b/dialect/postgresql/main.go index 771dd6d..aa7363b 100644 --- a/dialect/postgresql/main.go +++ b/dialect/postgresql/main.go @@ -44,7 +44,7 @@ func (ph *placeHolder) Values() (result []any) { var postgresSpec = &dialect.Entry{ Usage: "sqlbless postgres://:@:/?sslmode=disable", - SqlForDesc: ` + SQLForColumns: ` select a.attnum as "ID", a.attname as "NAME", case diff --git a/dialect/query.go b/dialect/query.go index 47d681d..c02030b 100644 --- a/dialect/query.go +++ b/dialect/query.go @@ -71,7 +71,7 @@ func (e *Entry) SqlToQueryTables() string { } func (e *Entry) SqlToQueryColumns(table string) string { - return strings.ReplaceAll(e.SqlForDesc, "{table_name}", table) + return strings.ReplaceAll(e.SQLForColumns, "{table_name}", table) } func (e *Entry) Tables(ctx context.Context, conn CanQuery) ([]string, error) { diff --git a/dialect/sqlite/main.go b/dialect/sqlite/main.go index 822958b..6176e55 100644 --- a/dialect/sqlite/main.go +++ b/dialect/sqlite/main.go @@ -23,7 +23,7 @@ var Entry = &dialect.Entry{ where type = 'temp_schema'`, TypeConverterFor: typeNameToConv, PlaceHolder: &placeHolder{}, - SqlForDesc: `PRAGMA table_info({table_name})`, + SQLForColumns: `PRAGMA table_info({table_name})`, TableField: "name", ColumnField: "name", CanUseInTransaction: canUseInTransaction, diff --git a/dialect/sqlserver/main.go b/dialect/sqlserver/main.go index d9b4c42..39147e6 100644 --- a/dialect/sqlserver/main.go +++ b/dialect/sqlserver/main.go @@ -22,7 +22,7 @@ func sqlServerTypeNameToConv(typeName string) func(string) (any, error) { var sqlServerSpec = &dialect.Entry{ Usage: "sqlbless sqlserver://@?database=", - SqlForDesc: ` + SQLForColumns: ` select c.column_id as "ID", c.name as "NAME", case From 167f64da423d5fd9b0aa160dd5d0214c58f24692 Mon Sep 17 00:00:00 2001 From: HAYAMA Kaoru <3752189+hymkor@users.noreply.github.com> Date: Fri, 7 Nov 2025 00:13:51 +0900 Subject: [PATCH 06/15] Rename `dialect.Entry.SqlForTab` to `SQLForTables` --- commands.go | 2 +- dialect/main.go | 2 +- dialect/mysql/main.go | 2 +- dialect/oracle/main.go | 2 +- dialect/postgresql/main.go | 2 +- dialect/query.go | 2 +- dialect/sqlite/main.go | 2 +- dialect/sqlserver/main.go | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/commands.go b/commands.go index b6b46ad..dcbf162 100644 --- a/commands.go +++ b/commands.go @@ -94,7 +94,7 @@ func (ss *session) beginTx(ctx context.Context, w io.Writer) error { } func doDescTables(ctx context.Context, ss *session, commandIn commandIn) error { - if ss.Dialect.SqlForTab == "" { + if ss.Dialect.SQLForTables == "" { return fmt.Errorf("desc: %w", ErrNotSupported) } query := ss.Dialect.SqlToQueryTables() diff --git a/dialect/main.go b/dialect/main.go index a045533..25b5ef1 100644 --- a/dialect/main.go +++ b/dialect/main.go @@ -25,7 +25,7 @@ type PlaceHolder interface { type Entry struct { Usage string SQLForColumns string - SqlForTab string + SQLForTables string TableField string ColumnField string PlaceHolder PlaceHolder diff --git a/dialect/mysql/main.go b/dialect/mysql/main.go index 29fdd59..ba17d9e 100644 --- a/dialect/mysql/main.go +++ b/dialect/mysql/main.go @@ -82,7 +82,7 @@ var mySqlSpec = &dialect.Entry{ from information_schema.columns where table_name = ? order by ordinal_position`, - SqlForTab: ` + SQLForTables: ` select * from information_schema.tables where table_type = 'BASE TABLE' and table_schema diff --git a/dialect/oracle/main.go b/dialect/oracle/main.go index c976e9c..9632469 100644 --- a/dialect/oracle/main.go +++ b/dialect/oracle/main.go @@ -35,7 +35,7 @@ var oracleSpec = &dialect.Entry{ from all_tab_columns where table_name = UPPER(:1) order by column_id`, - SqlForTab: `select * from tab where tname not like 'BIN$%'`, + SQLForTables: `select * from tab where tname not like 'BIN$%'`, TypeConverterFor: oracleTypeNameToConv, TableField: "tname", ColumnField: "name", diff --git a/dialect/postgresql/main.go b/dialect/postgresql/main.go index aa7363b..ef42a6f 100644 --- a/dialect/postgresql/main.go +++ b/dialect/postgresql/main.go @@ -63,7 +63,7 @@ var postgresSpec = &dialect.Entry{ and t.oid = a.atttypid and a.attisdropped is false order by a.attnum`, - SqlForTab: ` + SQLForTables: ` select * from information_schema.tables where table_type = 'BASE TABLE' diff --git a/dialect/query.go b/dialect/query.go index c02030b..923fe2b 100644 --- a/dialect/query.go +++ b/dialect/query.go @@ -67,7 +67,7 @@ func queryOneColumn(ctx context.Context, conn CanQuery, sqlStr, columnName strin } func (e *Entry) SqlToQueryTables() string { - return e.SqlForTab + return e.SQLForTables } func (e *Entry) SqlToQueryColumns(table string) string { diff --git a/dialect/sqlite/main.go b/dialect/sqlite/main.go index 6176e55..8f1cd01 100644 --- a/dialect/sqlite/main.go +++ b/dialect/sqlite/main.go @@ -15,7 +15,7 @@ const dateTimeTzLayout = "2006-01-02 15:04:05.999999999 -07:00" var Entry = &dialect.Entry{ Usage: "sqlbless sqlite3 :memory: OR ", - SqlForTab: ` + SQLForTables: ` select 'master' AS schema,name,rootpage,sql FROM sqlite_master where type = 'table' union all diff --git a/dialect/sqlserver/main.go b/dialect/sqlserver/main.go index 39147e6..692d390 100644 --- a/dialect/sqlserver/main.go +++ b/dialect/sqlserver/main.go @@ -42,7 +42,7 @@ var sqlServerSpec = &dialect.Entry{ and o.name = @p1 and c.user_type_id = t.user_type_id order by c.column_id`, - SqlForTab: `select * from sys.tables`, + SQLForTables: `select * from sys.tables`, TypeConverterFor: sqlServerTypeNameToConv, PlaceHolder: &dialect.PlaceHolderName{Prefix: "@", Format: "v"}, TableField: "name", From c9a070487e5b8872653a06306c818085c2f64d47 Mon Sep 17 00:00:00 2001 From: HAYAMA Kaoru <3752189+hymkor@users.noreply.github.com> Date: Fri, 7 Nov 2025 00:15:57 +0900 Subject: [PATCH 07/15] Rename `dialect.Entry.TableField` to `TableNameField` --- commands.go | 2 +- dialect/main.go | 2 +- dialect/mysql/main.go | 2 +- dialect/oracle/main.go | 2 +- dialect/postgresql/main.go | 2 +- dialect/query.go | 2 +- dialect/sqlite/main.go | 2 +- dialect/sqlserver/main.go | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/commands.go b/commands.go index dcbf162..cb9ed76 100644 --- a/commands.go +++ b/commands.go @@ -106,7 +106,7 @@ func doDescTables(ctx context.Context, ss *session, commandIn commandIn) error { } header := e.Front() for i, c := range header.Cell { - if strings.EqualFold(c.Text(), ss.Dialect.TableField) { + if strings.EqualFold(c.Text(), ss.Dialect.TableNameField) { name = e.CursorRow.Cell[i].Text() return &csvi.CommandResult{Quit: true}, nil } diff --git a/dialect/main.go b/dialect/main.go index 25b5ef1..a4c474d 100644 --- a/dialect/main.go +++ b/dialect/main.go @@ -26,7 +26,7 @@ type Entry struct { Usage string SQLForColumns string SQLForTables string - TableField string + TableNameField string ColumnField string PlaceHolder PlaceHolder TypeConverterFor func(typeName string) func(literal string) (any, error) diff --git a/dialect/mysql/main.go b/dialect/mysql/main.go index ba17d9e..f086efe 100644 --- a/dialect/mysql/main.go +++ b/dialect/mysql/main.go @@ -90,7 +90,7 @@ var mySqlSpec = &dialect.Entry{ TypeConverterFor: mySQLTypeNameToConv, PlaceHolder: &dialect.PlaceHolderQuestion{}, DSNFilter: mySQLDSNFilter, - TableField: "TABLE_NAME", + TableNameField: "TABLE_NAME", ColumnField: "NAME", } diff --git a/dialect/oracle/main.go b/dialect/oracle/main.go index 9632469..1f9d4f6 100644 --- a/dialect/oracle/main.go +++ b/dialect/oracle/main.go @@ -37,7 +37,7 @@ var oracleSpec = &dialect.Entry{ order by column_id`, SQLForTables: `select * from tab where tname not like 'BIN$%'`, TypeConverterFor: oracleTypeNameToConv, - TableField: "tname", + TableNameField: "tname", ColumnField: "name", PlaceHolder: &dialect.PlaceHolderName{Prefix: ":", Format: "v"}, } diff --git a/dialect/postgresql/main.go b/dialect/postgresql/main.go index ef42a6f..2d1d07d 100644 --- a/dialect/postgresql/main.go +++ b/dialect/postgresql/main.go @@ -70,7 +70,7 @@ var postgresSpec = &dialect.Entry{ and table_schema not in ('pg_catalog', 'information_schema')`, TypeConverterFor: postgresTypeNameToConv, PlaceHolder: &placeHolder{}, - TableField: "table_name", + TableNameField: "table_name", ColumnField: "name", CanUseInTransaction: canUseInTransaction, } diff --git a/dialect/query.go b/dialect/query.go index 923fe2b..7a920dc 100644 --- a/dialect/query.go +++ b/dialect/query.go @@ -75,7 +75,7 @@ func (e *Entry) SqlToQueryColumns(table string) string { } func (e *Entry) Tables(ctx context.Context, conn CanQuery) ([]string, error) { - return queryOneColumn(ctx, conn, e.SqlToQueryTables(), e.TableField) + return queryOneColumn(ctx, conn, e.SqlToQueryTables(), e.TableNameField) } func (e *Entry) Columns(ctx context.Context, conn CanQuery, table string) ([]string, error) { diff --git a/dialect/sqlite/main.go b/dialect/sqlite/main.go index 8f1cd01..5995d5b 100644 --- a/dialect/sqlite/main.go +++ b/dialect/sqlite/main.go @@ -24,7 +24,7 @@ var Entry = &dialect.Entry{ TypeConverterFor: typeNameToConv, PlaceHolder: &placeHolder{}, SQLForColumns: `PRAGMA table_info({table_name})`, - TableField: "name", + TableNameField: "name", ColumnField: "name", CanUseInTransaction: canUseInTransaction, IsQuerySQL: func(s string) bool { diff --git a/dialect/sqlserver/main.go b/dialect/sqlserver/main.go index 692d390..137eded 100644 --- a/dialect/sqlserver/main.go +++ b/dialect/sqlserver/main.go @@ -45,7 +45,7 @@ var sqlServerSpec = &dialect.Entry{ SQLForTables: `select * from sys.tables`, TypeConverterFor: sqlServerTypeNameToConv, PlaceHolder: &dialect.PlaceHolderName{Prefix: "@", Format: "v"}, - TableField: "name", + TableNameField: "name", ColumnField: "name", } From ce4d082e26341801fe44111a6e38a64206d57b58 Mon Sep 17 00:00:00 2001 From: HAYAMA Kaoru <3752189+hymkor@users.noreply.github.com> Date: Fri, 7 Nov 2025 00:17:22 +0900 Subject: [PATCH 08/15] Rename `dialect.Entry.ColumnField` to `ColumnNameField` --- dialect/main.go | 2 +- dialect/mysql/main.go | 2 +- dialect/oracle/main.go | 2 +- dialect/postgresql/main.go | 2 +- dialect/query.go | 2 +- dialect/sqlite/main.go | 2 +- dialect/sqlserver/main.go | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/dialect/main.go b/dialect/main.go index a4c474d..0b39f14 100644 --- a/dialect/main.go +++ b/dialect/main.go @@ -27,7 +27,7 @@ type Entry struct { SQLForColumns string SQLForTables string TableNameField string - ColumnField string + ColumnNameField string PlaceHolder PlaceHolder TypeConverterFor func(typeName string) func(literal string) (any, error) DSNFilter func(string) (string, error) diff --git a/dialect/mysql/main.go b/dialect/mysql/main.go index f086efe..3b78331 100644 --- a/dialect/mysql/main.go +++ b/dialect/mysql/main.go @@ -91,7 +91,7 @@ var mySqlSpec = &dialect.Entry{ PlaceHolder: &dialect.PlaceHolderQuestion{}, DSNFilter: mySQLDSNFilter, TableNameField: "TABLE_NAME", - ColumnField: "NAME", + ColumnNameField: "NAME", } func init() { diff --git a/dialect/oracle/main.go b/dialect/oracle/main.go index 1f9d4f6..d779075 100644 --- a/dialect/oracle/main.go +++ b/dialect/oracle/main.go @@ -38,7 +38,7 @@ var oracleSpec = &dialect.Entry{ SQLForTables: `select * from tab where tname not like 'BIN$%'`, TypeConverterFor: oracleTypeNameToConv, TableNameField: "tname", - ColumnField: "name", + ColumnNameField: "name", PlaceHolder: &dialect.PlaceHolderName{Prefix: ":", Format: "v"}, } diff --git a/dialect/postgresql/main.go b/dialect/postgresql/main.go index 2d1d07d..e1d969d 100644 --- a/dialect/postgresql/main.go +++ b/dialect/postgresql/main.go @@ -71,7 +71,7 @@ var postgresSpec = &dialect.Entry{ TypeConverterFor: postgresTypeNameToConv, PlaceHolder: &placeHolder{}, TableNameField: "table_name", - ColumnField: "name", + ColumnNameField: "name", CanUseInTransaction: canUseInTransaction, } diff --git a/dialect/query.go b/dialect/query.go index 7a920dc..ac29a59 100644 --- a/dialect/query.go +++ b/dialect/query.go @@ -79,5 +79,5 @@ func (e *Entry) Tables(ctx context.Context, conn CanQuery) ([]string, error) { } func (e *Entry) Columns(ctx context.Context, conn CanQuery, table string) ([]string, error) { - return queryOneColumn(ctx, conn, e.SqlToQueryColumns(table), e.ColumnField, table) + return queryOneColumn(ctx, conn, e.SqlToQueryColumns(table), e.ColumnNameField, table) } diff --git a/dialect/sqlite/main.go b/dialect/sqlite/main.go index 5995d5b..d41dc79 100644 --- a/dialect/sqlite/main.go +++ b/dialect/sqlite/main.go @@ -25,7 +25,7 @@ var Entry = &dialect.Entry{ PlaceHolder: &placeHolder{}, SQLForColumns: `PRAGMA table_info({table_name})`, TableNameField: "name", - ColumnField: "name", + ColumnNameField: "name", CanUseInTransaction: canUseInTransaction, IsQuerySQL: func(s string) bool { s, _ = misc.CutField(s) diff --git a/dialect/sqlserver/main.go b/dialect/sqlserver/main.go index 137eded..956a384 100644 --- a/dialect/sqlserver/main.go +++ b/dialect/sqlserver/main.go @@ -46,7 +46,7 @@ var sqlServerSpec = &dialect.Entry{ TypeConverterFor: sqlServerTypeNameToConv, PlaceHolder: &dialect.PlaceHolderName{Prefix: "@", Format: "v"}, TableNameField: "name", - ColumnField: "name", + ColumnNameField: "name", } func init() { From 5338d2446c569b6372ab0558d3a9ee1aab77fc48 Mon Sep 17 00:00:00 2001 From: HAYAMA Kaoru <3752189+hymkor@users.noreply.github.com> Date: Fri, 7 Nov 2025 00:20:11 +0900 Subject: [PATCH 09/15] Rename `dialect.Entry.CanUseInTransaction` to `IsTransactionSafe` --- dialect/main.go | 20 ++++++++++---------- dialect/postgresql/main.go | 10 +++++----- dialect/sqlite/main.go | 12 ++++++------ loop.go | 2 +- 4 files changed, 22 insertions(+), 22 deletions(-) diff --git a/dialect/main.go b/dialect/main.go index 0b39f14..6abef75 100644 --- a/dialect/main.go +++ b/dialect/main.go @@ -23,16 +23,16 @@ type PlaceHolder interface { } type Entry struct { - Usage string - SQLForColumns string - SQLForTables string - TableNameField string - ColumnNameField string - PlaceHolder PlaceHolder - TypeConverterFor func(typeName string) func(literal string) (any, error) - DSNFilter func(string) (string, error) - CanUseInTransaction func(string) bool - IsQuerySQL func(string) bool + Usage string + SQLForColumns string + SQLForTables string + TableNameField string + ColumnNameField string + PlaceHolder PlaceHolder + TypeConverterFor func(typeName string) func(literal string) (any, error) + DSNFilter func(string) (string, error) + IsTransactionSafe func(string) bool + IsQuerySQL func(string) bool } func (D *Entry) LookupConverter(typeName string) func(string) (any, error) { diff --git a/dialect/postgresql/main.go b/dialect/postgresql/main.go index e1d969d..ef0de35 100644 --- a/dialect/postgresql/main.go +++ b/dialect/postgresql/main.go @@ -68,11 +68,11 @@ var postgresSpec = &dialect.Entry{ from information_schema.tables where table_type = 'BASE TABLE' and table_schema not in ('pg_catalog', 'information_schema')`, - TypeConverterFor: postgresTypeNameToConv, - PlaceHolder: &placeHolder{}, - TableNameField: "table_name", - ColumnNameField: "name", - CanUseInTransaction: canUseInTransaction, + TypeConverterFor: postgresTypeNameToConv, + PlaceHolder: &placeHolder{}, + TableNameField: "table_name", + ColumnNameField: "name", + IsTransactionSafe: canUseInTransaction, } func canUseInTransaction(sql string) bool { diff --git a/dialect/sqlite/main.go b/dialect/sqlite/main.go index d41dc79..2bf1280 100644 --- a/dialect/sqlite/main.go +++ b/dialect/sqlite/main.go @@ -21,12 +21,12 @@ var Entry = &dialect.Entry{ union all select 'temp_schema' AS schema,name,rootpage,sql FROM sqlite_temp_schema where type = 'temp_schema'`, - TypeConverterFor: typeNameToConv, - PlaceHolder: &placeHolder{}, - SQLForColumns: `PRAGMA table_info({table_name})`, - TableNameField: "name", - ColumnNameField: "name", - CanUseInTransaction: canUseInTransaction, + TypeConverterFor: typeNameToConv, + PlaceHolder: &placeHolder{}, + SQLForColumns: `PRAGMA table_info({table_name})`, + TableNameField: "name", + ColumnNameField: "name", + IsTransactionSafe: canUseInTransaction, IsQuerySQL: func(s string) bool { s, _ = misc.CutField(s) return strings.EqualFold(s, "PRAGMA") diff --git a/loop.go b/loop.go index 54b0ccf..c0a0b08 100644 --- a/loop.go +++ b/loop.go @@ -208,7 +208,7 @@ func (ss *session) Loop(ctx context.Context, commandIn commandIn) error { } else { if ss.tx == nil { _, err = ss.conn.ExecContext(ctx, query) - } else if f := ss.Dialect.CanUseInTransaction; f != nil && f(query) { + } else if f := ss.Dialect.IsTransactionSafe; f != nil && f(query) { _, err = ss.tx.ExecContext(ctx, query) } else { err = ErrTransactionIsNotClosed From 68b4cedbbb48920fbe1cc5022ef0bd83cebd5c8a Mon Sep 17 00:00:00 2001 From: HAYAMA Kaoru <3752189+hymkor@users.noreply.github.com> Date: Fri, 7 Nov 2025 00:33:16 +0900 Subject: [PATCH 10/15] Add comments to the field of `dialect.Entry` --- dialect/main.go | 40 ++++++++++++++++++++++++++++++---------- 1 file changed, 30 insertions(+), 10 deletions(-) diff --git a/dialect/main.go b/dialect/main.go index 6abef75..fe2ba05 100644 --- a/dialect/main.go +++ b/dialect/main.go @@ -23,16 +23,36 @@ type PlaceHolder interface { } type Entry struct { - Usage string - SQLForColumns string - SQLForTables string - TableNameField string - ColumnNameField string - PlaceHolder PlaceHolder - TypeConverterFor func(typeName string) func(literal string) (any, error) - DSNFilter func(string) (string, error) - IsTransactionSafe func(string) bool - IsQuerySQL func(string) bool + // Usage describes how to use this entry or what it represents. + Usage string + + // SQLForColumns is the SQL query used to retrieve column information. + SQLForColumns string + + // SQLForTables is the SQL query used to retrieve table information. + SQLForTables string + + // TableNameField is the field name for table names in SQL results. + TableNameField string + + // ColumnNameField is the field name for column names in SQL results. + ColumnNameField string + + // PlaceHolder defines how to represent placeholders (e.g., ?, $1) in SQL. + PlaceHolder PlaceHolder + + // TypeConverterFor returns a converter function for a given type name. + // The returned function converts a string literal to the corresponding Go value. + TypeConverterFor func(typeName string) func(literal string) (any, error) + + // DSNFilter adjusts or validates a given DSN string before use. + DSNFilter func(dsn string) (string, error) + + // IsTransactionSafe reports whether the given SQL statement is safe to run in a transaction. + IsTransactionSafe func(sql string) bool + + // IsQuerySQL reports whether the given SQL statement is a query (e.g., SELECT) or not. + IsQuerySQL func(sql string) bool } func (D *Entry) LookupConverter(typeName string) func(string) (any, error) { From ec51f779952e17103e592a79ca66e137ea774086 Mon Sep 17 00:00:00 2001 From: HAYAMA Kaoru <3752189+hymkor@users.noreply.github.com> Date: Fri, 7 Nov 2025 02:27:36 +0900 Subject: [PATCH 11/15] Rename `dialect.SqlToQueryColumns` to `BuildSQLForColumns` --- commands.go | 2 +- dialect/query.go | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/commands.go b/commands.go index cb9ed76..2c44cdf 100644 --- a/commands.go +++ b/commands.go @@ -158,7 +158,7 @@ func doDescColumns(ctx context.Context, ss *session, table string) error { if ss.Dialect.SQLForColumns == "" { return fmt.Errorf("desc table: %w", ErrNotSupported) } - query := ss.Dialect.SqlToQueryColumns(table) + query := ss.Dialect.BuildSQLForColumns(table) if ss.Debug { fmt.Println(query) } diff --git a/dialect/query.go b/dialect/query.go index ac29a59..e43a53d 100644 --- a/dialect/query.go +++ b/dialect/query.go @@ -70,7 +70,9 @@ func (e *Entry) SqlToQueryTables() string { return e.SQLForTables } -func (e *Entry) SqlToQueryColumns(table string) string { +// BuildSQLForColumns returns the SQL statement used to retrieve the list of columns +// for the given table name. The placeholder "{table_name}" in the template will be replaced. +func (e *Entry) BuildSQLForColumns(table string) string { return strings.ReplaceAll(e.SQLForColumns, "{table_name}", table) } @@ -79,5 +81,5 @@ func (e *Entry) Tables(ctx context.Context, conn CanQuery) ([]string, error) { } func (e *Entry) Columns(ctx context.Context, conn CanQuery, table string) ([]string, error) { - return queryOneColumn(ctx, conn, e.SqlToQueryColumns(table), e.ColumnNameField, table) + return queryOneColumn(ctx, conn, e.BuildSQLForColumns(table), e.ColumnNameField, table) } From ceccaeb79aaaf75fb63249ebfde4178e3add8228 Mon Sep 17 00:00:00 2001 From: HAYAMA Kaoru <3752189+hymkor@users.noreply.github.com> Date: Fri, 7 Nov 2025 02:32:55 +0900 Subject: [PATCH 12/15] Rename `dialect.SqlToQueryTables` to `BuildSQLForTables` --- commands.go | 2 +- dialect/query.go | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/commands.go b/commands.go index 2c44cdf..759151c 100644 --- a/commands.go +++ b/commands.go @@ -97,7 +97,7 @@ func doDescTables(ctx context.Context, ss *session, commandIn commandIn) error { if ss.Dialect.SQLForTables == "" { return fmt.Errorf("desc: %w", ErrNotSupported) } - query := ss.Dialect.SqlToQueryTables() + query := ss.Dialect.BuildSQLForTables() var name string handler := func(e *csvi.KeyEventArgs) (*csvi.CommandResult, error) { diff --git a/dialect/query.go b/dialect/query.go index e43a53d..5286e31 100644 --- a/dialect/query.go +++ b/dialect/query.go @@ -66,7 +66,8 @@ func queryOneColumn(ctx context.Context, conn CanQuery, sqlStr, columnName strin } } -func (e *Entry) SqlToQueryTables() string { +// BuildSQLForTables returns the SQL statement used to retrieve the list of tables. +func (e *Entry) BuildSQLForTables() string { return e.SQLForTables } @@ -77,7 +78,7 @@ func (e *Entry) BuildSQLForColumns(table string) string { } func (e *Entry) Tables(ctx context.Context, conn CanQuery) ([]string, error) { - return queryOneColumn(ctx, conn, e.SqlToQueryTables(), e.TableNameField) + return queryOneColumn(ctx, conn, e.BuildSQLForTables(), e.TableNameField) } func (e *Entry) Columns(ctx context.Context, conn CanQuery, table string) ([]string, error) { From 3c92996b435ddf72aa6df6285166d2f6af0edabe Mon Sep 17 00:00:00 2001 From: HAYAMA Kaoru <3752189+hymkor@users.noreply.github.com> Date: Fri, 7 Nov 2025 02:39:13 +0900 Subject: [PATCH 13/15] Rename `dialect.Entry.Tables` to `FetchTables` --- dialect/query.go | 4 +++- edit.go | 2 +- internal/sqlcompletion/main.go | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/dialect/query.go b/dialect/query.go index 5286e31..ff8387c 100644 --- a/dialect/query.go +++ b/dialect/query.go @@ -77,7 +77,9 @@ func (e *Entry) BuildSQLForColumns(table string) string { return strings.ReplaceAll(e.SQLForColumns, "{table_name}", table) } -func (e *Entry) Tables(ctx context.Context, conn CanQuery) ([]string, error) { +// Tables executes the SQL to list all table names defined by the dialect. +// It returns a slice of table names or an error if the query fails. +func (e *Entry) FetchTables(ctx context.Context, conn CanQuery) ([]string, error) { return queryOneColumn(ctx, conn, e.BuildSQLForTables(), e.TableNameField) } diff --git a/edit.go b/edit.go index aa88acc..26dd3b2 100644 --- a/edit.go +++ b/edit.go @@ -97,7 +97,7 @@ func doEdit(ctx context.Context, ss *session, command string, pilot commandIn) e // replace `edit ` to `select * from ` _, tableAndWhere := misc.CutField(command) if tableAndWhere == "" { - tables, err := ss.Dialect.Tables(ctx, ss.conn) + tables, err := ss.Dialect.FetchTables(ctx, ss.conn) if err != nil { return err } diff --git a/internal/sqlcompletion/main.go b/internal/sqlcompletion/main.go index 2498f57..a496fda 100644 --- a/internal/sqlcompletion/main.go +++ b/internal/sqlcompletion/main.go @@ -123,7 +123,7 @@ func (C *completeType) getCandidates(ctx context.Context, fields []string) ([]st func (C *completeType) tables(ctx context.Context) []string { if len(C.tableCache) <= 0 { - C.tableCache, _ = C.Dialect.Tables(ctx, C.Conn) + C.tableCache, _ = C.Dialect.FetchTables(ctx, C.Conn) } return C.tableCache } From 9a664521133d027dc87f888ba0d6831b977ccfba Mon Sep 17 00:00:00 2001 From: HAYAMA Kaoru <3752189+hymkor@users.noreply.github.com> Date: Fri, 7 Nov 2025 02:40:40 +0900 Subject: [PATCH 14/15] Rename `dialect.Entry.Columns` to `FetchColumns` --- dialect/query.go | 4 +++- internal/sqlcompletion/main.go | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/dialect/query.go b/dialect/query.go index ff8387c..86c73fa 100644 --- a/dialect/query.go +++ b/dialect/query.go @@ -83,6 +83,8 @@ func (e *Entry) FetchTables(ctx context.Context, conn CanQuery) ([]string, error return queryOneColumn(ctx, conn, e.BuildSQLForTables(), e.TableNameField) } -func (e *Entry) Columns(ctx context.Context, conn CanQuery, table string) ([]string, error) { +// Columns executes the SQL to list column names for the specified table. +// It returns a slice of column names or an error if the query fails. +func (e *Entry) FetchColumns(ctx context.Context, conn CanQuery, table string) ([]string, error) { return queryOneColumn(ctx, conn, e.BuildSQLForColumns(table), e.ColumnNameField, table) } diff --git a/internal/sqlcompletion/main.go b/internal/sqlcompletion/main.go index a496fda..26f31f3 100644 --- a/internal/sqlcompletion/main.go +++ b/internal/sqlcompletion/main.go @@ -138,7 +138,7 @@ func (C *completeType) columns(ctx context.Context, tables []string) (result []s } values, ok := C.columnCache[tableName] if !ok { - values, _ = C.Dialect.Columns(ctx, C.Conn, tableName) + values, _ = C.Dialect.FetchColumns(ctx, C.Conn, tableName) C.columnCache[tableName] = values } result = append(result, values...) From cfe041e0615a8126fe0cc5633a84ae2f16005460 Mon Sep 17 00:00:00 2001 From: HAYAMA Kaoru <3752189+hymkor@users.noreply.github.com> Date: Fri, 7 Nov 2025 03:19:25 +0900 Subject: [PATCH 15/15] Release notes: mentioned: Refactor `dialect` subpackage: rename fields and methods for clarity (#8) --- release_note_en.md | 2 ++ release_note_ja.md | 2 ++ 2 files changed, 4 insertions(+) diff --git a/release_note_en.md b/release_note_en.md index 76a07f1..034996c 100644 --- a/release_note_en.md +++ b/release_note_en.md @@ -1,5 +1,7 @@ ( **English** / [Japanese](release_note_ja.md) ) +- Refactor `dialect` subpackage: rename fields and methods for clarity (#8) + v0.25.0 ======= Nov 3, 2025 diff --git a/release_note_ja.md b/release_note_ja.md index 1e659e2..00ca202 100644 --- a/release_note_ja.md +++ b/release_note_ja.md @@ -1,5 +1,7 @@ ( [English](release_note_en.md) / **Japanese** ) +- サブパッケージ `dialect` をリファクタリング: フィールド・メソッドを改名 (#8) + v0.25.0 ======= Nov 3, 2025