fix(ios): use subspec for conditional OnsideKit dependency

- Add ExpoIap/Onside subspec with default_subspecs = [] so OnsideKit
  is only included when explicitly enabled
- Rename ensureOnsidePod to ensureOnsidePodIOS per naming convention
- Keep call site conditional: only called when enableOnside is true
- Add ensureOnsidePodIOS tests covering onside true/false scenarios

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: hyochan

ios/ExpoIap.podspec

@@ -30,12 +30,13 @@ Pod::Spec.new do |s|
     ss.dependency 'OnsideKit'
   end
 
+  s.default_subspecs = []
+
   # Swift/Objective-C compatibility
   s.pod_target_xcconfig = {
     'DEFINES_MODULE' => 'YES',
     'SWIFT_COMPILATION_MODE' => 'wholemodule'
   }
 
   s.source_files = "**/*.{h,m,swift}"
-  s.default_subspecs = []
 end

plugin/__tests__/withIAP.test.ts

@@ -1,6 +1,7 @@
 import type {ExpoConfig} from '@expo/config-types';
 import {
   computeAutolinkModules,
+  ensureOnsidePodIOS,
   modifyAppBuildGradle,
   resolveModuleSelection,
 } from '../src/withIAP';
@@ -28,7 +29,7 @@ jest.mock('expo/config-plugins', () => {
 
   return {
     ...plugins,
-    WarningAggregator: {addWarningAndroid: jest.fn()},
+    WarningAggregator: {addWarningAndroid: jest.fn(), addWarningIOS: jest.fn()},
   };
 });
 
@@ -183,3 +184,95 @@ describe('ios module selection', () => {
     });
   });
 });
+
+describe('ensureOnsidePodIOS', () => {
+  const basePodfile = [
+    "source 'https://cdn.cocoapods.org/'",
+    '',
+    "target 'MyApp' do",
+    "  pod 'ExpoModulesCore'",
+    'end',
+    '',
+  ].join('\n');
+
+  it('adds both OnsideKit and ExpoIap/Onside pods', () => {
+    const result = ensureOnsidePodIOS(basePodfile);
+    expect(result).toContain("pod 'OnsideKit'");
+    expect(result).toContain("pod 'ExpoIap/Onside'");
+  });
+
+  it('inserts pods inside the target block', () => {
+    const result = ensureOnsidePodIOS(basePodfile);
+    const targetIndex = result.indexOf("target 'MyApp' do");
+    const onsideKitIndex = result.indexOf("pod 'OnsideKit'");
+    const endIndex = result.indexOf('end');
+    expect(onsideKitIndex).toBeGreaterThan(targetIndex);
+    expect(onsideKitIndex).toBeLessThan(endIndex);
+  });
+
+  it('skips if both pods already exist', () => {
+    const podfileWithBoth = [
+      "target 'MyApp' do",
+      "  pod 'OnsideKit', :podspec => 'https://example.com'",
+      "  pod 'ExpoIap/Onside', :path => '../node_modules/expo-iap/ios'",
+      'end',
+    ].join('\n');
+    const result = ensureOnsidePodIOS(podfileWithBoth);
+    expect(result).toBe(podfileWithBoth);
+  });
+
+  it('adds missing ExpoIap/Onside when OnsideKit already exists', () => {
+    const podfileWithOnsideKit = [
+      "target 'MyApp' do",
+      "  pod 'OnsideKit', :podspec => 'https://example.com'",
+      'end',
+    ].join('\n');
+    const result = ensureOnsidePodIOS(podfileWithOnsideKit);
+    expect(result).toContain("pod 'ExpoIap/Onside'");
+    expect(result).not.toContain('raw.githubusercontent');
+  });
+
+  it('adds missing OnsideKit when ExpoIap/Onside already exists', () => {
+    const podfileWithSubspec = [
+      "target 'MyApp' do",
+      "  pod 'ExpoIap/Onside', :path => '../node_modules/expo-iap/ios'",
+      'end',
+    ].join('\n');
+    const result = ensureOnsidePodIOS(podfileWithSubspec);
+    expect(result).toContain("pod 'OnsideKit'");
+    const subspecCount = (result.match(/pod 'ExpoIap\/Onside'/g) ?? []).length;
+    expect(subspecCount).toBe(1);
+  });
+
+  it('returns unchanged content when no target block found', () => {
+    const noPodfile = '# empty';
+    const result = ensureOnsidePodIOS(noPodfile);
+    expect(result).toBe(noPodfile);
+  });
+
+  it('does not modify Podfile when onside is disabled (not called)', () => {
+    const enableOnside = false;
+    let content = basePodfile;
+
+    if (enableOnside) {
+      content = ensureOnsidePodIOS(content);
+    }
+
+    expect(content).toBe(basePodfile);
+    expect(content).not.toContain("pod 'OnsideKit'");
+    expect(content).not.toContain("pod 'ExpoIap/Onside'");
+  });
+
+  it('modifies Podfile when onside is enabled', () => {
+    const enableOnside = true;
+    let content = basePodfile;
+
+    if (enableOnside) {
+      content = ensureOnsidePodIOS(content);
+    }
+
+    expect(content).not.toBe(basePodfile);
+    expect(content).toContain("pod 'OnsideKit'");
+    expect(content).toContain("pod 'ExpoIap/Onside'");
+  });
+});

plugin/src/withIAP.ts

@@ -7,7 +7,6 @@ import {
   withGradleProperties,
   withInfoPlist,
   withPodfile,
-  withAppDelegate,
 } from 'expo/config-plugins';
 import type {ExpoConfig} from '@expo/config-types';
 import * as fs from 'fs';
@@ -268,21 +267,13 @@ const ONSIDEKIT_PODSPEC_URL =
 
 const EXPO_IAP_IOS_PATH = '../node_modules/expo-iap/ios';
 
-const ensureOnsidePod = (content: string, onside: boolean): string => {
-  const alreadyHasOnsideKit = /^\s*pod\s+['"]OnsideKit['"]\b.*$/m.test(content);
+export const ensureOnsidePodIOS = (content: string): string => {
+  const alreadyHasOnsideKit = /^\s*pod\s+['"]OnsideKit['"].*$/m.test(content);
   const alreadyHasExpoIapOnside = /^\s*pod\s+['"]ExpoIap\/Onside['"].*$/m.test(
     content,
   );
 
-  let podLines = '';
-  if (!alreadyHasOnsideKit) {
-    podLines += `  pod 'OnsideKit', :podspec => '${ONSIDEKIT_PODSPEC_URL}'\n`;
-  }
-  if (onside && !alreadyHasExpoIapOnside) {
-    podLines += `  pod 'ExpoIap/Onside', :path => '${EXPO_IAP_IOS_PATH}'`;
-  }
-
-  if (!podLines) {
+  if (alreadyHasOnsideKit && alreadyHasExpoIapOnside) {
     return content;
   }
 
@@ -295,19 +286,21 @@ const ensureOnsidePod = (content: string, onside: boolean): string => {
     return content;
   }
 
+  let podLines = '';
+  if (!alreadyHasOnsideKit) {
+    podLines += `  pod 'OnsideKit', :podspec => '${ONSIDEKIT_PODSPEC_URL}'\n`;
+  }
+  if (!alreadyHasExpoIapOnside) {
+    podLines += `  pod 'ExpoIap/Onside', :path => '${EXPO_IAP_IOS_PATH}'\n`;
+  }
+
   const insertIndex = targetMatch.index! + targetMatch[0].length;
   const before = content.slice(0, insertIndex);
   const after = content.slice(insertIndex);
 
-  if (onside && !alreadyHasExpoIapOnside) {
-    logOnce(
-      '📦 expo-iap: Added ExpoIap/Onside subspec (and OnsideKit for resolution) to Podfile',
-    );
-  } else if (!alreadyHasOnsideKit) {
-    logOnce('📦 expo-iap: Added OnsideKit to Podfile');
-  }
+  logOnce('📦 expo-iap: Added ExpoIap/Onside subspec to Podfile');
 
-  return `${before}${podLines}\n${after}`;
+  return `${before}${podLines}${after}`;
 };
 
 export type AutolinkState = {expoIap: boolean; onside: boolean};
@@ -511,8 +504,10 @@ const withIapIOS: ConfigPlugin<WithIapIosOptions | undefined> = (
       logOnce('🧹 expo-iap: Removed local OpenIAP pod from Podfile');
     }
 
-    // 3) Always add OnsideKit; add ExpoIap/Onside only when onside is enabled
-    content = ensureOnsidePod(content, options?.enableOnside ?? false);
+    // 3) Optionally install OnsideKit when enabled in config
+    if (options?.enableOnside) {
+      content = ensureOnsidePodIOS(content);
+    }
 
     config.modResults.contents = content;
     return config;