fix: code review

Author: hyochan

CLAUDE.md

@@ -56,7 +56,7 @@ className="border-border-light dark:border-border-dark"
 
 #### Brand/Accent Colors
 ```tsx
-// Primary brand color (blue)
+// Primary brand color (blue) - use for primary actions and highlights
 className="bg-brand"  // #4190EB
 
 // Primary buttons

app/[lang]/(common)/Header/index.tsx

@@ -21,6 +21,16 @@ import Button from '../Button';
 import SwitchToggle from './SwitchToggle';
 
 const inter = Inter({subsets: ['latin']});
+const normalizePath = (path: string): string => path.replace(/\/+$/, '');
+const isActivePath = (
+  pathname: string | null,
+  lang: string,
+  path: string,
+): boolean => {
+  const target = normalizePath(`/${lang}${path}`);
+  const current = normalizePath(pathname ?? '');
+  return current === target || current.startsWith(`${target}/`);
+};
 
 export type NavLink = {
   name: string;
@@ -46,13 +56,6 @@ function DesktopNavMenus(
   const router = useRouter();
   const supabase = getSupabaseBrowserClient();
 
-  const normalizePath = (path: string): string => path.replace(/\/+$/, '');
-  const isActivePath = (path: string): boolean => {
-    const target = normalizePath(`/${lang}${path}`);
-    const current = normalizePath(pathname ?? '');
-    return current === target || current.startsWith(`${target}/`);
-  };
-
   return (
     <div
       className={clsx('flex-1 justify-between items-center', 'max-md:hidden')}
@@ -71,7 +74,9 @@ function DesktopNavMenus(
                 href={`${link.path}`}
                 className={clsx(
                   'text-body4 truncate',
-                  isActivePath(link.path) ? 'opacity-100' : 'opacity-30',
+                  isActivePath(pathname, lang, link.path)
+                    ? 'opacity-100'
+                    : 'opacity-30',
                 )}
               >
                 <li
@@ -137,13 +142,6 @@ function MobileNavMenus(
 
   const [isNavCollapsed, setIsNavCollapsed] = useState(true);
 
-  const normalizePath = (path: string): string => path.replace(/\/+$/, '');
-  const isActivePath = (path: string): boolean => {
-    const target = normalizePath(`/${lang}${path}`);
-    const current = normalizePath(pathname ?? '');
-    return current === target || current.startsWith(`${target}/`);
-  };
-
   return (
     <div className={clsx('md:hidden flex-1', 'flex flex-row-reverse')}>
       <div className="cursor-pointer">
@@ -183,7 +181,9 @@ function MobileNavMenus(
                   'text-body4 truncate flex-1 h-10 px-8',
                   'flex items-center',
                   'hover:opacity-100',
-                  isActivePath(link.path) ? 'opacity-100' : 'opacity-30',
+                  isActivePath(pathname, lang, link.path)
+                    ? 'opacity-100'
+                    : 'opacity-30',
                 )}
               >
                 <li
@@ -261,7 +261,7 @@ export default function Header(props: Props): ReactElement {
           path: `/stats/${login}`,
         },
         {
-          name: t.recentList,
+          name: t.leaderboards,
           path: '/leaderboards',
         },
       ]
@@ -271,7 +271,7 @@ export default function Header(props: Props): ReactElement {
           path: `/stats`,
         },
         {
-          name: t.recentList,
+          name: t.leaderboards,
           path: '/leaderboards',
         },
       ];

app/[lang]/leaderboards/GithubUserList.tsx

@@ -32,7 +32,7 @@ const TIER_ORDER: Tier[] = [
 ];
 
 type Props = {
-  t: Translates['recentList'];
+  t: Translates['leaderboards'];
   initialData: UserListItem[];
 };
 
@@ -142,10 +142,14 @@ export default function GithubUserList({t, initialData}: Props): ReactElement {
         cursor,
       });
 
-      const filteredUsers = users.filter((el) => !data.includes(el));
+      const filteredUsers = users.filter(
+        (el) => !data.some((existing) => existing.login === el.login),
+      );
 
-      setData([...data, ...filteredUsers]);
-      setCursor(new Date(filteredUsers?.[filteredUsers.length - 1]?.createdAt));
+      if (filteredUsers.length > 0) {
+        setData([...data, ...filteredUsers]);
+        setCursor(new Date(filteredUsers[filteredUsers.length - 1].createdAt));
+      }
     }
   };
 

app/[lang]/leaderboards/TopTierUsers.tsx

@@ -24,6 +24,9 @@ export default function TopTierUsers({title}: Props): ReactElement {
     const fetchTopUsers = async () => {
       try {
         const response = await fetch(API_TOP_TIER_USERS);
+        if (!response.ok) {
+          throw new Error(`HTTP error: ${response.status}`);
+        }
         const data = await response.json();
         if (data.users) {
           setTopTierUsers(data.users);
@@ -63,7 +66,7 @@ export default function TopTierUsers({title}: Props): ReactElement {
   }
 
   if (topTierUsers.length === 0) {
-    return <div />;
+    return <></>;
   }
 
   return (

app/[lang]/stats/[login]/Scouter/StatsDetails/SectionDooboo.tsx

@@ -51,7 +51,6 @@ function SectionHeader({t, stats, endDate}: SectionProps): ReactElement {
       } else {
         router.push(pathname);
       }
-      router.refresh();
     },
     [pathname, router],
   );

app/[lang]/stats/[login]/Scouter/StatsDetails/StatsChart.tsx

@@ -82,6 +82,10 @@ export default function StatsChart({
   // Format month for display (YYYY-MM -> MMM)
   const formatMonth = (month: string): string => {
     const [, monthNum] = month.split('-');
+    const monthIndex = parseInt(monthNum, 10) - 1;
+    if (Number.isNaN(monthIndex) || monthIndex < 0 || monthIndex > 11) {
+      return month;
+    }
     const months = [
       'Jan',
       'Feb',
@@ -96,7 +100,7 @@ export default function StatsChart({
       'Nov',
       'Dec',
     ];
-    return months[parseInt(monthNum, 10) - 1];
+    return months[monthIndex];
   };
 
   const chartData = monthlyContributions?.map((item) => ({

app/[lang]/stats/[login]/SearchTextInput.tsx

@@ -50,6 +50,11 @@ export default function SearchTextInput({
   }, [initialValue]);
 
   const navigateTo = (loginValue: string) => {
+    // Avoid toggling loading when navigating to the same user
+    if (loginValue === initialValue) {
+      return;
+    }
+
     pendingLoginRef.current = loginValue;
     setIsLoading(true);
     router.push(`/${lang}/stats/${loginValue}`);

server/services/githubService.ts

@@ -57,7 +57,19 @@ export const getGithubUser = async (
   let date: Date;
   if (startDate) {
     const [year, month] = startDate.split('-').map(Number);
-    date = new Date(Date.UTC(year, month - 1, 1, 12, 0, 0));
+    if (
+      Number.isFinite(year) &&
+      Number.isFinite(month) &&
+      month >= 1 &&
+      month <= 12
+    ) {
+      date = new Date(Date.UTC(year, month - 1, 1, 12, 0, 0));
+    } else {
+      const now = new Date();
+      date = new Date(
+        Date.UTC(now.getUTCFullYear(), now.getUTCMonth() - 12, 1, 12, 0, 0),
+      );
+    }
   } else {
     const now = new Date();
     date = new Date(