fix delete with split update (#15288)

If DELETE operator is generated by SplitUpdate node (SplitUpdate
node is generated for updating the partition keys), we raise an error.

The root cause is SplitUpdate will split the origin tuple to two tuples,
one is for deleting and the other one is for inserting. we can skip
the deleting tuple if we found the tuple is updated concurrently
by another transaction, but it is difficult to skip the inserting
tuple, so it will leads to more tuples after updating.

Author: charliettxx

src/backend/executor/nodeModifyTable.c

@@ -1454,6 +1454,25 @@ ldelete:;
 					ereport(ERROR,
 							(errcode(ERRCODE_T_R_SERIALIZATION_FAILURE),
 							 errmsg("could not serialize access due to concurrent delete")));
+
+				/*
+				 * If DELETE operator is generated by SplitUpdate node (SplitUpdate
+				 * node is generated for updating the partition keys), we raise an error.
+				 *
+				 * The root cause is SplitUpdate will split the origin tuple
+				 * to two tuples, one is for deleting and the other one
+				 * is for inserting. we can skip the deleting tuple if we
+				 * found the tuple is updated concurrently by another
+				 * transaction, but it is difficult to skip the inserting
+				 * tuple, so it will leads to more tuples after updating.
+				 */
+				if (splitUpdate)
+				{
+					ereport(ERROR,
+							(errcode(ERRCODE_IN_FAILED_SQL_TRANSACTION ),
+							 errmsg("could not split update tuple which has been deleted by other transaction")));
+				}
+
 				/* tuple already deleted; nothing to do */
 				return NULL;
 

src/test/isolation2/expected/gdd/concurrent_update.out

@@ -240,6 +240,33 @@ DROP
 DROP
 0q: ... <quitting>
 
+-- test ORCA partition table
+create table test(a int, b int, c int) partition by range(b) (start (1) end (7) every (3));
+CREATE
+insert into test values (1, 1, 1);
+INSERT 1
+1: begin;
+BEGIN
+1: delete from test where b = 1;
+DELETE 1
+-- in session 2, in case of ORCA DML invokes EPQ
+-- the following SQL will hang due to XID lock
+2&: update test set b = 1;  <waiting ...>
+1: end;
+END
+2<:  <... completed>
+UPDATE 0
+
+0: select * from test;
+ a | b | c 
+---+---+---
+(0 rows)
+0: drop table test;
+DROP
+0q: ... <quitting>
+1q: ... <quitting>
+2q: ... <quitting>
+
 -- split update is to implement updating on hash keys,
 -- it deletes the tuple and insert a new tuple in a
 -- new segment, so it is not easy for other transaction

src/test/isolation2/sql/gdd/concurrent_update.sql

@@ -129,6 +129,23 @@ DROP TABLE t_concurrent_update;
 0: drop table tab_update_epq2;
 0q:
 
+-- test ORCA partition table
+create table test(a int, b int, c int) partition by range(b) (start (1) end (7) every (3));
+insert into test values (1, 1, 1);
+1: begin;
+1: delete from test where b = 1;
+-- in session 2, in case of ORCA DML invokes EPQ
+-- the following SQL will hang due to XID lock
+2&: update test set b = 1;
+1: end;
+2<:
+
+0: select * from test;
+0: drop table test;
+0q:
+1q:
+2q:
+
 -- split update is to implement updating on hash keys,
 -- it deletes the tuple and insert a new tuple in a
 -- new segment, so it is not easy for other transaction

src/test/singlenode_isolation2/expected/gdd/concurrent_update.out

@@ -240,6 +240,33 @@ DROP
 DROP
 0q: ... <quitting>
 
+-- test ORCA partition table
+create table test(a int, b int, c int) partition by range(b) (start (1) end (7) every (3));
+CREATE
+insert into test values (1, 1, 1);
+INSERT 1
+1: begin;
+BEGIN
+1: delete from test where b = 1;
+DELETE 1
+-- in session 2, in case of ORCA DML invokes EPQ
+-- the following SQL will hang due to XID lock
+2&: update test set b = 1;  <waiting ...>
+1: end;
+END
+2<:  <... completed>
+ERROR:  could not split update tuple which has been deleted by other transaction  (seg1 127.0.0.1:7003 pid=22726)
+
+0: select * from test;
+ a | b | c 
+---+---+---
+(0 rows)
+0: drop table test;
+DROP
+0q: ... <quitting>
+1q: ... <quitting>
+2q: ... <quitting>
+
 -- split update is to implement updating on hash keys,
 -- it deletes the tuple and insert a new tuple in a
 -- new segment, so it is not easy for other transaction