remove outdated comment

severo · severo · commit 1dd31d54b2e7 · 2026-01-08T22:11:01.000+01:00
diff --git a/src/providers/ScrollModeVirtualProvider.tsx b/src/providers/ScrollModeVirtualProvider.tsx
@@ -39,8 +39,6 @@ export function ScrollModeVirtualProvider({ children, canvasHeight, headerHeight
     throw new Error(`Invalid virtualCanvasHeight: ${virtualCanvasHeight} when clientHeight is ${clientHeight}. virtualCanvasHeight should be greater than clientHeight for virtual scrolling.`)
   }
 
-  // TODO(SL): onViewportChange should be stable. Or use setClientHeight and setScrollTop directly? Still interleaved states...
-  // Currently, it breaks with "Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops"
   const onViewportChange = useCallback(({ clientHeight, scrollTop }: { clientHeight: number, scrollTop: number }) => {
     // TODO(SL): remove this fallback (100px)? It's only for the tests in Node.js, where the elements have zero height
     // instead, it should return without updating the visible rows range, or set it to undefined.

Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,6 @@ export function ScrollModeVirtualProvider({ children, canvasHeight, headerHeight`
`39`	`39`	throw new Error(`Invalid virtualCanvasHeight: ${virtualCanvasHeight} when clientHeight is ${clientHeight}. virtualCanvasHeight should be greater than clientHeight for virtual scrolling.`)
`40`	`40`	`}`
`41`	`41`
`42`		`- // TODO(SL): onViewportChange should be stable. Or use setClientHeight and setScrollTop directly? Still interleaved states...`
`43`		`- // Currently, it breaks with "Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops"`
`44`	`42`	`const onViewportChange = useCallback(({ clientHeight, scrollTop }: { clientHeight: number, scrollTop: number }) => {`
`45`	`43`	`// TODO(SL): remove this fallback (100px)? It's only for the tests in Node.js, where the elements have zero height`
`46`	`44`	`// instead, it should return without updating the visible rows range, or set it to undefined.`