make it clear that the key parameter is encoded

Author: severo

packages/components/src/lib/filesystem.ts

@@ -148,7 +148,7 @@ export class HyperparamFileSystem extends FileSystem {
   }
   getResolveUrl(source: string): string {
     const url = new URL('/api/store/get', this.endpoint)
-    url.searchParams.append('key', encodeURIComponent(source))
+    url.searchParams.append('key', source)
     return url.toString()
   }
   getSourceParts(source: string): SourcePart[] {
@@ -166,7 +166,7 @@ export class HyperparamFileSystem extends FileSystem {
   }
   async _fetchFilesList(prefix: string): Promise<HyperparamFileMetadata[]> {
     const url = new URL('/api/store/list', this.endpoint)
-    url.searchParams.append('prefix', encodeURIComponent(prefix))
+    url.searchParams.append('prefix', prefix)
     const res = await fetch(url)
     if (res.ok) {
       return await res.json() as HyperparamFileMetadata[]

packages/components/test/lib/filesystem.test.ts

@@ -1,4 +1,4 @@
-import { describe, expect, it, test } from 'vitest'
+import { assert, describe, expect, it, test } from 'vitest'
 import { HttpFileSystem, HyperparamFileSystem } from '../../src/lib/filesystem.js'
 
 describe('HyperparamFileSystem', () => {
@@ -29,6 +29,18 @@ describe('HyperparamFileSystem', () => {
   })
 })
 
+describe('HyperparamFileSystem.getResolveUrl', () => {
+  test.for([
+    'test.txt',
+    'folder/subfolder/test.txt',
+  ])('encodes the parameters', (key: string) => {
+    const endpoint = 'http://localhost:3000'
+    const source = new HyperparamFileSystem({ endpoint }).getSource(key)
+    assert(source?.kind === 'file')
+    expect(source.resolveUrl).toBe(endpoint + '/api/store/get?key=' + encodeURIComponent(key))
+  })
+})
+
 describe('HttpFileSystem', () => {
   test.for([
     'http://example.com/test.txt',