Skip to content

Commit 4d40980

Browse files
severosevero
authored
pin versions + add tests (#45)
* fix CI * fix actions * fix missing packages
1 parent ddff97d commit 4d40980

File tree

9 files changed

+113
-31
lines changed

9 files changed

+113
-31
lines changed

‎.github/workflows/ci_apps_hightable_demo.yml‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,13 @@ jobs:
2424
- run: npm i
2525
- run: tsc
2626

27+
test:
28+
runs-on: ubuntu-latest
29+
steps:
30+
- uses: actions/checkout@v4
31+
- run: npm i
32+
- run: npm run coverage
33+
2734
buildcheck:
2835
runs-on: ubuntu-latest
2936
steps:

‎.github/workflows/ci_apps_hyparquet_demo.yml‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,15 @@ jobs:
2828
working-directory: ./packages/utils
2929
- run: tsc
3030

31+
test:
32+
runs-on: ubuntu-latest
33+
steps:
34+
- uses: actions/checkout@v4
35+
- run: npm i
36+
- run: npm run build
37+
working-directory: ./packages/utils
38+
- run: npm run coverage
39+
3140
buildcheck:
3241
runs-on: ubuntu-latest
3342
steps:

‎.gitignore‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ node_modules
33
*.tgz
44
.vscode
55
*.parquet
6-
/coverage/
6+
coverage
77
.DS_Store

‎apps/hightable-demo/LICENSE‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
The MIT License (MIT)
2+
3+
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
4+
5+
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
6+
7+
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

‎apps/hightable-demo/package.json‎

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,30 +2,35 @@
22
"name": "hightable-demo",
33
"private": true,
44
"version": "0.0.0",
5+
"license": "MIT",
56
"type": "module",
67
"scripts": {
8+
"coverage": "vitest run --coverage --coverage.include=src",
79
"dev": "vite",
810
"build": "tsc -b && vite build",
911
"lint": "eslint .",
10-
"preview": "vite preview"
12+
"preview": "vite preview",
13+
"test": "vitest run --dir test"
1114
},
1215
"dependencies": {
1316
"hightable": "0.7.0",
14-
"react": "^18.3.1",
15-
"react-dom": "^18.3.1"
17+
"react": "18.3.1",
18+
"react-dom": "18.3.1"
1619
},
1720
"devDependencies": {
18-
"@eslint/js": "^9.13.0",
19-
"@types/react": "^18.3.12",
20-
"@types/react-dom": "^18.3.1",
21-
"@vitejs/plugin-react": "^4.3.3",
22-
"eslint": "^9.13.0",
23-
"eslint-plugin-react": "^7.37.2",
24-
"eslint-plugin-react-hooks": "^5.0.0",
25-
"eslint-plugin-react-refresh": "^0.4.14",
26-
"globals": "^15.11.0",
27-
"typescript": "~5.6.2",
28-
"typescript-eslint": "^8.11.0",
29-
"vite": "^5.4.10"
21+
"@eslint/js": "9.14.0",
22+
"@types/react": "18.3.12",
23+
"@types/react-dom": "18.3.1",
24+
"@vitejs/plugin-react": "4.3.3",
25+
"@vitest/coverage-v8": "2.1.4",
26+
"eslint": "9.14.0",
27+
"eslint-plugin-react": "7.37.2",
28+
"eslint-plugin-react-hooks": "5.0.0",
29+
"eslint-plugin-react-refresh": "0.4.14",
30+
"globals": "15.11.0",
31+
"typescript": "5.6.3",
32+
"typescript-eslint": "8.13.0",
33+
"vite": "5.4.10",
34+
"vitest": "2.1.4"
3035
}
3136
}

‎apps/hightable-demo/test/package.test.js‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
import { describe, expect, it } from 'vitest'
2+
import packageJson from '../package.json'
3+
4+
describe('package.json', () => {
5+
it('should have the correct name', () => {
6+
expect(packageJson.name).toBe('hightable-demo')
7+
})
8+
it('should have a valid version', () => {
9+
expect(packageJson.version).toMatch(/^\d+\.\d+\.\d+$/)
10+
})
11+
it('should have MIT license', () => {
12+
expect(packageJson.license).toBe('MIT')
13+
})
14+
it('should have precise dependency versions', () => {
15+
const { dependencies, devDependencies } = packageJson
16+
const allDependencies = { ...dependencies, ...devDependencies }
17+
Object.entries(allDependencies).filter(([name]) => !name.startsWith('@hyparam/')).forEach(([, version]) => {
18+
expect(version).toMatch(/^\d+\.\d+\.\d+$/)
19+
})
20+
})
21+
})

‎apps/hyparquet-demo/LICENSE‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
The MIT License (MIT)
2+
3+
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
4+
5+
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
6+
7+
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

‎apps/hyparquet-demo/package.json‎

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,33 +2,38 @@
22
"name": "hyparquet-demo",
33
"private": true,
44
"version": "0.0.0",
5+
"license": "MIT",
56
"type": "module",
67
"scripts": {
8+
"coverage": "vitest run --coverage --coverage.include=src",
79
"dev": "vite",
810
"build": "tsc -b && vite build",
911
"lint": "eslint .",
10-
"preview": "vite preview"
12+
"preview": "vite preview",
13+
"test": "vitest run --dir test"
1114
},
1215
"dependencies": {
1316
"@hyparam/utils": "file:../../packages/utils",
1417
"hyparquet": "1.5.0",
1518
"hyparquet-compressors": "0.1.4",
1619
"hightable": "0.7.0",
17-
"react": "^18.3.1",
18-
"react-dom": "^18.3.1"
20+
"react": "18.3.1",
21+
"react-dom": "18.3.1"
1922
},
2023
"devDependencies": {
21-
"@eslint/js": "^9.13.0",
22-
"@types/react": "^18.3.12",
23-
"@types/react-dom": "^18.3.1",
24-
"@vitejs/plugin-react": "^4.3.3",
25-
"eslint": "^9.13.0",
26-
"eslint-plugin-react": "^7.37.2",
27-
"eslint-plugin-react-hooks": "^5.0.0",
28-
"eslint-plugin-react-refresh": "^0.4.14",
29-
"globals": "^15.11.0",
30-
"typescript": "~5.6.2",
31-
"typescript-eslint": "^8.11.0",
32-
"vite": "^5.4.10"
24+
"@eslint/js": "9.14.0",
25+
"@types/react": "18.3.12",
26+
"@types/react-dom": "18.3.1",
27+
"@vitejs/plugin-react": "4.3.3",
28+
"@vitest/coverage-v8": "2.1.4",
29+
"eslint": "9.14.0",
30+
"eslint-plugin-react": "7.37.2",
31+
"eslint-plugin-react-hooks": "5.0.0",
32+
"eslint-plugin-react-refresh": "0.4.14",
33+
"globals": "15.11.0",
34+
"typescript": "5.6.3",
35+
"typescript-eslint": "8.13.0",
36+
"vite": "5.4.10",
37+
"vitest": "2.1.4"
3338
}
3439
}

‎apps/hyparquet-demo/test/package.test.js‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
import { describe, expect, it } from 'vitest'
2+
import packageJson from '../package.json'
3+
4+
describe('package.json', () => {
5+
it('should have the correct name', () => {
6+
expect(packageJson.name).toBe('hyparquet-demo')
7+
})
8+
it('should have a valid version', () => {
9+
expect(packageJson.version).toMatch(/^\d+\.\d+\.\d+$/)
10+
})
11+
it('should have MIT license', () => {
12+
expect(packageJson.license).toBe('MIT')
13+
})
14+
it('should have precise dependency versions', () => {
15+
const { dependencies, devDependencies } = packageJson
16+
const allDependencies = { ...dependencies, ...devDependencies }
17+
Object.entries(allDependencies).filter(([name]) => !name.startsWith('@hyparam/')).forEach(([, version]) => {
18+
expect(version).toMatch(/^\d+\.\d+\.\d+$/)
19+
})
20+
})
21+
})

0 commit comments

Comments
 (0)