Skip to content

Commit 68fa506

Browse files
authored
Rename FileMetadata.size to FileMetadata.fileSize (#369)
1 parent 7be11bb commit 68fa506

File tree

6 files changed

+10
-9
lines changed

6 files changed

+10
-9
lines changed

src/components/Folder/Folder.test.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ describe('Folder Component', () => {
9090
it('filters files based on search query', async () => {
9191
const mockFiles: FileMetadata[] = [
9292
{ sourceId: 'folder1', name: 'folder1/', kind: 'directory', lastModified: '2023-01-01T00:00:00Z' },
93-
{ sourceId: 'file1.txt', name: 'file1.txt', kind: 'file', size: 8196, lastModified: '2023-01-01T00:00:00Z' },
94-
{ sourceId: 'report.pdf', name: 'report.pdf', kind: 'file', size: 10240, lastModified: '2023-01-02T00:00:00Z' },
93+
{ sourceId: 'file1.txt', name: 'file1.txt', kind: 'file', fileSize: 8196, lastModified: '2023-01-01T00:00:00Z' },
94+
{ sourceId: 'report.pdf', name: 'report.pdf', kind: 'file', fileSize: 10240, lastModified: '2023-01-02T00:00:00Z' },
9595
]
9696
const dirSource: DirSource = {
9797
sourceId: 'test-source',
@@ -128,8 +128,8 @@ describe('Folder Component', () => {
128128
value: location,
129129
})
130130
const mockFiles: FileMetadata[] = [
131-
{ sourceId: 'file1.txt', name: 'file1.txt', kind: 'file', size: 8196, lastModified: '2023-01-01T00:00:00Z' },
132-
{ sourceId: 'file2.txt', name: 'file2.txt', kind: 'file', size: 4096, lastModified: '2023-02-02T00:00:00Z' },
131+
{ sourceId: 'file1.txt', name: 'file1.txt', kind: 'file', fileSize: 8196, lastModified: '2023-01-01T00:00:00Z' },
132+
{ sourceId: 'file2.txt', name: 'file2.txt', kind: 'file', fileSize: 4096, lastModified: '2023-02-02T00:00:00Z' },
133133
]
134134
const dirSource: DirSource = {
135135
sourceId: 'test-source',

src/components/Folder/Folder.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,8 @@ export default function Folder({ source }: FolderProps) {
119119
{file.name}
120120
</span>
121121
{file.kind === 'file' && <>
122-
{file.size !== undefined && <span data-file-size title={file.size.toLocaleString() + ' bytes'}>
123-
{formatFileSize(file.size)}
122+
{file.fileSize !== undefined && <span data-file-size title={file.fileSize.toLocaleString() + ' bytes'}>
123+
{formatFileSize(file.fileSize)}
124124
</span>}
125125
<span data-file-date title={getFileDate(file)}>
126126
{getFileDateShort(file)}

src/lib/sources/httpSource.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ export function getHttpSource(sourceId: string, options?: {requestInit?: Request
116116
}
117117
return {
118118
name,
119+
fileSize: item.size,
119120
lastModified: item.lastModified,
120121
sourceId: itemSourceId,
121122
kind: isDirectory ? 'directory' : 'file',

src/lib/sources/huggingFaceSource.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ async function fetchFilesList(url: DirectoryUrl, options?: { requestInit?: Reque
8888
files.push({
8989
name: getFileName(file.path),
9090
eTag: file.lastCommit?.id,
91-
size: file.size,
91+
fileSize: file.size,
9292
lastModified: file.lastCommit?.date,
9393
sourceId: `${url.origin}/${getFullName(url)}/${file.type === 'file' ? 'blob' : 'tree'}/${url.branch}/${file.path}`.replace(/\/$/, ''),
9494
kind: file.type === 'file' ? 'file' : 'directory', // 'unknown' is considered as a directory

src/lib/sources/hyperparamSource.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ async function listFiles(prefix: string, { endpoint, requestInit }: {endpoint: s
4949
return files.map(file => ({
5050
name: file.key,
5151
eTag: file.eTag,
52-
size: file.fileSize,
52+
fileSize: file.fileSize,
5353
lastModified: file.lastModified,
5454
sourceId: (prefix === '' ? '' : prefix + '/') + file.key,
5555
kind: getKind(file.key),

src/lib/sources/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ export type FileKind = 'file' | 'directory'
33
export interface FileMetadata {
44
name: string
55
eTag?: string
6-
size?: number
6+
fileSize?: number
77
lastModified?: string
88
sourceId: string /// the source URL or path
99
kind: FileKind

0 commit comments

Comments
 (0)