Skip to content

Commit 8811d23

Browse files
committed
parquetDataFrame returns an unsortable dataframe
1 parent abfb39a commit 8811d23

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/lib/tableProvider.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { DataFrame, DataFrameEvents, ResolvedValue, checkSignal, createEventTarget, sortableDataFrame, validateFetchParams, validateGetCellParams, validateGetRowNumberParams } from 'hightable'
1+
import { DataFrame, DataFrameEvents, ResolvedValue, checkSignal, createEventTarget, validateFetchParams, validateGetCellParams, validateGetRowNumberParams } from 'hightable'
22
import type { ColumnData } from 'hyparquet'
33
import { FileMetaData, ParquetReadOptions, parquetSchema } from 'hyparquet'
44
import { parquetReadWorker } from './workers/parquetWorkerClient.js'
@@ -21,7 +21,8 @@ interface VirtualRowGroup {
2121
/**
2222
* Convert a parquet file into a dataframe.
2323
*
24-
* It's sortable on all the columns, and fetches data on demand in chunks of 1000 rows.
24+
* It fetches data on demand in chunks of 1000 rows within each row group.
25+
* It's not sortable. You can use sortableDataFrame from hightable to make it sortable.
2526
*/
2627
export function parquetDataFrame(from: AsyncBufferFrom, metadata: FileMetaData, options?: Pick<ParquetReadOptions, 'utf8'>): DataFrame<{parquet: FileMetaData}> {
2728
const { children } = parquetSchema(metadata)
@@ -127,5 +128,5 @@ export function parquetDataFrame(from: AsyncBufferFrom, metadata: FileMetaData,
127128
},
128129
}
129130

130-
return sortableDataFrame(unsortableDataFrame)
131+
return unsortableDataFrame
131132
}

0 commit comments

Comments
 (0)