add a warning in the console. No need to do more

severo · severo · commit a9cd7426e7b9 · 2024-11-07T11:39:07.000+01:00
diff --git a/packages/components/src/workers/parquetWorkerClient.ts b/packages/components/src/workers/parquetWorkerClient.ts
@@ -68,10 +68,10 @@ function getWorker() {
     worker.onmessage = ({ data }: { data: ParquetMessage | SortParquetMessage }) => {
       const pendingQueryAgent = pending.get(data.queryId)
       if (!pendingQueryAgent) {
-        throw new Error(
+        console.warn(
           `Unexpected: no pending promise found for queryId: ${data.queryId.toString()}`,
         )
-        // TODO(SL): should never happen. But if it does, I'm not sure if throwing an error here helps.
+        return
       }
       if (pendingQueryAgent.kind === 'query') {
         const { resolve, reject, onChunk } = pendingQueryAgent

Original file line number	Diff line number	Diff line change
`@@ -68,10 +68,10 @@ function getWorker() {`
`68`	`68`	`worker.onmessage = ({ data }: { data: ParquetMessage \| SortParquetMessage }) => {`
`69`	`69`	`const pendingQueryAgent = pending.get(data.queryId)`
`70`	`70`	`if (!pendingQueryAgent) {`
`71`		`- throw new Error(`
	`71`	`+ console.warn(`
`72`	`72`	`Unexpected: no pending promise found for queryId: ${data.queryId.toString()}`,
`73`	`73`	`)`
`74`		`- // TODO(SL): should never happen. But if it does, I'm not sure if throwing an error here helps.`
	`74`	`+ return`
`75`	`75`	`}`
`76`	`76`	`if (pendingQueryAgent.kind === 'query') {`
`77`	`77`	`const { resolve, reject, onChunk } = pendingQueryAgent`