Skip to content

Commit b73d419

Browse files
committed
move Spinner styles to CSS module + move to a new component file
1 parent 45e4969 commit b73d419

File tree

14 files changed

+44
-29
lines changed

14 files changed

+44
-29
lines changed

src/app.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import 'hightable/src/HighTable.css'
21
import { StrictMode } from 'react'
32
import { createRoot } from 'react-dom/client'
43
import App from './components/App.js'

src/components/Folder.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ import { useConfig } from '../hooks/useConfig.js'
33
import type { DirSource, FileMetadata } from '../lib/sources/types.js'
44
import { cn, formatFileSize, getFileDate, getFileDateShort } from '../lib/utils.js'
55
import Breadcrumb from './Breadcrumb.js'
6-
import Layout, { Spinner } from './Layout.js'
6+
import Layout from './Layout.js'
7+
import Spinner from './Spinner.js'
78

89
interface FolderProps {
910
source: DirSource

src/components/Layout.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,6 @@ export default function Layout({ children, className, progress, error, title }:
5959
</main>
6060
}
6161

62-
export function Spinner({ className }: { className?: string }) {
63-
return <div className={cn('spinner', className)}></div>
64-
}
65-
6662
export function ErrorBar({ error }: { error?: Error }) {
6763
const [showError, setShowError] = useState(error !== undefined)
6864
const [prevError, setPrevError] = useState(error)

src/components/Spinner.tsx

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
import { useConfig } from '../hooks/useConfig.js'
2+
import { cn } from '../lib/utils.js'
3+
import styles from '../styles/Spinner.module.css'
4+
5+
export default function Spinner() {
6+
const { customClass } = useConfig()
7+
return <div className={cn(styles.spinner, customClass?.spinner)}></div>
8+
}

src/components/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@ import Breadcrumb from './Breadcrumb.js'
22
import Cell from './Cell.js'
33
import File from './File.js'
44
import Folder from './Folder.js'
5-
import Layout, { ErrorBar, Spinner } from './Layout.js'
5+
import Layout, { ErrorBar } from './Layout.js'
66
import Markdown from './Markdown.js'
77
import Page from './Page.js'
8+
import Spinner from './Spinner.js'
89
export * from './viewers/index.js'
910
export { Breadcrumb, Cell, ErrorBar, File, Folder, Layout, Markdown, Page, Spinner }

src/components/viewers/AvroView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import type { FileSource } from '../../lib/sources/types.js'
44
import { parseFileSize } from '../../lib/utils.js'
55
import styles from '../../styles/Json.module.css'
66
import Json from '../Json.js'
7-
import { Spinner } from '../Layout.js'
7+
import Spinner from '../Spinner.js'
88
import ContentWrapper, { ContentSize } from './ContentWrapper.js'
99

1010
interface ViewerProps {

src/components/viewers/ImageView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { useConfig } from '../../hooks/useConfig.js'
33
import { FileSource } from '../../lib/sources/types.js'
44
import { cn, contentTypes, parseFileSize } from '../../lib/utils.js'
55
import styles from '../../styles/viewers/ImageView.module.css'
6-
import { Spinner } from '../Layout.js'
6+
import Spinner from '../Spinner.js'
77
import ContentWrapper from './ContentWrapper.js'
88

99
interface ViewerProps {

src/components/viewers/JsonView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import type { FileSource } from '../../lib/sources/types.js'
33
import { parseFileSize } from '../../lib/utils.js'
44
import styles from '../../styles/Json.module.css'
55
import Json from '../Json.js'
6-
import { Spinner } from '../Layout.js'
6+
import Spinner from '../Spinner.js'
77
import ContentWrapper, { TextContent } from './ContentWrapper.js'
88

99
interface ViewerProps {

src/components/viewers/MarkdownView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ import { useConfig } from '../../hooks/useConfig.js'
33
import type { FileSource } from '../../lib/sources/types.js'
44
import { cn, parseFileSize } from '../../lib/utils.js'
55
import styles from '../../styles/viewers/MarkdownView.module.css'
6-
import { Spinner } from '../Layout.js'
76
import Markdown from '../Markdown.js'
7+
import Spinner from '../Spinner.js'
88
import ContentWrapper, { TextContent } from './ContentWrapper.js'
99

1010
interface ViewerProps {

src/components/viewers/ParquetView.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import HighTable, { DataFrame, rowCache } from 'hightable'
2+
import 'hightable/src/HighTable.css'
23
import { asyncBufferFromUrl, parquetMetadataAsync } from 'hyparquet'
34
import React, { useCallback, useEffect, useState } from 'react'
45
import { useConfig } from '../../hooks/useConfig.js'
@@ -7,7 +8,7 @@ import { FileSource } from '../../lib/sources/types.js'
78
import { parquetDataFrame } from '../../lib/tableProvider.js'
89
import { cn } from '../../lib/utils.js'
910
import styles from '../../styles/ParquetView.module.css'
10-
import { Spinner } from '../Layout.js'
11+
import Spinner from '../Spinner.js'
1112
import CellPanel from './CellPanel.js'
1213
import ContentWrapper, { ContentSize } from './ContentWrapper.js'
1314
import SlidePanel from './SlidePanel.js'

0 commit comments

Comments
 (0)