add a warning in the console. No need to do more

severo · severo · commit c862433d3e8e · 2024-11-07T19:16:17.000+01:00
diff --git a/packages/components/src/workers/parquetWorkerClient.ts b/packages/components/src/workers/parquetWorkerClient.ts
@@ -27,10 +27,10 @@ function getWorker() {
     worker.onmessage = ({ data }: { data: ParquetMessage | SortParquetMessage }) => {
       const pendingQueryAgent = pending.get(data.queryId)
       if (!pendingQueryAgent) {
-        throw new Error(
+        console.warn(
           `Unexpected: no pending promise found for queryId: ${data.queryId.toString()}`,
         )
-        // TODO(SL): should never happen. But if it does, I'm not sure if throwing an error here helps.
+        return
       }
       if (pendingQueryAgent.kind === 'query') {
         const { resolve, reject, onChunk } = pendingQueryAgent

Original file line number	Diff line number	Diff line change
`@@ -27,10 +27,10 @@ function getWorker() {`
`27`	`27`	`worker.onmessage = ({ data }: { data: ParquetMessage \| SortParquetMessage }) => {`
`28`	`28`	`const pendingQueryAgent = pending.get(data.queryId)`
`29`	`29`	`if (!pendingQueryAgent) {`
`30`		`- throw new Error(`
	`30`	`+ console.warn(`
`31`	`31`	`Unexpected: no pending promise found for queryId: ${data.queryId.toString()}`,
`32`	`32`	`)`
`33`		`- // TODO(SL): should never happen. But if it does, I'm not sure if throwing an error here helps.`
	`33`	`+ return`
`34`	`34`	`}`
`35`	`35`	`if (pendingQueryAgent.kind === 'query') {`
`36`	`36`	`const { resolve, reject, onChunk } = pendingQueryAgent`