Skip to content

Commit de8aad9

Browse files
authored
Fix loading spinners and fade-in the spinner (#161)
1 parent 47cd20f commit de8aad9

File tree

10 files changed

+34
-17
lines changed

10 files changed

+34
-17
lines changed

package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,20 +22,20 @@
2222
},
2323
"devDependencies": {
2424
"@testing-library/react": "16.2.0",
25-
"@types/node": "22.13.1",
25+
"@types/node": "22.13.5",
2626
"@types/react": "19.0.8",
2727
"@types/react-dom": "19.0.3",
2828
"@vitejs/plugin-react": "4.3.4",
29-
"@vitest/coverage-v8": "3.0.5",
30-
"eslint": "9.20.0",
29+
"@vitest/coverage-v8": "3.0.7",
30+
"eslint": "9.21.0",
3131
"eslint-plugin-react": "7.37.4",
3232
"eslint-plugin-react-hooks": "5.1.0",
3333
"eslint-plugin-react-refresh": "0.4.19",
3434
"globals": "15.14.0",
3535
"jsdom": "26.0.0",
3636
"typescript": "5.7.3",
37-
"typescript-eslint": "8.24.0",
38-
"vite": "6.1.0",
39-
"vitest": "3.0.5"
37+
"typescript-eslint": "8.25.0",
38+
"vite": "6.2.0",
39+
"vitest": "3.0.7"
4040
}
4141
}

packages/cli/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"@rollup/plugin-replace": "6.0.2",
4141
"@rollup/plugin-terser": "0.4.4",
4242
"@rollup/plugin-typescript": "12.1.2",
43-
"rollup": "4.32.1",
43+
"rollup": "4.34.8",
4444
"rollup-plugin-postcss": "4.0.2",
4545
"tslib": "2.8.1"
4646
}

packages/cli/public/styles.css

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,23 @@ main {
7474
height: 100vh;
7575
max-width: 100vw;
7676
}
77+
78+
.spinner {
79+
border: 6px solid #e8e8e8;
80+
border-top: 6px solid #68a;
81+
border-radius: 50%;
82+
width: 32px;
83+
height: 32px;
84+
animation: spin 1s linear infinite, fadeIn 3s, ease-in-out forwards;
85+
}
86+
@keyframes spin {
87+
0% { transform: rotate(0deg); }
88+
100% { transform: rotate(360deg); }
89+
}
90+
@keyframes fadeIn {
91+
0% { opacity: 0; }
92+
100% { opacity: 1; }
93+
}
7794
.center {
7895
flex: 1;
7996
display: flex;

packages/components/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,12 @@
4444
"hyparquet": "1.8.4",
4545
"hyparquet-compressors": "1.0.0"
4646
},
47-
"peerDependencies": {
48-
"react": "^18.3.1",
49-
"react-dom": "^18.3.1"
50-
},
5147
"devDependencies": {
5248
"react": "18.3.1",
5349
"react-dom": "18.3.1"
50+
},
51+
"peerDependencies": {
52+
"react": "^18.3.1",
53+
"react-dom": "^18.3.1"
5454
}
5555
}

packages/components/src/components/Folder.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ export default function Folder({ source, config }: FolderProps) {
109109
)}
110110
</ul>}
111111
{files?.length === 0 && <div className='center'>No files</div>}
112-
{files === undefined && <Spinner className='center' />}
112+
{files === undefined && <div className='center'><Spinner /></div>}
113113
</Layout>
114114
}
115115

packages/components/src/components/Layout.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ function Sidebar() {
4949
</nav>
5050
}
5151

52-
export function Spinner({ className }: { className: string }) {
52+
export function Spinner({ className }: { className?: string }) {
5353
return <div className={cn('spinner', className)}></div>
5454
}
5555

packages/components/src/components/viewers/ImageView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ export default function ImageView({ source, setError }: ViewerProps) {
6868
className='image'
6969
src={content.dataUri} />}
7070

71-
{loading && <Spinner className='center' />}
71+
{loading && <div className='center'><Spinner /></div>}
7272
</ContentHeader>
7373
}
7474

packages/components/src/components/viewers/MarkdownView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,6 @@ export default function MarkdownView({ source, setError }: ViewerProps) {
5757
return <ContentHeader content={content}>
5858
<Markdown className='markdown' text={content?.text ?? ''} />
5959

60-
{ loading === LoadingState.Loading && <Spinner className='center' /> }
60+
{ loading === LoadingState.Loading && <div className='center'><Spinner /></div> }
6161
</ContentHeader>
6262
}

packages/components/src/components/viewers/ParquetView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ export default function ParquetView({ source, setProgress, setError, config }: V
114114
onMouseDownCell={onMouseDownCell}
115115
onError={setError} />}
116116

117-
{loading === LoadingState.Loading && <Spinner className='center' />}
117+
{loading === LoadingState.Loading && <div className='center'><Spinner /></div>}
118118
</ContentHeader>
119119

120120
let panelContent

packages/components/src/components/viewers/TextView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export default function TextView({ source, setError }: ViewerProps) {
5151
{content.text}
5252
</code>}
5353

54-
{!content && <Spinner className='center' />}
54+
{!content && <div className='center'><Spinner /></div>}
5555
</ContentHeader>
5656
}
5757

0 commit comments

Comments
 (0)