Skip to content

Commit fa5882d

Browse files
committed
refactor the conditionals for safety
1 parent a005bed commit fa5882d

File tree

1 file changed

+24
-21
lines changed

1 file changed

+24
-21
lines changed

src/components/Folder.tsx

Lines changed: 24 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -94,27 +94,30 @@ export default function Folder({ source }: FolderProps) {
9494
</div>
9595
</Breadcrumb>
9696

97-
{files && files.length > 0 && <ul className='file-list' ref={listRef}>
98-
{filtered?.map((file, index) =>
99-
<li key={index}>
100-
<a href={routes?.getSourceRouteUrl?.({ sourceId: file.sourceId }) ?? location.href}>
101-
<span className={cn('file-name', 'file', file.kind === 'directory' && 'folder')}>
102-
{file.name}
103-
</span>
104-
{file.kind === 'file' && <>
105-
{file.size !== undefined && <span className='file-size' title={file.size.toLocaleString() + ' bytes'}>
106-
{formatFileSize(file.size)}
107-
</span>}
108-
<span className='file-date' title={getFileDate(file)}>
109-
{getFileDateShort(file)}
110-
</span>
111-
</>}
112-
</a>
113-
</li>
114-
)}
115-
</ul>}
116-
{files?.length === 0 && <Center>No files</Center>}
117-
{files === undefined && <Center><Spinner /></Center>}
97+
{files === undefined ?
98+
<Center><Spinner /></Center> :
99+
files.length === 0 ?
100+
<Center>No files</Center> :
101+
<ul className='file-list' ref={listRef}>
102+
{filtered?.map((file, index) =>
103+
<li key={index}>
104+
<a href={routes?.getSourceRouteUrl?.({ sourceId: file.sourceId }) ?? location.href}>
105+
<span className={cn('file-name', 'file', file.kind === 'directory' && 'folder')}>
106+
{file.name}
107+
</span>
108+
{file.kind === 'file' && <>
109+
{file.size !== undefined && <span className='file-size' title={file.size.toLocaleString() + ' bytes'}>
110+
{formatFileSize(file.size)}
111+
</span>}
112+
<span className='file-date' title={getFileDate(file)}>
113+
{getFileDateShort(file)}
114+
</span>
115+
</>}
116+
</a>
117+
</li>
118+
)}
119+
</ul>
120+
}
118121
</Layout>
119122
}
120123

0 commit comments

Comments
 (0)