diff --git a/packages/components/src/lib/tableProvider.ts b/packages/components/src/lib/tableProvider.ts index c01a928a..417be0a2 100644 --- a/packages/components/src/lib/tableProvider.ts +++ b/packages/components/src/lib/tableProvider.ts @@ -14,7 +14,6 @@ export function parquetDataFrame(from: AsyncBufferFromUrl, metadata: FileMetaDat const sortCache = new Map>() const data = new Array(Number(metadata.num_rows)) /// ^ warning: the type is a lie at that point, because all rows are undefined for now - /// TODO(SL): improve the type safety const groups = new Array(metadata.row_groups.length).fill(false) let groupStart = 0 const groupEnds = metadata.row_groups.map(group => groupStart += Number(group.num_rows)) diff --git a/packages/components/src/workers/parquetWorkerClient.ts b/packages/components/src/workers/parquetWorkerClient.ts index e0a42ab4..cfb3ef0f 100644 --- a/packages/components/src/workers/parquetWorkerClient.ts +++ b/packages/components/src/workers/parquetWorkerClient.ts @@ -27,10 +27,10 @@ function getWorker() { worker.onmessage = ({ data }: { data: ParquetMessage | SortParquetMessage }) => { const pendingQueryAgent = pending.get(data.queryId) if (!pendingQueryAgent) { - throw new Error( + console.warn( `Unexpected: no pending promise found for queryId: ${data.queryId.toString()}`, ) - // TODO(SL): should never happen. But if it does, I'm not sure if throwing an error here helps. + return } if (pendingQueryAgent.kind === 'query') { const { resolve, reject, onChunk } = pendingQueryAgent diff --git a/src/app.js b/src/app.js index 9927804d..6c8c634a 100644 --- a/src/app.js +++ b/src/app.js @@ -5,6 +5,5 @@ import ReactDOM from 'react-dom/client' const app = document.getElementById('app') if (!app) throw new Error('missing app element') -// @ts-expect-error TODO: fix react createRoot type -const root = ReactDOM.createRoot(document.getElementById('app')) +const root = ReactDOM.createRoot(app) root.render(React.createElement(App))