🎨 refactor getAll method to use Set for allowList and improve empty list handling

Author: BirjuVachhani

packages/hyper_secure_storage/lib/src/backend.dart

@@ -5,8 +5,6 @@
 import 'package:flutter_secure_storage/flutter_secure_storage.dart';
 import 'package:hyper_storage/hyper_storage.dart';
 
-import 'utils.dart';
-
 /// A secure storage backend implementation that leverages platform-specific
 /// secure storage mechanisms to protect sensitive data.
 class SecureStorageBackend extends StorageBackend {
@@ -59,14 +57,12 @@ class SecureStorageBackend extends StorageBackend {
   Future<int?> getInt(String key) async => int.tryParse(await storage.read(key: key) ?? '');
 
   @override
-  Future<Map<String, dynamic>> getAll([Iterable<String>? allowList]) async {
-    // decoded keys associated with this container.
+  Future<Map<String, dynamic>> getAll(Set<String> allowList) async {
     final Map<String, String> all = await storage.readAll();
     final Map<String, dynamic> data = {};
+    if (allowList.isEmpty) return {};
     for (final MapEntry(:key, :value) in all.entries) {
-      if (allowList != null && allowList.isNotEmpty && !allowList.contains(key)) {
-        continue;
-      }
+      if (!allowList.contains(key)) continue;
       data[key] = _parseValue(value);
     }
     return data;
@@ -89,8 +85,7 @@ class SecureStorageBackend extends StorageBackend {
   ///
   /// This is an internal utility method used by [getAll] for automatic type
   /// inference.
-  Object? _parseValue(String value) =>
-      bool.tryParse(value) ?? int.tryParse(value) ?? double.tryParse(value) ?? tryJsonDecode(value) ?? value;
+  Object? _parseValue(String value) => bool.tryParse(value) ?? int.tryParse(value) ?? double.tryParse(value) ?? value;
 
   @override
   Future<Set<String>> getKeys() async {

packages/hyper_storage/lib/src/api/api.dart

@@ -495,7 +495,7 @@ abstract interface class StorageOperationsApi {
   ///
   /// Throws:
   /// * [ArgumentError] if any key in the allow list is invalid.
-  Future<Map<String, dynamic>> getAll([Iterable<String>? allowList]);
+  Future<Map<String, dynamic>> getAll(Set<String> allowList);
 
   /// Saves multiple key-value pairs from a [Map] in a single operation.
   ///

packages/hyper_storage/lib/src/api/serializable_container.dart

@@ -497,7 +497,9 @@ abstract class SerializableStorageContainer<E> extends StorageContainer implemen
   @override
   Future<Map<String, E>> getAll([Iterable<String>? allowList]) async {
     validateKeys(allowList);
-    final Map<String, dynamic> allData = await backend.getAll(allowList?.map(encodeKey) ?? await getEncodedKeys());
+    final keys = allowList?.map(encodeKey) ?? await getEncodedKeys();
+    if (keys.isEmpty) return {};
+    final Map<String, dynamic> allData = await backend.getAll(keys.toSet());
     return <String, E>{
       for (final MapEntry(:key, :value) in allData.entries) decodeKey(key): deserialize(value.toString()),
     };

packages/hyper_storage/lib/src/hyper_storage_container.dart

@@ -118,7 +118,9 @@ final class HyperStorageContainer extends StorageContainer with ItemHolderMixin,
   @override
   Future<Map<String, dynamic>> getAll([Iterable<String>? allowList]) async {
     validateKeys(allowList);
-    final map = await backend.getAll(allowList?.map(encodeKey) ?? await getEncodedKeys());
+    allowList ??= await getEncodedKeys();
+    if (allowList.isEmpty) return {};
+    final map = await backend.getAll(allowList.map(encodeKey).toSet());
     return {for (final entry in map.entries) decodeKey(entry.key): entry.value};
   }
 

packages/hyper_storage/lib/src/storage_base.dart

@@ -92,7 +92,8 @@ abstract class _HyperStorageImpl extends BaseStorage
   @override
   Future<Map<String, dynamic>> getAll([Iterable<String>? allowList]) {
     _validateKeys(allowList);
-    return backend.getAll(allowList);
+    if (allowList == null || allowList.isEmpty) return Future.value(<String, dynamic>{});
+    return backend.getAll(allowList.toSet());
   }
 
   @override

packages/hyper_storage_hive/lib/src/backend.dart

@@ -77,12 +77,10 @@ class HiveBackend extends StorageBackend {
   Future<int?> getInt(String key) async => await box.get(key);
 
   @override
-  Future<Map<String, dynamic>> getAll([Iterable<String>? allowList]) async {
+  Future<Map<String, dynamic>> getAll(Set<String> allowList) async {
     final data = <String, dynamic>{...box.toMap()};
-    if (allowList != null && allowList.isNotEmpty) {
-      data.removeWhere((key, value) => !allowList.contains(key));
-    }
-    return data;
+    if (allowList.isEmpty) return {};
+    return data..removeWhere((key, value) => !allowList.contains(key));
   }
 
   @override

packages/hyper_storage_hive/lib/src/lazy_backend.dart

@@ -78,14 +78,12 @@ class LazyHiveBackend extends StorageBackend {
   Future<int?> getInt(String key) async => await box.get(key);
 
   @override
-  Future<Map<String, dynamic>> getAll([Iterable<String>? allowList]) async {
+  Future<Map<String, dynamic>> getAll(Set<String> allowList) async {
     final data = <String, dynamic>{
       for (final key in box.keys) key.toString(): await box.get(key),
     };
-    if (allowList != null && allowList.isNotEmpty) {
-      data.removeWhere((key, value) => !allowList.contains(key));
-    }
-    return data;
+    if (allowList.isEmpty) return {};
+    return data..removeWhere((key, value) => !allowList.contains(key));
   }
 
   @override

packages/hyper_storage_hive/test/test_helpers.dart

@@ -1,7 +1,6 @@
 import 'dart:io';
 
 import 'package:hive_ce/hive.dart';
-import 'package:path/path.dart' as path;
 
 /// Sets up Hive with a temporary directory for testing.
 Future<Directory> setupHive() async {

packages/hyper_storage_shared_preferences/lib/src/backend.dart

@@ -51,9 +51,8 @@ class SharedPreferencesBackend extends StorageBackend {
   Future<int?> getInt(String key) => prefs.getInt(key);
 
   @override
-  Future<Map<String, dynamic>> getAll([Iterable<String>? allowList]) async {
-    final allKeys = await getKeys();
-    if (allowList == null || allowList.isEmpty) allowList = allKeys;
+  Future<Map<String, dynamic>> getAll(Set<String> allowList) async {
+    if (allowList.isEmpty) return {};
     final data = await prefs.getAll(allowList: allowList.toSet());
     return data.map((key, value) => MapEntry(key, value));
   }