🐛 Fix default provider configuration saving

Fix issue where default provider changes were not being saved
to configuration files.

- Modify apply_to_config to return boolean indicating changes made
- Update apply_config_changes to track common parameter changes
- Ensure provider insertion is handled only when needed
- Add proper change tracking for all configuration updates
- Fix duplicate provider setting logic in commands.rs

Author: hyperb1iss

src/commands.rs

@@ -42,18 +42,16 @@ fn apply_config_changes(
 ) -> anyhow::Result<bool> {
     let mut changes_made = false;
 
-    // Apply common parameters to the config
-    common.apply_to_config(config)?;
+    // Apply common parameters to the config and track if changes were made
+    let common_changes = common.apply_to_config(config)?;
+    changes_made |= common_changes;
 
-    // Handle provider change
+    // Handle provider change - but skip if already handled by apply_to_config
     if let Some(provider) = &common.provider {
         if !get_available_provider_names().iter().any(|p| p == provider) {
             return Err(anyhow!("Invalid provider: {}", provider));
         }
-        if config.default_provider != *provider {
-            config.default_provider.clone_from(provider);
-            changes_made = true;
-        }
+        // Only check for provider insertion if it wasn't already handled
         if !config.providers.contains_key(provider) {
             config
                 .providers

src/commit/cli.rs

@@ -181,7 +181,7 @@ fn validate_pr_parameters(_from: Option<&String>, _to: Option<&String>) {
     // - from only: from..HEAD
     // - to only: main..to
     // - none: main..HEAD (caught earlier, but handled gracefully)
-    
+
     // No validation errors needed - all combinations are handled
 }
 
@@ -224,16 +224,44 @@ async fn generate_pr_based_on_parameters(
 
     let pr_description = match (from, to) {
         (Some(from_ref), Some(to_ref)) => {
-            handle_from_and_to_parameters(service, preset_str, &effective_instructions, from_ref, to_ref, &random_message).await?
+            handle_from_and_to_parameters(
+                service,
+                preset_str,
+                &effective_instructions,
+                from_ref,
+                to_ref,
+                &random_message,
+            )
+            .await?
         }
         (None, Some(to_ref)) => {
-            handle_to_only_parameter(service, preset_str, &effective_instructions, to_ref, &random_message).await?
+            handle_to_only_parameter(
+                service,
+                preset_str,
+                &effective_instructions,
+                to_ref,
+                &random_message,
+            )
+            .await?
         }
         (Some(from_ref), None) => {
-            handle_from_only_parameter(service, preset_str, &effective_instructions, from_ref, &random_message).await?
+            handle_from_only_parameter(
+                service,
+                preset_str,
+                &effective_instructions,
+                from_ref,
+                &random_message,
+            )
+            .await?
         }
         (None, None) => {
-            handle_no_parameters(service, preset_str, &effective_instructions, &random_message).await?
+            handle_no_parameters(
+                service,
+                preset_str,
+                &effective_instructions,
+                &random_message,
+            )
+            .await?
         }
     };
 
@@ -305,7 +333,7 @@ async fn handle_to_only_parameter(
     random_message: &crate::messages::ColoredMessage,
 ) -> Result<super::types::GeneratedPullRequest> {
     let spinner = ui::create_spinner("");
-    
+
     // Check if this is a single commit hash
     if is_likely_commit_hash(&to_ref) {
         // For a single commit specified with --to, compare it against its parent
@@ -359,7 +387,7 @@ async fn handle_from_only_parameter(
     random_message: &crate::messages::ColoredMessage,
 ) -> Result<super::types::GeneratedPullRequest> {
     let spinner = ui::create_spinner("");
-    
+
     // Check if this looks like a single commit hash that we should compare against its parent
     if is_likely_commit_hash(&from_ref) {
         // For a single commit hash, compare it against its parent (commit^..commit)

src/common.rs

@@ -75,26 +75,52 @@ pub struct CommonParams {
 }
 
 impl CommonParams {
-    pub fn apply_to_config(&self, config: &mut Config) -> Result<()> {
+    pub fn apply_to_config(&self, config: &mut Config) -> Result<bool> {
+        let mut changes_made = false;
+
         if let Some(provider) = &self.provider {
             // Convert "claude" to "anthropic" for backward compatibility
             let provider_name = if provider.to_lowercase() == "claude" {
                 "anthropic".to_string()
             } else {
                 provider.clone()
             };
-            config.default_provider.clone_from(&provider_name);
+
+            // Check if we need to update the default provider
+            if config.default_provider != provider_name {
+                // Ensure the provider exists in the providers HashMap
+                if !config.providers.contains_key(&provider_name) {
+                    // Import ProviderConfig here
+                    use crate::config::ProviderConfig;
+                    config.providers.insert(
+                        provider_name.clone(),
+                        ProviderConfig::default_for(&provider_name),
+                    );
+                }
+
+                config.default_provider.clone_from(&provider_name);
+                changes_made = true;
+            }
         }
+
         if let Some(instructions) = &self.instructions {
             config.set_temp_instructions(Some(instructions.clone()));
+            // Note: temp instructions don't count as permanent changes
         }
+
         if let Some(preset) = &self.preset {
             config.set_temp_preset(Some(preset.clone()));
+            // Note: temp preset doesn't count as permanent changes
         }
+
         if let Some(use_gitmoji) = self.gitmoji {
-            config.use_gitmoji = use_gitmoji;
+            if config.use_gitmoji != use_gitmoji {
+                config.use_gitmoji = use_gitmoji;
+                changes_made = true;
+            }
         }
-        Ok(())
+
+        Ok(changes_made)
     }
 
     /// Check if the provided preset is valid for the specified preset type