🚨 Fine-tune lint settings for clarity

Revamp the Clippy lint configuration to better communicate
coding standards and accommodate practical exceptions:

- Shift `missing_docs` in Rust lints to early mentions by allowing
  missing documentation entries
- Refine organization of Clippy lint levels, highlighting warnings,
  denials, and specific allowances
- Introduce detailed prioritization levels within lint categories,
  emphasizing critical safety checks
- Permit pragmatic code style preferences while elevating
  performance and safety-critical denials

Each adjustment aims to balance code quality, practical
considerations, and ease of future configuration adaptations.

Author: hyperb1iss

Cargo.toml

@@ -100,23 +100,41 @@ integration = []
 
 [lints.rust]
 unsafe_code = "forbid"
+missing_docs = { level = "allow", priority = 1 }
 
 [lints.clippy]
+# Base lint groups
 all = { level = "deny", priority = 0 }
-pedantic = { level = "deny", priority = 1 }
-enum_glob_use = { level = "deny", priority = 2 }
-module_name_repetitions = { level = "allow", priority = 3 }
-cast_precision_loss = { level = "allow", priority = 4 }
-cast_possible_truncation = { level = "allow", priority = 5 }
-cast_sign_loss = { level = "allow", priority = 6 }
-out_of_bounds_indexing = { level = "allow", priority = 7 }
-perf = { level = "warn", priority = 8 }
-style = { level = "warn", priority = 9 }
-missing_errors_doc = { level = "allow", priority = 10 }
-must_use_candidate = { level = "allow", priority = 11 }
-missing_panics_doc = { level = "allow", priority = 12 }
-missing_docs = { level = "allow", priority = 13 }
-significant_drop_tightening = { level = "allow", priority = 14 }
-# maybe this should be enabled in the future
-unwrap_used = { level = "deny", priority = 10 }
-#expect_used = { level = "deny", priority = 11 }
+style = { level = "warn", priority = 1 }
+perf = { level = "deny", priority = 1 }
+
+# Pedantic lints
+pedantic = { level = "deny", priority = 10 }
+
+# Documentation allowances
+missing_errors_doc = { level = "allow", priority = 20 }
+missing_panics_doc = { level = "allow", priority = 20 }
+missing_safety_doc = { level = "allow", priority = 20 }
+
+# Code style allowances - These remain allowed for pragmatic reasons
+module_name_repetitions = { level = "allow", priority = 21 }
+significant_drop_tightening = { level = "allow", priority = 21 }
+must_use_candidate = { level = "allow", priority = 21 }
+
+# Numeric casting and conversion warnings
+cast_precision_loss = { level = "warn", priority = 22 }
+cast_possible_truncation = { level = "warn", priority = 22 }
+cast_sign_loss = { level = "warn", priority = 22 }
+as_conversions = { level = "warn", priority = 22 }
+
+# Safety-critical denials
+out_of_bounds_indexing = { level = "deny", priority = 30 }
+enum_glob_use = { level = "deny", priority = 30 }
+unwrap_used = { level = "deny", priority = 30 }
+undocumented_unsafe_blocks = { level = "deny", priority = 30 }
+
+# Future considerations
+#expect_used = { level = "deny", priority = 30 }
+#todo = { level = "warn", priority = 20 }           # Consider warning on TODOs
+#dbg_macro = { level = "warn", priority = 30 }      # Consider warning on dbg! macro usage
+#print_stdout = { level = "warn", priority = 30 }   # Consider warning on print!/println! usage

src/changes/change_analyzer.rs

@@ -200,20 +200,24 @@ impl ChangeAnalyzer {
 
     /// Extract associated issue numbers from the commit message
     fn extract_associated_issues(commit_message: &str) -> Vec<String> {
-        let re = Regex::new(r"(?:#|GH-)(\d+)").unwrap();
+        let re = Regex::new(r"(?:#|GH-)(\d+)")
+            .expect("Failed to compile issue number regex pattern - this is a bug");
         re.captures_iter(commit_message)
             .map(|cap| format!("#{}", &cap[1]))
             .collect()
     }
 
     /// Extract pull request number from the commit message
     fn extract_pull_request(commit_message: &str) -> Option<String> {
-        let re = Regex::new(r"(?i)(?:pull request|PR)\s*#?(\d+)").unwrap();
+        let re = Regex::new(r"(?i)(?:pull request|PR)\s*#?(\d+)")
+            .expect("Failed to compile pull request regex pattern - this is a bug");
         re.captures(commit_message)
             .map(|cap| format!("PR #{}", &cap[1]))
     }
 
     /// Calculate the impact score of the change
+    #[allow(clippy::cast_precision_loss)]
+    #[allow(clippy::as_conversions)]
     fn calculate_impact_score(
         metrics: &ChangeMetrics,
         file_changes: &[FileChange],

src/tui/ui.rs

@@ -269,6 +269,7 @@ pub fn draw_status(f: &mut Frame, state: &mut TuiState, area: Rect) {
             )
         };
 
+    #[allow(clippy::as_conversions)]
     let terminal_width = f.area().width as usize;
 
     // Ensure we don't overflow when calculating padding