Skip to content

Commit a34ff04

Browse files
committed
📦 Fix release asset naming and install script printf format specifiers
Improve CI/CD release workflow: - Rename binaries with platform suffix (git-iris-linux-amd64, etc.) instead of flat-copying from artifacts - Use glob patterns to copy only deb/rpm/man files as-is - Remove inline changelog generation step (now handled separately) - Simplify release files list by removing CHANGELOG_SECTION.md Fix install.sh printf calls by using %b instead of %s for the message argument. This ensures escape sequences in messages are interpreted correctly rather than printed literally.
1 parent 0c93043 commit a34ff04

File tree

2 files changed

+19
-23
lines changed

2 files changed

+19
-23
lines changed

.github/workflows/cicd.yml

Lines changed: 15 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,20 @@ jobs:
358358
run: |
359359
echo "::group::Preparing release assets"
360360
mkdir -p release-assets
361-
find ./artifacts -type f -exec cp {} ./release-assets/ \;
361+
362+
# Rename binaries with platform suffix from artifact directory names
363+
for dir in ./artifacts/git-iris-*/; do
364+
artifact_name=$(basename "$dir")
365+
if [ -f "$dir/git-iris" ]; then
366+
cp "$dir/git-iris" "./release-assets/${artifact_name}"
367+
elif [ -f "$dir/git-iris.exe" ]; then
368+
cp "$dir/git-iris.exe" "./release-assets/${artifact_name}.exe"
369+
fi
370+
done
371+
372+
# Copy non-binary artifacts (deb, rpm, man page) as-is
373+
find ./artifacts -type f \( -name "*.deb" -o -name "*.rpm" -o -name "*.1" \) -exec cp {} ./release-assets/ \;
374+
362375
ls -la ./release-assets
363376
echo "::endgroup::"
364377
@@ -375,21 +388,6 @@ jobs:
375388
echo "Binary ready: ./artifacts/git-iris-linux-amd64/git-iris"
376389
./artifacts/git-iris-linux-amd64/git-iris --version
377390
378-
- name: 📋 Generate changelog with Git-Iris
379-
id: changelog
380-
if: steps.prev_tag.outputs.tag != ''
381-
uses: ./
382-
with:
383-
command: changelog
384-
from: ${{ steps.prev_tag.outputs.tag }}
385-
to: ${{ github.ref_name }}
386-
version-name: ${{ github.ref_name }}
387-
provider: anthropic
388-
model: claude-opus-4-5-20251101
389-
api-key: ${{ secrets.ANTHROPIC_API_KEY }}
390-
output-file: CHANGELOG_SECTION.md
391-
binary-path: ./artifacts/git-iris-linux-amd64/git-iris
392-
393391
- name: 📥 Download release notes from release workflow
394392
id: download_notes
395393
if: ${{ inputs.release_run_id != '' }}
@@ -427,9 +425,7 @@ jobs:
427425
name: Release ${{ github.ref_name }}
428426
draft: false
429427
prerelease: false
430-
files: |
431-
./release-assets/*
432-
CHANGELOG_SECTION.md
428+
files: ./release-assets/*
433429
body_path: RELEASE_NOTES.md
434430

435431
# Auto-update major version tag (v1, v2, etc.) for GitHub Action users

install.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,19 @@ BINARY_NAME="git-iris"
2323
INSTALL_DIR="${IRIS_INSTALL_DIR:-$HOME/.local/bin}"
2424

2525
info() {
26-
printf '%b>%b %s\n' "$CYAN" "$RESET" "$1"
26+
printf '%b>%b %b\n' "$CYAN" "$RESET" "$1"
2727
}
2828

2929
success() {
30-
printf '%b%b%b %s\n' "$GREEN" "" "$RESET" "$1"
30+
printf '%b%b%b %b\n' "$GREEN" "" "$RESET" "$1"
3131
}
3232

3333
warn() {
34-
printf '%b!%b %s\n' "$YELLOW" "$RESET" "$1"
34+
printf '%b!%b %b\n' "$YELLOW" "$RESET" "$1"
3535
}
3636

3737
error() {
38-
printf '%b%b%b %s\n' "$RED" "" "$RESET" "$1" >&2
38+
printf '%b%b%b %b\n' "$RED" "" "$RESET" "$1" >&2
3939
exit 1
4040
}
4141

0 commit comments

Comments
 (0)