✨ Add preset type categorization for command specificity

Add support for command-specific instruction presets

This enhancement improves preset management by categorizing presets:
- Add PresetType enum (Commit, Review, Both) to distinguish usage context
- Add specialized review presets: security, performance, architecture, etc.
- Update list-presets command to show categorized output by type
- Add validation to warn when using incorrect preset types
- Update documentation to reflect preset categorization
- Modify help text to guide users to appropriate presets

Users can now clearly identify which presets are suitable for commit
messages versus code reviews, improving the overall experience.

Author: hyperb1iss

README.md

@@ -256,24 +256,38 @@ To list available presets:
 git-iris list-presets
 ```
 
-This will display a list of all available presets with a brief description of each.
+This will display a list of all available presets with a brief description of each, categorized by type (general, review-specific, or commit-specific).
 
 Some key presets include:
 
-- `default`: Standard commit message style
+- `default`: Standard professional style (for both commits and reviews)
 - `conventional`: Follows the Conventional Commits specification
-- `detailed`: Provides more context and explanation in commit messages
-- `concise`: Short and to-the-point commit messages
-- `cosmic`: Mystical, space-themed commit messages
-- ..and lots more styles
+- `detailed`: Provides more context and explanation
+- `concise`: Short and to-the-point responses
+- `cosmic`: Mystical, space-themed language
+
+For code reviews specifically, Git-Iris includes specialized presets:
+
+- `security`: Focus on security vulnerabilities and best practices
+- `performance`: Analyze code for performance optimizations
+- `architecture`: Evaluate architectural patterns and design decisions
+- `testing`: Focus on test coverage and testing strategies
+- `maintainability`: Evaluate code for long-term maintenance
+- `conventions`: Check adherence to language and project coding standards
 
 To use a preset for a single commit:
 
 ```bash
 git-iris gen --preset conventional
 ```
 
-To set a default preset for all commits:
+To use a preset for a code review:
+
+```bash
+git-iris review --preset security
+```
+
+To set a default preset:
 
 ```bash
 git-iris config --preset conventional

docs/code-review-docs.md

@@ -99,7 +99,22 @@ You can use instruction presets to guide the review:
 git-iris review --preset security
 ```
 
-This will apply security-focused instructions to the review process.
+Git-Iris now includes several review-specific presets:
+
+- `security` - Focus on security vulnerabilities and best practices
+- `performance` - Analyze code for performance optimizations
+- `architecture` - Evaluate architectural patterns and design decisions
+- `testing` - Focus on test coverage and testing strategies
+- `maintainability` - Evaluate code for long-term maintenance
+- `conventions` - Check adherence to language and project coding standards
+
+You can view all available presets with:
+
+```bash
+git-iris list-presets
+```
+
+This will display all presets categorized by their type (general, review-specific, or commit-specific).
 
 ## 5. Review Output Format
 

src/commands.rs

@@ -1,7 +1,9 @@
 use crate::ProviderConfig;
 use crate::common::CommonParams;
 use crate::config::Config;
-use crate::instruction_presets::get_instruction_preset_library;
+use crate::instruction_presets::{
+    PresetType, get_instruction_preset_library, list_presets_formatted_by_type,
+};
 use crate::llm_providers::get_available_providers;
 use crate::log_debug;
 use crate::ui;
@@ -10,8 +12,6 @@ use anyhow::{Result, anyhow};
 use colored::Colorize;
 use std::collections::HashMap;
 
-use unicode_width::UnicodeWidthStr;
-
 /// Handle the 'config' command
 #[allow(clippy::too_many_lines)]
 pub fn handle_config_command(
@@ -160,44 +160,40 @@ fn parse_additional_params(params: &[String]) -> HashMap<String, String> {
 
 /// Handle the '`list_presets`' command
 pub fn handle_list_presets_command() -> Result<()> {
-    let preset_library = get_instruction_preset_library();
+    let library = get_instruction_preset_library();
+
+    // Get different categories of presets
+    let both_presets = list_presets_formatted_by_type(&library, Some(PresetType::Both));
+    let commit_only_presets = list_presets_formatted_by_type(&library, Some(PresetType::Commit));
+    let review_only_presets = list_presets_formatted_by_type(&library, Some(PresetType::Review));
+
+    println!(
+        "{}",
+        "\nGit-Iris Instruction Presets\n".bright_magenta().bold()
+    );
 
     println!(
         "{}",
-        "\n🔮 Available Instruction Presets 🔮"
-            .bright_purple()
+        "General Presets (usable for both commit and review):"
+            .bright_cyan()
             .bold()
     );
-    println!("{}", "━".repeat(50).bright_purple());
+    println!("{both_presets}\n");
 
-    let mut presets = preset_library.list_presets();
-    presets.sort_by(|a, b| a.0.cmp(b.0)); // Sort alphabetically by key
+    if !commit_only_presets.is_empty() {
+        println!("{}", "Commit-specific Presets:".bright_green().bold());
+        println!("{commit_only_presets}\n");
+    }
 
-    let max_key_length = presets
-        .iter()
-        .map(|(key, _)| key.width())
-        .max()
-        .unwrap_or(0);
-
-    for (key, preset) in presets {
-        println!(
-            "{} {:<width$} {}",
-            "•".bright_cyan(),
-            key.bright_green().bold(),
-            preset.name.cyan().italic(),
-            width = max_key_length
-        );
-        println!("  {}", format!("\"{}\"", preset.description).bright_white());
-        println!(); // Add a blank line between presets
+    if !review_only_presets.is_empty() {
+        println!("{}", "Review-specific Presets:".bright_blue().bold());
+        println!("{review_only_presets}\n");
     }
 
-    println!("{}", "━".repeat(50).bright_purple());
-    println!(
-        "{}",
-        "Use with: git-iris gen --preset <preset-name>"
-            .bright_yellow()
-            .italic()
-    );
+    println!("{}", "Usage:".bright_yellow().bold());
+    println!("  git-iris gen --preset <preset-key>");
+    println!("  git-iris review --preset <preset-key>");
+    println!("\nPreset types: [B] = Both commands, [C] = Commit only, [R] = Review only");
 
     Ok(())
 }

src/commit/cli.rs

@@ -3,6 +3,7 @@ use super::service::IrisCommitService;
 use crate::common::CommonParams;
 use crate::config::Config;
 use crate::context::format_commit_message;
+use crate::instruction_presets::PresetType;
 use crate::llm_providers::LLMProviderType;
 use crate::messages;
 use crate::tui::run_tui_commit;
@@ -19,6 +20,14 @@ pub async fn handle_gen_command(
     print: bool,
     verify: bool,
 ) -> Result<()> {
+    // Check if the preset is appropriate for commit messages
+    if !common.is_valid_preset_for_type(PresetType::Commit) {
+        ui::print_warning(
+            "The specified preset may not be suitable for commit messages. Consider using a commit or general preset instead.",
+        );
+        ui::print_info("Run 'git-iris list-presets' to see available presets for commits.");
+    }
+
     let mut config = Config::load()?;
     common.apply_to_config(&mut config)?;
     let current_dir = std::env::current_dir()?;

src/commit/review.rs

@@ -1,6 +1,7 @@
 use super::service::IrisCommitService;
 use crate::common::CommonParams;
 use crate::config::Config;
+use crate::instruction_presets::PresetType;
 use crate::llm_providers::LLMProviderType;
 use crate::messages;
 use crate::ui;
@@ -11,6 +12,14 @@ use std::sync::Arc;
 
 /// Handles the review command which generates an AI code review of staged changes
 pub async fn handle_review_command(common: CommonParams, print: bool) -> Result<()> {
+    // Check if the preset is appropriate for code reviews
+    if !common.is_valid_preset_for_type(PresetType::Review) {
+        ui::print_warning(
+            "The specified preset may not be suitable for code reviews. Consider using a review or general preset instead.",
+        );
+        ui::print_info("Run 'git-iris list-presets' to see available presets for reviews.");
+    }
+
     let mut config = Config::load()?;
     common.apply_to_config(&mut config)?;
     let current_dir = std::env::current_dir()?;

src/commit/service.rs

@@ -7,6 +7,7 @@ use super::prompt::{create_system_prompt, create_user_prompt, process_commit_mes
 use crate::config::Config;
 use crate::context::{CommitContext, GeneratedMessage, GeneratedReview};
 use crate::git::{CommitResult, GitRepo};
+use crate::instruction_presets::{PresetType, get_instruction_preset_library};
 use crate::llm;
 use crate::llm_providers::{LLMProviderType, get_provider_metadata};
 use crate::log_debug;
@@ -171,7 +172,26 @@ impl IrisCommitService {
         instructions: &str,
     ) -> anyhow::Result<GeneratedMessage> {
         let mut config_clone = self.config.clone();
-        config_clone.instruction_preset = preset.to_string();
+
+        // Check if the preset exists and is valid for commits
+        if preset.is_empty() {
+            config_clone.instruction_preset = "default".to_string();
+        } else {
+            let library = get_instruction_preset_library();
+            if let Some(preset_info) = library.get_preset(preset) {
+                if preset_info.preset_type == PresetType::Review {
+                    log_debug!(
+                        "Warning: Preset '{}' is review-specific, not ideal for commits",
+                        preset
+                    );
+                }
+                config_clone.instruction_preset = preset.to_string();
+            } else {
+                log_debug!("Preset '{}' not found, using default", preset);
+                config_clone.instruction_preset = "default".to_string();
+            }
+        }
+
         config_clone.instructions = instructions.to_string();
 
         let context = self.get_git_info().await?;
@@ -215,7 +235,26 @@ impl IrisCommitService {
         instructions: &str,
     ) -> anyhow::Result<GeneratedReview> {
         let mut config_clone = self.config.clone();
-        config_clone.instruction_preset = preset.to_string();
+
+        // Check if the preset exists and is valid for reviews
+        if preset.is_empty() {
+            config_clone.instruction_preset = "default".to_string();
+        } else {
+            let library = get_instruction_preset_library();
+            if let Some(preset_info) = library.get_preset(preset) {
+                if preset_info.preset_type == PresetType::Commit {
+                    log_debug!(
+                        "Warning: Preset '{}' is commit-specific, not ideal for reviews",
+                        preset
+                    );
+                }
+                config_clone.instruction_preset = preset.to_string();
+            } else {
+                log_debug!("Preset '{}' not found, using default", preset);
+                config_clone.instruction_preset = "default".to_string();
+            }
+        }
+
         config_clone.instructions = instructions.to_string();
 
         let context = self.get_git_info().await?;

src/common.rs

@@ -1,5 +1,5 @@
 use crate::config::Config;
-use crate::instruction_presets::get_instruction_preset_library;
+use crate::instruction_presets::{PresetType, get_instruction_preset_library};
 use crate::llm_providers::LLMProviderType;
 use anyhow::Result;
 use clap::Args;
@@ -46,7 +46,10 @@ pub struct CommonParams {
     pub instructions: Option<String>,
 
     /// Select an instruction preset
-    #[arg(long, help = "Select an instruction preset")]
+    #[arg(
+        long,
+        help = "Select an instruction preset (use 'git-iris list-presets' to see available presets for commits and reviews)"
+    )]
     pub preset: Option<String>,
 
     /// Enable or disable Gitmoji
@@ -78,6 +81,16 @@ impl CommonParams {
         }
         Ok(())
     }
+
+    /// Check if the provided preset is valid for the specified preset type
+    pub fn is_valid_preset_for_type(&self, preset_type: PresetType) -> bool {
+        if let Some(preset_name) = &self.preset {
+            let library = get_instruction_preset_library();
+            let valid_presets = library.list_valid_presets_for_command(preset_type);
+            return valid_presets.iter().any(|(key, _)| *key == preset_name);
+        }
+        true // No preset specified is always valid
+    }
 }
 
 /// Validate provider input against available providers
@@ -100,14 +113,14 @@ pub fn get_combined_instructions(config: &Config) -> String {
     if let Some(preset_instructions) = preset_library.get_preset(config.instruction_preset.as_str())
     {
         prompt.push_str(&format!(
-            "\n\nUse this style for the commit message:\n{}\n\n",
+            "\n\nUse this style for your output:\n{}\n\n",
             preset_instructions.instructions
         ));
     }
 
     if !config.instructions.is_empty() {
         prompt.push_str(&format!(
-            "\n\nAdditional instructions for the commit message:\n{}\n\n",
+            "\n\nAdditional instructions for the request:\n{}\n\n",
             config.instructions
         ));
     }