test: fix alchemy env var missing

The tests shouldn't have to rely on Alchemy. This goes around the issue
and makes it so that tests go to a fake RPC URL directly.
The nice thing is that this also let's us ditch the ugly mock.

Author: pheuberger

src/lib/safe/safe-rpc-urls.ts

@@ -25,6 +25,12 @@ export class RandomRpcStrategy implements SafeRpcStrategy {
   }
 }
 
+export class TestRpcStrategy implements SafeRpcStrategy {
+  getUrl(): string {
+    return "https://example.com";
+  }
+}
+
 export class RpcStrategyFactory {
   static getStrategy(
     chainId: number,
@@ -34,6 +40,10 @@ export class RpcStrategyFactory {
     if (chainId === 314 || chainId === 314159) {
       return new FilecoinRpcStrategy(evmClientFactory);
     }
+    // Test cases should use this chain id
+    if (chainId === 0) {
+      return new TestRpcStrategy();
+    }
     // All other chains use random selection from available RPCs
     return new RandomRpcStrategy(evmClientFactory);
   }

test/safe-signatures/SafeSignatureVerifier.test.ts

@@ -1,24 +1,11 @@
-import { describe, it, expect, vi } from "vitest";
+import { describe, it, expect } from "vitest";
 import Verifier from "../../src/lib/safe/signature-verification/UserUpsertSignatureVerifier.js";
 
-// Mock the entire getRpcUrl module
-vi.mock("../../src/utils/getRpcUrl.js", () => ({
-  getRpcUrl: vi.fn().mockImplementation((chainId: number) => {
-    if (chainId === 1) {
-      throw new Error("Unsupported chain ID: 1");
-    }
-    return "mock-rpc-url";
-  }),
-  getEvmClient: vi.fn().mockReturnValue({
-    verifyMessage: vi.fn().mockResolvedValue(true),
-  }),
-}));
-
 // Testing hashing of typed data via UserUpsertSignatureVerifier
 describe("hashTypedMessage", () => {
   it("should hash the typed message correctly", () => {
     const verifier = new Verifier(
-      11155111,
+      0,
       "0x379756bB61A632Cd3C5C5Ce4F3768f4815feaCda",
       {
         metadata: {
@@ -31,14 +18,14 @@ describe("hashTypedMessage", () => {
       },
     );
     expect(verifier.hashTypedData()).toBe(
-      "0x56b9d12b9b854c0b80f253af1686aa70b14a5bc55ca94f98db6a947bd7660d7a",
+      "0x86f0940b45a51491bd176678752b83b9b0e466c97386b543bf4e59f45f9a774a",
     );
   });
 
   it("should throw with missing fields", () => {
     expect(() => {
       const verifier = new Verifier(
-        11155111,
+        0,
         "0x379756bB61A632Cd3C5C5Ce4F3768f4815feaCda",
         {
           metadata: {
@@ -53,7 +40,7 @@ describe("hashTypedMessage", () => {
 
   it("should handle special characters", () => {
     const verifier = new Verifier(
-      11155111,
+      0,
       "0x379756bB61A632Cd3C5C5Ce4F3768f4815feaCda",
       {
         metadata: {
@@ -71,7 +58,7 @@ describe("hashTypedMessage", () => {
   it("should handle large data", () => {
     const largeMessage = "a".repeat(10000);
     const verifier = new Verifier(
-      11155111,
+      0,
       "0x379756bB61A632Cd3C5C5Ce4F3768f4815feaCda",
       {
         metadata: {
@@ -88,7 +75,7 @@ describe("hashTypedMessage", () => {
 
   it("should handle empty strings", () => {
     const verifier = new Verifier(
-      11155111,
+      0,
       "0x379756bB61A632Cd3C5C5Ce4F3768f4815feaCda",
       {
         metadata: {
@@ -101,7 +88,7 @@ describe("hashTypedMessage", () => {
       },
     );
     expect(verifier.hashTypedData()).toBe(
-      "0xa0752bebdb2725e200a8f2ebb6ad12f35b2566710f18c51e625276b267f623b9",
+      "0xf6ca8a6277d5d7015160a9c28b4aca0f5cf529b8f477e94138d06983cf6e42ca",
     );
   });
 });