fix(metadata.test.ts): metadata upload unit tests

Fixes the test file and controller to have passing tests and better
error handling for the metadata upload functionality of the
MetadataController

Author: bitbeckers

package.json

@@ -115,7 +115,9 @@
     "typedoc": "^0.26.5",
     "typescript": "5.5.3",
     "typescript-eslint": "^7.7.0",
-    "vitest": "^1.1.3"
+    "vite-tsconfig-paths": "^5.1.4",
+    "vitest": "^1.1.3",
+    "vitest-mock-extended": "^2.0.2"
   },
   "lint-staged": {
     "*.{mjx,cjs,js,jsx,ts,tsx}": [

pnpm-lock.yaml

@@ -40,46 +40,55 @@ export class MetadataController extends Controller {
     message: "Validation failed",
     errors: { metadata: "Invalid metadata." },
   })
-  public async storeMetadata(
-    @Body() requestBody: StoreMetadataRequest,
-  ): Promise<StorageResponse> {
+  public async storeMetadata(@Body() requestBody: StoreMetadataRequest) {
     const storage = await StorageService.init();
-    const metadataValidationResult = validateMetadataAndClaimdata(
-      requestBody.metadata,
-    );
+    const { metadata } = requestBody;
 
-    if (!metadataValidationResult.valid) {
-      this.setStatus(422);
-      return {
-        success: false,
-        message: "Validation failed",
-        errors: metadataValidationResult.errors,
-      };
-    }
-
-    if (requestBody.metadata.allowList) {
-      const allowListValidationResult = await validateRemoteAllowList(
-        requestBody.metadata.allowList,
-      );
-
-      if (!allowListValidationResult.valid) {
+    try {
+      const metadataValidationResult = validateMetadataAndClaimdata(metadata);
+      if (!metadataValidationResult.valid) {
         this.setStatus(422);
         return {
           success: false,
-          message: "Errors while validating allow list",
-          errors: allowListValidationResult.errors,
+          valid: false,
+          message: "Errors while validating metadata",
+          errors: metadataValidationResult.errors,
         };
       }
-    }
 
-    const cid = await storage.uploadFile({
-      file: jsonToBlob(metadataValidationResult.data),
-    });
-    this.setStatus(201);
-    return {
-      success: true,
-      data: cid,
-    };
+      // Validate allowlist separately if it exists
+      if (metadata.allowList) {
+        const allowListValidationResult = await validateRemoteAllowList(
+          metadata.allowList,
+        );
+        if (!allowListValidationResult.valid) {
+          this.setStatus(422);
+          return {
+            success: false,
+            valid: false,
+            message: "Errors while validating allow list",
+            errors: allowListValidationResult.errors,
+          };
+        }
+      }
+
+      const cid = await storage.uploadFile({
+        file: jsonToBlob(metadataValidationResult.data),
+      });
+      this.setStatus(201);
+
+      return {
+        success: true,
+        data: cid,
+      };
+    } catch (e) {
+      this.setStatus(422);
+      return {
+        success: false,
+        message: "Error while storing metadata",
+        errors: { metadata: (e as Error).message },
+      };
+    }
   }
 
   /**