Skip to content

Commit 9cbabbf

Browse files
committed
feat: poc optional specification of select clause
1 parent b7c9587 commit 9cbabbf

File tree

3 files changed

+31
-11
lines changed

3 files changed

+31
-11
lines changed

src/graphql/schemas/resolvers/baseTypes.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import { GetOrdersArgs } from "../args/orderArgs.js";
1414
import { GetSalesArgs } from "../args/salesArgs.js";
1515
import { GetSignatureRequestArgs } from "../args/signatureRequestArgs.js";
1616
import { GetUserArgs } from "../args/userArgs.js";
17+
import { CachingDatabase } from "../../../types/kyselySupabaseCaching.js";
1718

1819
export function DataResponse<TItem extends object>(
1920
TItemClass: ClassType<TItem>,
@@ -38,13 +39,19 @@ export function createBaseResolver<T extends ClassType>(
3839
readonly supabaseCachingService = container.resolve(SupabaseCachingService);
3940
readonly supabaseDataService = container.resolve(SupabaseDataService);
4041

41-
getMetadata(args: GetMetadataArgs, single: boolean = false) {
42+
getMetadata(
43+
args: GetMetadataArgs,
44+
{
45+
single = false,
46+
select,
47+
}: { single?: boolean; select?: (keyof CachingDatabase["metadata"])[] },
48+
) {
4249
console.debug(
4350
`[${entityFieldName}Resolver::getMetadata] Fetching metadata`,
4451
);
4552

4653
try {
47-
const queries = this.supabaseCachingService.getMetadata(args);
54+
const queries = this.supabaseCachingService.getMetadata(args, select);
4855
if (single) {
4956
return queries.data.executeTakeFirst();
5057
}

src/graphql/schemas/resolvers/hyperboardResolver.ts

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,12 @@ class HyperboardResolver extends HyperboardBaseResolver {
4141
where: { hypercert_id: { in: hypercertIds } },
4242
}).then((res) => res.data),
4343
]);
44-
45-
const metadata = await this.getMetadata({
46-
where: { hypercerts: { hypercert_id: { in: hypercertIds } } },
47-
})
44+
const metadata = await this.getMetadata(
45+
{
46+
where: { hypercerts: { hypercert_id: { in: hypercertIds } } },
47+
},
48+
{ select: ["name", "uri"] },
49+
)
4850
.then((res) => res.data)
4951
.then((res) =>
5052
res.map((metadata) => {
@@ -58,7 +60,6 @@ class HyperboardResolver extends HyperboardBaseResolver {
5860
}),
5961
)
6062
.then((res) => res.map((metadata) => _.omit(metadata, "image")));
61-
6263
// Get a deduplicated list of all owners
6364
const ownerAddresses = _.uniq([
6465
...fractions.map((x) => x?.owner_address),
@@ -72,7 +73,6 @@ class HyperboardResolver extends HyperboardBaseResolver {
7273
) || [],
7374
) || []),
7475
]).filter((x) => !!x) as string[];
75-
7676
const users = await this.getUsers({
7777
where: { address: { in: ownerAddresses } },
7878
}).then((res) => res.data);
@@ -129,7 +129,6 @@ class HyperboardResolver extends HyperboardBaseResolver {
129129
},
130130
};
131131
}) || [];
132-
133132
return {
134133
data: hyperboardWithSections,
135134
count: count ? count : data?.length,

src/services/SupabaseCachingService.ts

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,23 @@ export class SupabaseCachingService extends BaseSupabaseService<CachingDatabase>
5656
};
5757
}
5858

59-
getMetadata(args: GetMetadataArgs) {
59+
getMetadata(
60+
args: GetMetadataArgs,
61+
select?: (keyof CachingDatabase["metadata"])[],
62+
) {
63+
let data = this.db
64+
.selectFrom("metadata")
65+
.selectAll()
66+
.$if(args.where?.hypercerts, (qb) =>
67+
qb.innerJoin("claims", "claims.uri", "metadata.uri"),
68+
);
69+
70+
if (select) {
71+
data = data.clearSelect().select(select.map((s) => `metadata.${s}`));
72+
}
73+
6074
return {
61-
data: this.handleGetData("metadata", args),
75+
data,
6276
count: this.handleGetCount("metadata", args),
6377
};
6478
}

0 commit comments

Comments
 (0)