Commit cfeb432
committed
test: mock RPC URL module in Safe sig verifier tests
Without this patch the Safe signature verification code will get RPC
URLs for the specified chain id. This in turn will load the Alchemy API
key, which is not relevant for our tests.
This patch mocks all of this away, so that the API key doesn't need to
be present in the environment while running tests.
Also lowered the coverage threshold of functiosn to 52 as mocking
getRpcUrl() doesn't touch the internals of this function. This should be
thoroughly tested in a dedicated test file anyway.1 parent ccc0a57 commit cfeb432
File tree
2 files changed
+15
-2
lines changed- test/safe-signatures
2 files changed
+15
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
4 | 17 | | |
5 | 18 | | |
6 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
0 commit comments