Merge pull request #286 from hypercerts-org/bugfix/remove-type-from-markteplace-orders-before-commiting-to-db

fix: exclude type property from order creation request to prevent it …

Author: pheuberger

src/lib/marketplace/EOACreateOrderStrategy.ts

@@ -14,7 +14,7 @@ import { EOACreateOrderRequest } from "./schemas.js";
 import * as Errors from "./errors.js";
 
 export default class EOACreateOrderStrategy extends MarketplaceStrategy {
-  constructor(private readonly request: EOACreateOrderRequest) {
+  constructor(private readonly request: Omit<EOACreateOrderRequest, "type">) {
     super();
   }
 

src/lib/marketplace/MarketplaceStrategyFactory.ts

@@ -6,14 +6,19 @@ import { MarketplaceStrategy } from "./MarketplaceStrategy.js";
 import EOACreateOrderStrategy from "./EOACreateOrderStrategy.js";
 import MultisigCreateOrderStrategy from "./MultisigCreateOrderStrategy.js";
 
-export function createMarketplaceStrategy(
-  request: MultisigCreateOrderRequest | EOACreateOrderRequest,
-): MarketplaceStrategy {
-  switch (request.type) {
+export function createMarketplaceStrategy({
+  type,
+  ...request
+}: MultisigCreateOrderRequest | EOACreateOrderRequest): MarketplaceStrategy {
+  switch (type) {
     case "eoa":
-      return new EOACreateOrderStrategy(request);
+      return new EOACreateOrderStrategy(
+        request as Omit<EOACreateOrderRequest, "type">,
+      );
     case "multisig":
-      return new MultisigCreateOrderStrategy(request);
+      return new MultisigCreateOrderStrategy(
+        request as Omit<MultisigCreateOrderRequest, "type">,
+      );
     default:
       throw new Error("Invalid marketplace request type");
   }

src/lib/marketplace/MultisigCreateOrderStrategy.ts

@@ -30,7 +30,9 @@ type OrderDetails = SafeCreateOrderMessage["message"];
 export default class MultisigCreateOrderStrategy extends MarketplaceStrategy {
   private readonly safeApiKit: SafeApiKit.default;
 
-  constructor(private readonly request: MultisigCreateOrderRequest) {
+  constructor(
+    private readonly request: Omit<MultisigCreateOrderRequest, "type">,
+  ) {
     super();
     this.safeApiKit = SafeApiStrategyFactory.getStrategy(
       request.chainId,