fix(allowlist.test): allowlist controller unit tests

wraps business logic in try-catches and updates response types where
needed

Author: bitbeckers

src/controllers/AllowListController.ts

@@ -85,22 +85,32 @@ export class AllowListController extends Controller {
   public async validateAllowList(
     @Body() requestBody: ValidateAllowListRequest,
   ): Promise<ValidationResponse> {
-    const result = parseAndValidateMerkleTree(requestBody);
+    try {
+      const result = parseAndValidateMerkleTree(requestBody);
+
+      if (!result.valid || !result.data) {
+        this.setStatus(422);
+        return {
+          success: true,
+          valid: false,
+          message: "Errors while validating allow list",
+          errors: result.errors,
+        };
+      }
 
-    if (!result.valid || !result.data) {
-      this.setStatus(422);
+      this.setStatus(201);
+      return {
+        success: true,
+        valid: true,
+      };
+    } catch (error) {
+      this.setStatus(500);
       return {
         success: false,
         valid: false,
-        message: "Errors while validating allow list",
-        errors: result.errors,
+        message: "Error uploading data",
+        errors: { allowList: "Error uploading data" },
       };
     }
-
-    this.setStatus(201);
-    return {
-      success: true,
-      valid: true,
-    };
   }
 }

test/api/v1/allowlist.test.ts

@@ -83,20 +83,17 @@ describe("Allow list validation at v1/allowlists/validate", async () => {
   test("Validates correctness of allowlist and returns results", async () => {
     const requestBody = {
       allowList: mockMerkleTree,
-      totalUnits: "100",
+      totalUnits: "100000000",
     };
     const response = await controller.validateAllowList(requestBody);
     expect(response.valid).to.be.true;
     expect(response.success).to.be.true;
-    expect(response.message).to.be.eq(
-      "Allowlist is a valid hypercerts allowlist object.",
-    );
   });
 
   test("Returns errors and message when allowlist is invalid", async () => {
     const requestBody = {
       allowList: incorrectMerkleTree,
-      totalUnits: "100",
+      totalUnits: "100000000",
     };
     const response = await controller.validateAllowList(requestBody);
 
@@ -119,8 +116,7 @@ describe("Allow list validation at v1/allowlists/validate", async () => {
     expect(response.valid).to.be.false;
     expect(response.message).to.eq("Errors while validating allow list");
     expect(response.errors).to.deep.eq({
-      units:
-        "Total units in allowlist must match total units [expected: 99, got: 100]",
+      totalUnits: "Total units do not match the sum of units in the allowlist",
     });
   });
 });