[bug] "only evaluated" shows not evaluated hypercerts

[holkexyz]

The hypercert from kolektivo doesn't show an evaluation, but shows up on the page when I filter for "only evaluated": https://app.hypercerts.org/hypercerts/42220-0x16bA53B74c234C870c61EFC04cD418B8f2865959-34028236692093846346337460743176821145600

[bitbeckers]

To be precise, it does have an attestation, under the creators feed. What we want to filter out, but this should happen in de FE (API/server side) is filtering out based on the schema used for evaluation. However, this impacts pagination as well.

So we should query on hypercerts which have an evaluation count of 1 or higher, where the evaluation schema UID is the one of the Basic evaluation: https://www.hypercerts.org/docs/developer/attestations

[holkexyz]

ah, that makes sense, good find

[holkexyz]

@bitbeckers is this a quick fix? If so, I would like to prioritize it as we now can end up with the wrong hypercerts on the evaluated hypercerts page

[tnkshuuhei]

@bitbeckers

So we should query on hypercerts which have an evaluation count of 1 or higher, where the evaluation schema UID is the one of the Basic evaluation: https://www.hypercerts.org/docs/developer/attestations

if i'm understanding correctly, we are already filtering based on attestation count greater than equal to 1, but we cannot specify the schema uid for it as I commented here:

hypercerts-app/hypercerts/getAllHypercerts.ts

Lines 98 to 103 in c087a37

	if (filter === "evaluated") {
	where.attestations_count = { gte: 1 };
	// TODO: Specify evaluations schemaId so that '/explore' page can only filter evaluation attestations
	// where.eas_schema = { uid: { eq: EVALUATIONS_SCHEMA_UID } };
	}
	if (chainId) {

prob related to this issue? hypercerts-org/hypercerts-api#219

[holkexyz]

@tnkshuuhei how is the progress on this one? Or are you waiting for input from @bitbeckers?

[tnkshuuhei]

@tnkshuuhei how is the progress on this one? Or are you waiting for input from @bitbeckers?

YES, this requires a bit of changes in API

[bitbeckers]

Yes we can either get it client side after fetching the data, or when the API refactor is done by end of week