fix(sdk-core): convert blob upload results to proper JsonBlobRef format

When uploading images for collection avatars/banners, validation failed with:
'ValidationError: Invalid collection record: Record/banner/image should be a blob ref'

The issue: blobs.upload() returns { ref, mimeType, size } but AT Protocol
lexicons define SmallImage.image and LargeImage.image as BlobRef, which
requires the full structure including $type: 'blob'.

Two helper methods were passing raw upload results directly:
- resolveCollectionImageInput() for avatar/banner images
- resolveUriOrBlob() for location/attachment blobs

The SDK already had blobToJsonRef() to add the required $type: 'blob',
but these methods weren't using it. Other code paths (uploadImageBlob,
updateClaim) correctly used blobToJsonRef() and worked fine.

Without $type: 'blob', the server rejects the record because the blob
reference doesn't match the expected BlobRef schema from @atproto/lexicon.

Author: pheuberger

packages/sdk-core/src/repository/HypercertOperationsImpl.ts

@@ -959,7 +959,7 @@ export class HypercertOperationsImpl extends EventEmitter<HypercertEvents> imple
     const uploadResult = await this.blobs.upload(content);
     return {
       $type: "org.hypercerts.defs#smallBlob" as const,
-      blob: uploadResult,
+      blob: this.blobToJsonRef(uploadResult),
     };
   }
 
@@ -974,11 +974,12 @@ export class HypercertOperationsImpl extends EventEmitter<HypercertEvents> imple
     }
 
     const uploadResult = await this.blobs.upload(input);
+    const blobRef = this.blobToJsonRef(uploadResult);
     if (isBanner) {
-      return { $type: "org.hypercerts.defs#largeImage" as const, image: uploadResult };
+      return { $type: "org.hypercerts.defs#largeImage" as const, image: blobRef };
     }
 
-    return { $type: "org.hypercerts.defs#smallImage" as const, image: uploadResult };
+    return { $type: "org.hypercerts.defs#smallImage" as const, image: blobRef };
   }
 
   /**

packages/sdk-core/tests/repository/HypercertOperationsImpl.test.ts

@@ -994,7 +994,8 @@ describe("HypercertOperationsImpl", () => {
       expect(call.record.location).toEqual({
         $type: "org.hypercerts.defs#smallBlob", // Your code wraps it in smallBlob
         blob: {
-          // The actual blob data is nested here
+          // The actual blob data is nested here with $type: "blob" for AT Protocol compliance
+          $type: "blob",
           ref: { $link: "blob-cid" },
           mimeType: "application/geo+json",
           size: 100,
@@ -1203,7 +1204,7 @@ describe("HypercertOperationsImpl", () => {
       expect(call.record.content).toEqual([
         {
           $type: "org.hypercerts.defs#smallBlob",
-          blob: { ref: { $link: "blob-cid" }, mimeType: "application/pdf", size: 100 },
+          blob: { $type: "blob", ref: { $link: "blob-cid" }, mimeType: "application/pdf", size: 100 },
         },
       ]);
     });
@@ -1266,7 +1267,7 @@ describe("HypercertOperationsImpl", () => {
       });
       expect(call.record.content[1]).toEqual({
         $type: "org.hypercerts.defs#smallBlob",
-        blob: { ref: { $link: "blob-cid" }, mimeType: "application/pdf", size: 100 },
+        blob: { $type: "blob", ref: { $link: "blob-cid" }, mimeType: "application/pdf", size: 100 },
       });
     });
 
@@ -2053,29 +2054,18 @@ describe("HypercertOperationsImpl", () => {
       const logoBlob = new Blob(["logo"], { type: "image/png" });
       const headerBlob = new Blob(["header"], { type: "image/jpeg" });
 
-      mockAgent.com.atproto.repo.uploadBlob.mockResolvedValueOnce({
-        success: true,
-        data: {
-          blob: {
-            $type: "blob",
-            ref: { $link: "bafyrei-logo" },
-            mimeType: "image/png",
-            size: 150,
-          },
-        },
-      });
-
-      mockAgent.com.atproto.repo.uploadBlob.mockResolvedValueOnce({
-        success: true,
-        data: {
-          blob: {
-            $type: "blob",
-            ref: { $link: "bafyrei-header" },
-            mimeType: "image/jpeg",
-            size: 250,
-          },
-        },
-      });
+      // Mock blob uploads via BlobOperations (not agent.uploadBlob)
+      mockBlobs.upload
+        .mockResolvedValueOnce({
+          ref: { $link: "bafyrei-logo" },
+          mimeType: "image/png",
+          size: 150,
+        })
+        .mockResolvedValueOnce({
+          ref: { $link: "bafyrei-header" },
+          mimeType: "image/jpeg",
+          size: 250,
+        });
 
       mockAgent.com.atproto.repo.createRecord.mockResolvedValue({
         success: true,
@@ -2091,16 +2081,23 @@ describe("HypercertOperationsImpl", () => {
       });
 
       expect(result.uri).toContain("collection");
+      expect(mockBlobs.upload).toHaveBeenCalledTimes(2);
       expect(mockAgent.com.atproto.repo.createRecord).toHaveBeenCalledWith(
         expect.objectContaining({
           record: expect.objectContaining({
             title: "Climate Action Project",
             type: "project",
             avatar: expect.objectContaining({
               $type: "org.hypercerts.defs#smallImage",
+              image: expect.objectContaining({
+                $type: "blob",
+              }),
             }),
             banner: expect.objectContaining({
               $type: "org.hypercerts.defs#largeImage",
+              image: expect.objectContaining({
+                $type: "blob",
+              }),
             }),
           }),
         }),
@@ -2683,7 +2680,7 @@ describe("HypercertOperationsImpl", () => {
         const createCall = mockAgent.com.atproto.repo.createRecord.mock.calls[0][0];
         expect(createCall.record.avatar).toEqual({
           $type: "org.hypercerts.defs#smallImage",
-          image: { ref: { $link: "avatar-cid" }, mimeType: "image/png", size: 100 },
+          image: { $type: "blob", ref: { $link: "avatar-cid" }, mimeType: "image/png", size: 100 },
         });
       });
 
@@ -2705,7 +2702,7 @@ describe("HypercertOperationsImpl", () => {
         const createCall = mockAgent.com.atproto.repo.createRecord.mock.calls[0][0];
         expect(createCall.record.banner).toEqual({
           $type: "org.hypercerts.defs#largeImage",
-          image: { ref: { $link: "banner-cid" }, mimeType: "image/jpeg", size: 200 },
+          image: { $type: "blob", ref: { $link: "banner-cid" }, mimeType: "image/jpeg", size: 200 },
         });
       });
 
@@ -3220,7 +3217,7 @@ describe("HypercertOperationsImpl", () => {
         const putCall = mockAgent.com.atproto.repo.putRecord.mock.calls[0][0];
         expect(putCall.record.avatar).toEqual({
           $type: "org.hypercerts.defs#smallImage",
-          image: { ref: { $link: "new-avatar-cid" }, mimeType: "image/png", size: 150 },
+          image: { $type: "blob", ref: { $link: "new-avatar-cid" }, mimeType: "image/png", size: 150 },
         });
       });